Fix: remove double consumer_del_stream in error path

During a recv_stream call, an error path could have try to delete a
stream two times and could ultimately have triggererd a double free and
refcount issues on the channel.

Signed-off-by: David Goulet <dgoulet@efficios.com>

diff --git a/src/common/ust-consumer/ust-consumer.c b/src/common/ust-consumer/ust-consumer.c
index 5dbd6ba4b4aff3feea113a2092165d13bf5bd160..9f87083384626ea21f4a397d1037df612cf9f34d 100644 (file)
--- a/src/common/ust-consumer/ust-consumer.c
+++ b/src/common/ust-consumer/ust-consumer.c
@@ -589,7 +589,6 @@ int lttng_ustconsumer_on_recv_stream(struct lttng_consumer_stream *stream)
 
        ret = lttng_ustconsumer_add_stream(stream);
        if (ret) {
-               consumer_del_stream(stream, NULL);
                ret = -1;
                goto error;
        }