Tests: refuse to run test suite if lttng processes are present

The test suite often fails because of unclean environments where
stale LTTng processes are left running. Since the test suite
assumes that no LTTng process (daemons and test applications) are
running, it makes sense to force the user to kill all those
processes before running the test suite.

The warn_processes.sh script now prints an error and returns 1
to indicate an early failure to the test harness.

It is possible to circumvent this check by invoking the tests
manually or by removing the "exit 1" from the warn_processes.sh
script if there is a need to have persistent processes across
the execution of the test suite.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

diff --git a/tests/utils/warn_processes.sh b/tests/utils/warn_processes.sh
index fee1d0f58bfa24d0d716ab7a60e2bcd6d9c0c232..6858b86632d2f7297e8eff082d20f1ece278a8bd 100755 (executable)
--- a/tests/utils/warn_processes.sh
+++ b/tests/utils/warn_processes.sh
@@ -6,7 +6,7 @@ if [ x$LTTNG_TOOLS_TESTS_DISABLE_WARN_LTTNG_PROCESSES == x1 ]; then
        exit
 fi
 
-color_warn='\E[1;33m'
+color_error='\E[1;91m'
 color_reset='\E[0m'
 color_bold='\E[1m'
 
@@ -15,11 +15,13 @@ lttng_processes="$("$PGREP" -l 'lttng|gen-ust-.+')"
 if [ $? -eq 0 ]; then
        pids="$(cut -d ' ' -f 1 <<< "$lttng_processes" | tr '\n' ' ')"
 
-       echo -e "${color_warn}Warning: the following LTTng processes were detected running on the system:$color_reset"
+       echo -e "${color_error}Error: the following LTTng processes were detected running on the system:$color_reset"
        echo
        echo "$lttng_processes"
        echo
        echo -e "Here's how to kill them: ${color_bold}kill -9 $pids$color_reset"
-       echo -e "${color_warn}If you leave them alive, some tests could fail.$color_reset"
        echo
+       echo "The test suite will not run in the presence of those processes since its result may not be reliable."
+       echo
+       exit 1
 fi