summary |
shortlog |
log |
commit | commitdiff |
tree
raw |
patch |
inline | side by side (from parent 1:
28ca843)
The initial decrement was missing from the implementation. It now
behaves exactly like the urcu.c wait/wakeup code.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
thread_call_rcu_data = crdp;
for (;;) {
thread_call_rcu_data = crdp;
for (;;) {
+ if (!(crdp->flags & URCU_CALL_RCU_RT)) {
+ uatomic_dec(&crdp->futex);
+ /* Decrement futex before reading call_rcu list */
+ cmm_smp_mb();
+ }
if (&crdp->cbs.head != _CMM_LOAD_SHARED(crdp->cbs.tail)) {
while ((cbs = _CMM_LOAD_SHARED(crdp->cbs.head)) == NULL)
poll(NULL, 0, 1);
if (&crdp->cbs.head != _CMM_LOAD_SHARED(crdp->cbs.tail)) {
while ((cbs = _CMM_LOAD_SHARED(crdp->cbs.head)) == NULL)
poll(NULL, 0, 1);
} while (cbs != NULL);
uatomic_sub(&crdp->qlen, cbcount);
}
} while (cbs != NULL);
uatomic_sub(&crdp->qlen, cbcount);
}
- if (crdp->flags & URCU_CALL_RCU_STOP)
+ if (crdp->flags & URCU_CALL_RCU_STOP) {
+ if (!(crdp->flags & URCU_CALL_RCU_RT)) {
+ /*
+ * Read call_rcu list before write futex.
+ */
+ cmm_smp_mb();
+ uatomic_set(&crdp->futex, 0);
+ }
- if (crdp->flags & URCU_CALL_RCU_RT)
- poll(NULL, 0, 10);
- else {
+ }
+ if (!(crdp->flags & URCU_CALL_RCU_RT)) {
if (&crdp->cbs.head == _CMM_LOAD_SHARED(crdp->cbs.tail))
call_rcu_wait(crdp);
if (&crdp->cbs.head == _CMM_LOAD_SHARED(crdp->cbs.tail))
call_rcu_wait(crdp);
}
call_rcu_lock(&crdp->mtx);
crdp->flags |= URCU_CALL_RCU_STOPPED;
}
call_rcu_lock(&crdp->mtx);
crdp->flags |= URCU_CALL_RCU_STOPPED;