Fix: Move initialization of queue_pipe_fd after null check of handle

Fixes coverity #1399732

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

diff --git a/src/bin/lttng-sessiond/rotation-thread.c b/src/bin/lttng-sessiond/rotation-thread.c
index 7bd6c681982fe1c18b6f0b039176650f17d6af2a..2b44036a2276c224b108fd26760d3063770660c9 100644 (file)
--- a/src/bin/lttng-sessiond/rotation-thread.c
+++ b/src/bin/lttng-sessiond/rotation-thread.c
@@ -832,8 +832,7 @@ void *thread_rotation(void *data)
        int ret;
        struct rotation_thread_handle *handle = data;
        struct rotation_thread thread;
        int ret;
        struct rotation_thread_handle *handle = data;
        struct rotation_thread thread;

-       const int queue_pipe_fd = lttng_pipe_get_readfd(
-                       handle->rotation_timer_queue->event_pipe);
+       int queue_pipe_fd;

 
        DBG("[rotation-thread] Started rotation thread");
 
 
        DBG("[rotation-thread] Started rotation thread");
 


@@ -842,6 +841,9 @@ void *thread_rotation(void *data)
                goto end;
        }
 
                goto end;
        }
 

+       queue_pipe_fd = lttng_pipe_get_readfd(
+                       handle->rotation_timer_queue->event_pipe);
+

        rcu_register_thread();
        rcu_thread_online();
 
        rcu_register_thread();
        rcu_thread_online();