X-Git-Url: https://git.liburcu.org/?a=blobdiff_plain;f=src%2Fbin%2Flttng-sessiond%2Fnotification-thread-events.cpp;h=9e1aa5300b8416e68fdc4672da8beedce66fc985;hb=1c9a0b0e83c7e073c4e576c0bed95de335b0e502;hp=cf18f63f7f2d340a0a01703d046bf97a88d0b26a;hpb=48b7cdc221a445188d6d9bd08fc1686837e71224;p=lttng-tools.git

diff --git a/src/bin/lttng-sessiond/notification-thread-events.cpp b/src/bin/lttng-sessiond/notification-thread-events.cpp
index cf18f63f7..9e1aa5300 100644
--- a/src/bin/lttng-sessiond/notification-thread-events.cpp
+++ b/src/bin/lttng-sessiond/notification-thread-events.cpp
@@ -1031,8 +1031,15 @@ int evaluate_condition_for_client(const struct lttng_trigger *trigger,
 	struct lttng_evaluation *evaluation = NULL;
 	struct notification_client_list client_list = {
 		.lock = PTHREAD_MUTEX_INITIALIZER,
+		.ref = {},
+		.condition = NULL,
+		.triggers_list = {},
+		.clients_list = {},
+		.notification_trigger_clients_ht = NULL,
+		.notification_trigger_clients_ht_node = {},
+		.rcu_node = {},
 	};
-	struct notification_client_list_element client_list_element = { 0 };
+	struct notification_client_list_element client_list_element = {};
 	uid_t object_uid = 0;
 	gid_t object_gid = 0;
 
@@ -1279,8 +1286,7 @@ void free_notification_client_rcu(struct rcu_head *node)
 }
 
 static
-void notification_client_destroy(struct notification_client *client,
-		struct notification_thread_state *state)
+void notification_client_destroy(struct notification_client *client)
 {
 	if (!client) {
 		return;
@@ -2065,7 +2071,7 @@ int drain_event_notifier_notification_pipe(
 		struct notification_thread_state *state,
 		int pipe, enum lttng_domain_type domain)
 {
-	struct lttng_poll_event events = {0};
+	struct lttng_poll_event events = {};
 	int ret;
 
 	ret = lttng_poll_create(&events, 1, LTTNG_CLOEXEC);
@@ -2233,7 +2239,7 @@ end:
 }
 
 static int handle_notification_thread_command_list_triggers(
-		struct notification_thread_handle *handle,
+		struct notification_thread_handle *handle __attribute__((unused)),
 		struct notification_thread_state *state,
 		uid_t client_uid,
 		struct lttng_triggers **triggers,
@@ -3396,7 +3402,7 @@ int handle_notification_thread_client_connect(
 	return ret;
 
 error:
-	notification_client_destroy(client, state);
+	notification_client_destroy(client);
 	return ret;
 }
 
@@ -3438,7 +3444,7 @@ int notification_thread_client_disconnect(
 	 * Client no longer accessible to other threads (through the
 	 * client lists).
 	 */
-	notification_client_destroy(client, state);
+	notification_client_destroy(client);
 	return ret;
 }
 
@@ -3701,6 +3707,7 @@ int client_send_command_reply(struct notification_client *client,
 	struct lttng_notification_channel_message msg = {
 		.type = (int8_t) LTTNG_NOTIFICATION_CHANNEL_MESSAGE_TYPE_COMMAND_REPLY,
 		.size = sizeof(reply),
+		.fds = 0,
 	};
 	char buffer[sizeof(msg) + sizeof(reply)];
 	enum client_transmission_status transmission_status;
@@ -3746,7 +3753,7 @@ error:
 
 static
 int client_handle_message_unknown(struct notification_client *client,
-		struct notification_thread_state *state)
+		struct notification_thread_state *state __attribute__((unused)))
 {
 	int ret;
 	/*
@@ -3805,6 +3812,7 @@ int client_handle_message_handshake(struct notification_client *client,
 	const struct lttng_notification_channel_message msg_header = {
 			.type = LTTNG_NOTIFICATION_CHANNEL_MESSAGE_TYPE_HANDSHAKE,
 			.size = sizeof(handshake_reply),
+			.fds = 0,
 	};
 	enum lttng_notification_channel_status status =
 			LTTNG_NOTIFICATION_CHANNEL_STATUS_OK;
@@ -4186,7 +4194,7 @@ bool evaluate_session_consumed_size_condition(
 static
 int evaluate_buffer_condition(const struct lttng_condition *condition,
 		struct lttng_evaluation **evaluation,
-		const struct notification_thread_state *state,
+		const struct notification_thread_state *state __attribute__((unused)),
 		const struct channel_state_sample *previous_sample,
 		const struct channel_state_sample *latest_sample,
 		uint64_t previous_session_consumed_total,
@@ -4275,6 +4283,8 @@ int client_notification_overflow(struct notification_client *client)
 	int ret = 0;
 	const struct lttng_notification_channel_message msg = {
 		.type = (int8_t) LTTNG_NOTIFICATION_CHANNEL_MESSAGE_TYPE_NOTIFICATION_DROPPED,
+		.size = 0,
+		.fds = 0,
 	};
 
 	ASSERT_LOCKED(client->lock);
@@ -4379,6 +4389,8 @@ int notification_client_list_send_evaluation(
 	};
 	struct lttng_notification_channel_message msg_header = {
 		.type = (int8_t) LTTNG_NOTIFICATION_CHANNEL_MESSAGE_TYPE_NOTIFICATION,
+		.size = 0,
+		.fds = 0,
 	};
 	const struct lttng_credentials *trigger_creds =
 			lttng_trigger_get_credentials(trigger);