package org.lttng.ust.agent.context;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.fail;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.fail;
import java.io.IOException;
-import org.junit.Before;
-import org.junit.Test;
-import org.junit.runner.RunWith;
-import org.lttng.ust.agent.utils.TestPrintRunner;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.junit.jupiter.api.BeforeEach;
+import org.lttng.ust.agent.utils.TestPrintExtension;
/**
* Generic tests related to the context retrieval mechanisms.
*
* @author Alexandre Montplaisir
*/
-@RunWith(TestPrintRunner.class)
+@ExtendWith(TestPrintExtension.class)
public class ContextRegistrationIT {
private ContextInfoManager mgr;
/**
* Test setup
*/
- @Before
+ @BeforeEach
public void testSetup() {
try {
mgr = ContextInfoManager.getInstance();
} catch (SecurityException | IOException e) {
- fail();
+ fail(e.getMessage());
}
}
*/
@Test
public void testRegistration() {
- final String retrieverName = "test-retriever";
+ final String retrieverName = "test.retriever";
final IContextInfoRetriever emptyRetriever = (key -> null);
- mgr.registerContextInfoRetriever(retrieverName, emptyRetriever);
+ boolean ret = mgr.registerContextInfoRetriever(retrieverName, emptyRetriever);
+ assertTrue(ret);
IContextInfoRetriever retriever2 = mgr.getContextInfoRetriever(retrieverName);
assertEquals(emptyRetriever, retriever2);
mgr.unregisterContextInfoRetriever(retrieverName);
}
+
+ /**
+ * Test registration of retrievers with invalid names.
+ */
+ @Test
+ public void testRegistrationInvalid() {
+ String[] invalidNames = new String[] { "test.rétriever", "with space", "1numberfirst" };
+ for (String retrieverName : invalidNames) {
+ final IContextInfoRetriever emptyRetriever = (key -> null);
+
+ boolean ret = mgr.registerContextInfoRetriever(retrieverName, emptyRetriever);
+ assertFalse(ret);
+
+ IContextInfoRetriever retriever = mgr.getContextInfoRetriever(retrieverName);
+ assertNull(retriever);
+ }
+ }
}