#include <fcntl.h>
#include <poll.h>
#include <regex.h>
-
-#include <urcu-bp.h>
+#include <urcu/uatomic_arch.h>
#include <ust/marker.h>
#include <ust/tracectl.h>
static int init_socket(void);
-/* This needs to be called whenever a new thread is created. It notifies
- * liburcu of the new thread.
- */
-
-void ust_register_thread(void)
-{
- rcu_register_thread();
-}
-
int fd_notif = -1;
void notif_cb(void)
{
}
}
- if(found) {
- buffers_to_export--;
- }
- else {
+ if(!found) {
ERR("channel not found (%s)", channel_and_cpu);
}
return retval;
}
-unsigned int poweroftwo(unsigned int x)
+static unsigned int poweroftwo(unsigned int x)
{
unsigned int power2 = 1;
unsigned int hardcoded = 2147483648; /* FIX max 2^31 */
trace = _ltt_trace_find_setup(trace_name);
if(trace == NULL) {
ERR("cannot find trace!");
- ltt_unlock_traces();
retval = -1;
goto end;
}
ERR("unable to find channel");
}
- ltt_unlock_traces();
-
end:
+ ltt_unlock_traces();
return retval;
}
trace = _ltt_trace_find_setup(trace_name);
if(trace == NULL) {
ERR("cannot find trace!");
- ltt_unlock_traces();
retval = -1;
goto end;
}
ERR("unable to find channel");
}
- ltt_unlock_traces();
-
end:
+ ltt_unlock_traces();
return retval;
}
ltt_lock_traces();
trace = _ltt_trace_find(trace_name);
- ltt_unlock_traces();
if(trace == NULL) {
- char *reply;
int result;
WARN("Cannot find trace. It was likely destroyed by the user.");
- asprintf(&reply, "%s", "NOTFOUND");
- result = ustcomm_send_reply(&ustcomm_app.server, reply, src);
+ result = ustcomm_send_reply(&ustcomm_app.server, "NOTFOUND", src);
if(result) {
ERR("ustcomm_send_reply failed");
- free(reply);
retval = -1;
- goto free_short_chan_name;
+ goto unlock_traces;
}
- free(reply);
- goto free_short_chan_name;
+ goto unlock_traces;
}
for(i=0; i<trace->nr_channels; i++) {
bc = (struct blocked_consumer *) malloc(sizeof(struct blocked_consumer));
if(bc == NULL) {
ERR("malloc returned NULL");
- goto free_short_chan_name;
+ goto unlock_traces;
}
bc->fd_consumer = src->fd;
bc->fd_producer = buf->data_ready_fd_read;
list_add(&bc->list, &blocked_consumers);
+ /* Being here is the proof the daemon has mapped the buffer in its
+ * memory. We may now decrement buffers_to_export.
+ */
+ if(uatomic_read(&buf->consumed) == 0) {
+ DBG("decrementing buffers_to_export");
+ buffers_to_export--;
+ }
+
break;
}
}
ERR("unable to find channel");
}
+ unlock_traces:
+ ltt_unlock_traces();
+
free_short_chan_name:
free(ch_name);
ltt_lock_traces();
trace = _ltt_trace_find(trace_name);
- ltt_unlock_traces();
if(trace == NULL) {
WARN("Cannot find trace. It was likely destroyed by the user.");
- asprintf(&reply, "%s", "NOTFOUND");
- result = ustcomm_send_reply(&ustcomm_app.server, reply, src);
+ result = ustcomm_send_reply(&ustcomm_app.server, "NOTFOUND", src);
if(result) {
ERR("ustcomm_send_reply failed");
- free(reply);
retval = -1;
- goto free_short_chan_name;
+ goto unlock_traces;
}
- free(reply);
- goto free_short_chan_name;
+ goto unlock_traces;
}
for(i=0; i<trace->nr_channels; i++) {
ERR("ustcomm_send_reply failed");
free(reply);
retval = -1;
- goto free_channel_and_cpu;
+ goto unlock_traces;
}
free(reply);
ERR("unable to find channel");
}
+ unlock_traces:
+ ltt_unlock_traces();
free_short_chan_name:
free(ch_name);
free_consumed_old_str:
{
int result;
- ust_register_thread();
-
DBG("LISTENER");
for(;;) {
DBG("trace destroy");
- result = ltt_trace_destroy(trace_name);
+ result = ltt_trace_destroy(trace_name, 0);
if(result < 0) {
ERR("ltt_trace_destroy failed");
return (void *)1;
*/
pidunique = make_pidunique();
- /* Initialize RCU in case the constructor order is not good. */
- rcu_init();
-
- /* It is important to do this before events start to be generated. */
- ust_register_thread();
-
DBG("Tracectl constructor");
- /* Must create socket before signal handler to prevent races.
- */
result = init_socket();
if(result == -1) {
ERR("init_socket error");
ERR("ltt_trace_stop error");
}
- result = ltt_trace_destroy("auto");
+ result = ltt_trace_destroy("auto", 0);
if(result == -1) {
ERR("ltt_trace_destroy error");
}
struct blocked_consumer *deletable_bc = NULL;
int result;
+ /* FIXME: technically, the locks could have been taken before the fork */
DBG("ust: forking");
+
+ /* break lock if necessary */
+ ltt_unlock_traces();
+
ltt_trace_stop("auto");
- ltt_trace_destroy("auto");
+ ltt_trace_destroy("auto", 1);
/* Delete all active connections */
ustcomm_close_all_connections(&ustcomm_app.server);
list_del(&bc->list);
}
+ ustcomm_free_app(&ustcomm_app);
+
+ buffers_to_export = 0;
have_listener = 0;
- create_listener();
init_socket();
+ create_listener();
ltt_trace_setup("auto");
result = ltt_trace_set_type("auto", "ustrelay");
if(result < 0) {