projects
/
lttng-tools.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Fix: validate whether event notifiers are supported by UST application
[lttng-tools.git]
/
src
/
bin
/
lttng-sessiond
/
event-notifier-error-accounting.c
diff --git
a/src/bin/lttng-sessiond/event-notifier-error-accounting.c
b/src/bin/lttng-sessiond/event-notifier-error-accounting.c
index 47366e9e9a95b75211281c3422489e51a2c586ab..74b15bf98a655c397436dbad532ca931d7493499 100644
(file)
--- a/
src/bin/lttng-sessiond/event-notifier-error-accounting.c
+++ b/
src/bin/lttng-sessiond/event-notifier-error-accounting.c
@@
-381,6
+381,12
@@
struct ust_error_accounting_entry *ust_error_accounting_entry_create(
.has_overflow = false,
};
.has_overflow = false,
};
+ if (!ust_app_supports_counters(app)) {
+ DBG("Refusing to create accounting entry for application (unsupported feature): app name = '%s', app ppid = %d",
+ app->name, (int) app->ppid);
+ goto error;
+ }
+
entry = zmalloc(sizeof(struct ust_error_accounting_entry));
if (!entry) {
PERROR("Failed to allocate event notifier error acounting entry")
entry = zmalloc(sizeof(struct ust_error_accounting_entry));
if (!entry) {
PERROR("Failed to allocate event notifier error acounting entry")
@@
-586,6
+592,11
@@
event_notifier_error_accounting_register_app(struct ust_app *app)
enum event_notifier_error_accounting_status status;
struct lttng_ust_abi_object_data **cpu_counters;
enum event_notifier_error_accounting_status status;
struct lttng_ust_abi_object_data **cpu_counters;
+ if (!ust_app_supports_counters(app)) {
+ status = EVENT_NOTIFIER_ERROR_ACCOUNTING_STATUS_UNSUPPORTED;
+ goto end;
+ }
+
/*
* Check if we already have a error counter for the user id of this
* app. If not, create one.
/*
* Check if we already have a error counter for the user id of this
* app. If not, create one.
@@
-688,7
+699,7
@@
event_notifier_error_accounting_register_app(struct ust_app *app)
app->event_notifier_group.nr_counter_cpu = entry->nr_counter_cpu_fds;
app->event_notifier_group.counter_cpu = cpu_counters;
cpu_counters = NULL;
app->event_notifier_group.nr_counter_cpu = entry->nr_counter_cpu_fds;
app->event_notifier_group.counter_cpu = cpu_counters;
cpu_counters = NULL;
- goto end;
+ goto end
_unlock
;
error_send_cpu_counter_data:
error_duplicate_cpu_counter:
error_send_cpu_counter_data:
error_duplicate_cpu_counter:
@@
-716,8
+727,9
@@
error_duplicate_counter:
ust_error_accounting_entry_put(entry);
error_creating_entry:
app->event_notifier_group.counter = NULL;
ust_error_accounting_entry_put(entry);
error_creating_entry:
app->event_notifier_group.counter = NULL;
-end:
+end
_unlock
:
rcu_read_unlock();
rcu_read_unlock();
+end:
return status;
}
return status;
}
This page took
0.024466 seconds
and
4
git commands to generate.