Commit | Line | Data |
---|---|---|
f3ed775e | 1 | /* |
21cf9b6b | 2 | * Copyright (C) 2011 EfficiOS Inc. |
f3ed775e | 3 | * |
ab5be9fa | 4 | * SPDX-License-Identifier: GPL-2.0-only |
f3ed775e | 5 | * |
f3ed775e DG |
6 | */ |
7 | ||
6c1c0768 | 8 | #define _LGPL_SOURCE |
28ab034a JG |
9 | #include <common/compat/getenv.hpp> |
10 | #include <common/compat/string.hpp> | |
8884bbc1 | 11 | #include <common/make-unique-wrapper.hpp> |
27b5aa57 | 12 | #include <common/scope-exit.hpp> |
28ab034a JG |
13 | #include <common/sessiond-comm/sessiond-comm.hpp> |
14 | #include <common/string-utils/string-utils.hpp> | |
15 | #include <common/utils.hpp> | |
16 | ||
17 | #include <ctype.h> | |
18 | #include <inttypes.h> | |
f3ed775e | 19 | #include <popt.h> |
bf1413aa | 20 | #include <sstream> |
f3ed775e DG |
21 | #include <stdio.h> |
22 | #include <stdlib.h> | |
bf1413aa | 23 | #include <string> |
f3ed775e DG |
24 | #include <sys/stat.h> |
25 | #include <sys/types.h> | |
26 | #include <unistd.h> | |
bf1413aa | 27 | #include <vector> |
f3ed775e | 28 | |
89476427 | 29 | /* Mi dependancy */ |
28ab034a JG |
30 | #include "../command.hpp" |
31 | #include "../loglevel.hpp" | |
32 | #include "../uprobe.hpp" | |
33 | ||
c9e313bc | 34 | #include <common/mi-lttng.hpp> |
89476427 | 35 | |
c9e313bc SM |
36 | #include <lttng/domain-internal.hpp> |
37 | #include <lttng/event-internal.hpp> | |
7e8f2e9c | 38 | |
8ab7c0d9 | 39 | #if (LTTNG_SYMBOL_NAME_LEN == 256) |
28ab034a | 40 | #define LTTNG_SYMBOL_NAME_LEN_SCANF_IS_A_BROKEN_API "255" |
8ab7c0d9 MD |
41 | #endif |
42 | ||
d512607f | 43 | namespace { |
8884bbc1 JG |
44 | void _mi_lttng_writer_deleter_func(mi_writer *writer) |
45 | { | |
46 | if (writer && mi_lttng_writer_destroy(writer)) { | |
47 | LTTNG_THROW_ERROR("Failed to destroy mi_writer instance"); | |
48 | } | |
49 | } | |
50 | ||
51 | using mi_writer_uptr = std::unique_ptr< | |
52 | mi_writer, | |
53 | lttng::memory::create_deleter_class<mi_writer, _mi_lttng_writer_deleter_func>::deleter>; | |
bf1413aa | 54 | using event_rule_patterns = std::vector<std::string>; |
d512607f JG |
55 | |
56 | int opt_event_type; | |
57 | const char *opt_loglevel; | |
58 | int opt_loglevel_type; | |
59 | int opt_kernel; | |
60 | char *opt_session_name; | |
61 | int opt_userspace; | |
62 | int opt_jul; | |
63 | int opt_log4j; | |
64 | int opt_python; | |
65 | int opt_enable_all; | |
66 | char *opt_probe; | |
67 | char *opt_userspace_probe; | |
68 | char *opt_function; | |
69 | char *opt_channel_name; | |
70 | char *opt_filter; | |
71 | char *opt_exclude; | |
f3ed775e | 72 | |
8884bbc1 JG |
73 | struct lttng_handle *handle; |
74 | mi_writer_uptr writer; | |
75 | ||
4fc83d94 PP |
76 | #ifdef LTTNG_EMBED_HELP |
77 | static const char help_msg[] = | |
78 | #include <lttng-enable-event.1.h> | |
28ab034a | 79 | ; |
4fc83d94 PP |
80 | #endif |
81 | ||
f3ed775e DG |
82 | enum { |
83 | OPT_HELP = 1, | |
f3ed775e | 84 | OPT_TRACEPOINT, |
cf0e5467 | 85 | OPT_PROBE, |
dcabc190 | 86 | OPT_USERSPACE_PROBE, |
f3ed775e | 87 | OPT_FUNCTION, |
a54bd42d | 88 | OPT_SYSCALL, |
eeac7d46 | 89 | OPT_USERSPACE, |
0cda4f28 MD |
90 | OPT_LOGLEVEL, |
91 | OPT_LOGLEVEL_ONLY, | |
679b4943 | 92 | OPT_LIST_OPTIONS, |
53a80697 | 93 | OPT_FILTER, |
fac3366c | 94 | OPT_EXCLUDE, |
f3ed775e DG |
95 | }; |
96 | ||
d512607f | 97 | struct poptOption long_options[] = { |
f3ed775e | 98 | /* longName, shortName, argInfo, argPtr, value, descrip, argDesc */ |
cd9adb8b JG |
99 | { "help", 'h', POPT_ARG_NONE, nullptr, OPT_HELP, nullptr, nullptr }, |
100 | { "session", 's', POPT_ARG_STRING, &opt_session_name, 0, nullptr, nullptr }, | |
101 | { "all", 'a', POPT_ARG_VAL, &opt_enable_all, 1, nullptr, nullptr }, | |
102 | { "channel", 'c', POPT_ARG_STRING, &opt_channel_name, 0, nullptr, nullptr }, | |
103 | { "kernel", 'k', POPT_ARG_VAL, &opt_kernel, 1, nullptr, nullptr }, | |
104 | { "userspace", 'u', POPT_ARG_NONE, nullptr, OPT_USERSPACE, nullptr, nullptr }, | |
105 | { "jul", 'j', POPT_ARG_VAL, &opt_jul, 1, nullptr, nullptr }, | |
106 | { "log4j", 'l', POPT_ARG_VAL, &opt_log4j, 1, nullptr, nullptr }, | |
107 | { "python", 'p', POPT_ARG_VAL, &opt_python, 1, nullptr, nullptr }, | |
108 | { "tracepoint", 0, POPT_ARG_NONE, nullptr, OPT_TRACEPOINT, nullptr, nullptr }, | |
109 | { "probe", 0, POPT_ARG_STRING, &opt_probe, OPT_PROBE, nullptr, nullptr }, | |
110 | { "userspace-probe", | |
111 | 0, | |
112 | POPT_ARG_STRING, | |
113 | &opt_userspace_probe, | |
114 | OPT_USERSPACE_PROBE, | |
115 | nullptr, | |
116 | nullptr }, | |
117 | { "function", 0, POPT_ARG_STRING, &opt_function, OPT_FUNCTION, nullptr, nullptr }, | |
118 | { "syscall", 0, POPT_ARG_NONE, nullptr, OPT_SYSCALL, nullptr, nullptr }, | |
119 | { "loglevel", 0, POPT_ARG_STRING, nullptr, OPT_LOGLEVEL, nullptr, nullptr }, | |
120 | { "loglevel-only", 0, POPT_ARG_STRING, nullptr, OPT_LOGLEVEL_ONLY, nullptr, nullptr }, | |
121 | { "list-options", 0, POPT_ARG_NONE, nullptr, OPT_LIST_OPTIONS, nullptr, nullptr }, | |
122 | { "filter", 'f', POPT_ARG_STRING, &opt_filter, OPT_FILTER, nullptr, nullptr }, | |
123 | { "exclude", 'x', POPT_ARG_STRING, &opt_exclude, OPT_EXCLUDE, nullptr, nullptr }, | |
124 | { nullptr, 0, 0, nullptr, 0, nullptr, nullptr } | |
f3ed775e DG |
125 | }; |
126 | ||
0d63dd19 | 127 | /* |
6181537c | 128 | * Parse probe options. |
0d63dd19 | 129 | */ |
d512607f | 130 | int parse_probe_opts(struct lttng_event *ev, char *opt) |
0d63dd19 | 131 | { |
49d4e302 JRJ |
132 | int ret = CMD_SUCCESS; |
133 | int match; | |
8ff0bbd0 | 134 | char s_hex[19]; |
28ab034a | 135 | #define S_HEX_LEN_SCANF_IS_A_BROKEN_API "18" /* 18 is (19 - 1) (\0 is extra) */ |
0d63dd19 DG |
136 | char name[LTTNG_SYMBOL_NAME_LEN]; |
137 | ||
cd9adb8b | 138 | if (opt == nullptr) { |
49d4e302 | 139 | ret = CMD_ERROR; |
8f0d098b | 140 | goto end; |
0d63dd19 DG |
141 | } |
142 | ||
143 | /* Check for symbol+offset */ | |
28ab034a JG |
144 | match = sscanf(opt, |
145 | "%" LTTNG_SYMBOL_NAME_LEN_SCANF_IS_A_BROKEN_API | |
146 | "[^'+']+%" S_HEX_LEN_SCANF_IS_A_BROKEN_API "s", | |
147 | name, | |
148 | s_hex); | |
49d4e302 | 149 | if (match == 2) { |
7d29a247 | 150 | strncpy(ev->attr.probe.symbol_name, name, LTTNG_SYMBOL_NAME_LEN); |
99497cd0 | 151 | ev->attr.probe.symbol_name[LTTNG_SYMBOL_NAME_LEN - 1] = '\0'; |
cf0e5467 | 152 | DBG("probe symbol %s", ev->attr.probe.symbol_name); |
9d035200 | 153 | if (*s_hex == '\0') { |
8ff0bbd0 | 154 | ERR("Invalid probe offset %s", s_hex); |
49d4e302 | 155 | ret = CMD_ERROR; |
8f0d098b | 156 | goto end; |
0d63dd19 | 157 | } |
cd9adb8b | 158 | ev->attr.probe.offset = strtoull(s_hex, nullptr, 0); |
cf0e5467 | 159 | DBG("probe offset %" PRIu64, ev->attr.probe.offset); |
3000dc78 | 160 | ev->attr.probe.addr = 0; |
8f0d098b MD |
161 | goto end; |
162 | } | |
163 | ||
164 | /* Check for symbol */ | |
88c91427 | 165 | if (isalpha(name[0]) || name[0] == '_') { |
28ab034a | 166 | match = sscanf(opt, "%" LTTNG_SYMBOL_NAME_LEN_SCANF_IS_A_BROKEN_API "s", name); |
49d4e302 | 167 | if (match == 1) { |
8f0d098b | 168 | strncpy(ev->attr.probe.symbol_name, name, LTTNG_SYMBOL_NAME_LEN); |
99497cd0 | 169 | ev->attr.probe.symbol_name[LTTNG_SYMBOL_NAME_LEN - 1] = '\0'; |
8f0d098b MD |
170 | DBG("probe symbol %s", ev->attr.probe.symbol_name); |
171 | ev->attr.probe.offset = 0; | |
172 | DBG("probe offset %" PRIu64, ev->attr.probe.offset); | |
173 | ev->attr.probe.addr = 0; | |
174 | goto end; | |
175 | } | |
0d63dd19 DG |
176 | } |
177 | ||
178 | /* Check for address */ | |
49d4e302 JRJ |
179 | match = sscanf(opt, "%" S_HEX_LEN_SCANF_IS_A_BROKEN_API "s", s_hex); |
180 | if (match > 0) { | |
531be721 FD |
181 | /* |
182 | * Return an error if the first character of the tentative | |
183 | * address is NULL or not a digit. It can be "0" if the address | |
184 | * is in hexadecimal and can be 1 to 9 if it's in decimal. | |
185 | */ | |
186 | if (*s_hex == '\0' || !isdigit(*s_hex)) { | |
187 | ERR("Invalid probe description %s", s_hex); | |
49d4e302 | 188 | ret = CMD_ERROR; |
8f0d098b | 189 | goto end; |
0d63dd19 | 190 | } |
cd9adb8b | 191 | ev->attr.probe.addr = strtoull(s_hex, nullptr, 0); |
cf0e5467 | 192 | DBG("probe addr %" PRIu64, ev->attr.probe.addr); |
3000dc78 DG |
193 | ev->attr.probe.offset = 0; |
194 | memset(ev->attr.probe.symbol_name, 0, LTTNG_SYMBOL_NAME_LEN); | |
8f0d098b | 195 | goto end; |
0d63dd19 DG |
196 | } |
197 | ||
198 | /* No match */ | |
49d4e302 | 199 | ret = CMD_ERROR; |
0d63dd19 | 200 | |
8f0d098b | 201 | end: |
0d63dd19 DG |
202 | return ret; |
203 | } | |
204 | ||
d512607f | 205 | const char *print_channel_name(const char *name) |
85076754 | 206 | { |
28ab034a | 207 | return name ?: DEFAULT_CHANNEL_NAME; |
85076754 MD |
208 | } |
209 | ||
d512607f | 210 | const char *print_raw_channel_name(const char *name) |
85076754 | 211 | { |
28ab034a | 212 | return name ?: "<default>"; |
85076754 MD |
213 | } |
214 | ||
89476427 JRJ |
215 | /* |
216 | * Mi print exlcusion list | |
217 | */ | |
d512607f | 218 | int mi_print_exclusion(const struct lttng_dynamic_pointer_array *exclusions) |
89476427 | 219 | { |
e358ddd5 JG |
220 | int ret; |
221 | size_t i; | |
222 | const size_t count = lttng_dynamic_pointer_array_get_count(exclusions); | |
89476427 | 223 | |
a0377dfe | 224 | LTTNG_ASSERT(writer); |
89476427 JRJ |
225 | |
226 | if (count == 0) { | |
227 | ret = 0; | |
228 | goto end; | |
229 | } | |
e358ddd5 | 230 | |
8884bbc1 | 231 | ret = mi_lttng_writer_open_element(writer.get(), config_element_exclusions); |
89476427 JRJ |
232 | if (ret) { |
233 | goto end; | |
234 | } | |
235 | ||
236 | for (i = 0; i < count; i++) { | |
28ab034a JG |
237 | const char *exclusion = |
238 | (const char *) lttng_dynamic_pointer_array_get_pointer(exclusions, i); | |
e358ddd5 | 239 | |
28ab034a | 240 | ret = mi_lttng_writer_write_element_string( |
8884bbc1 | 241 | writer.get(), config_element_exclusion, exclusion); |
89476427 JRJ |
242 | if (ret) { |
243 | goto end; | |
244 | } | |
245 | } | |
246 | ||
247 | /* Close exclusions element */ | |
8884bbc1 | 248 | ret = mi_lttng_writer_close_element(writer.get()); |
89476427 JRJ |
249 | |
250 | end: | |
251 | return ret; | |
252 | } | |
253 | ||
9c48cab3 JI |
254 | /* |
255 | * Return allocated string for pretty-printing exclusion names. | |
256 | */ | |
d512607f | 257 | char *print_exclusions(const struct lttng_dynamic_pointer_array *exclusions) |
9c48cab3 JI |
258 | { |
259 | int length = 0; | |
e358ddd5 | 260 | size_t i; |
bfe36393 | 261 | const char preamble[] = " excluding "; |
9c48cab3 | 262 | char *ret; |
e358ddd5 | 263 | const size_t count = lttng_dynamic_pointer_array_get_count(exclusions); |
9c48cab3 JI |
264 | |
265 | if (count == 0) { | |
266 | return strdup(""); | |
267 | } | |
268 | ||
e358ddd5 | 269 | /* Calculate total required length. */ |
9c48cab3 | 270 | for (i = 0; i < count; i++) { |
28ab034a JG |
271 | const char *exclusion = |
272 | (const char *) lttng_dynamic_pointer_array_get_pointer(exclusions, i); | |
e358ddd5 JG |
273 | |
274 | length += strlen(exclusion) + 4; | |
9c48cab3 JI |
275 | } |
276 | ||
bfe36393 | 277 | length += sizeof(preamble); |
64803277 | 278 | ret = calloc<char>(length); |
fd591b18 | 279 | if (!ret) { |
cd9adb8b | 280 | return nullptr; |
fd591b18 | 281 | } |
e358ddd5 | 282 | |
9c48cab3 JI |
283 | strncpy(ret, preamble, length); |
284 | for (i = 0; i < count; i++) { | |
28ab034a JG |
285 | const char *exclusion = |
286 | (const char *) lttng_dynamic_pointer_array_get_pointer(exclusions, i); | |
e358ddd5 | 287 | |
9f449915 | 288 | strcat(ret, "\""); |
e358ddd5 | 289 | strcat(ret, exclusion); |
9f449915 | 290 | strcat(ret, "\""); |
9c48cab3 | 291 | if (i != count - 1) { |
9f449915 | 292 | strcat(ret, ", "); |
9c48cab3 JI |
293 | } |
294 | } | |
89476427 | 295 | |
9c48cab3 JI |
296 | return ret; |
297 | } | |
298 | ||
bf1413aa | 299 | int check_exclusion_subsets(const char *pattern, const char *exclusion) |
748bde76 | 300 | { |
9f449915 PP |
301 | bool warn = false; |
302 | int ret = 0; | |
bf1413aa | 303 | const char *e = pattern; |
9f449915 PP |
304 | const char *x = exclusion; |
305 | ||
306 | /* Scan both the excluder and the event letter by letter */ | |
307 | while (true) { | |
308 | if (*e == '\\') { | |
309 | if (*x != *e) { | |
310 | warn = true; | |
311 | goto end; | |
312 | } | |
748bde76 | 313 | |
9f449915 PP |
314 | e++; |
315 | x++; | |
316 | goto cmp_chars; | |
317 | } | |
318 | ||
319 | if (*x == '*') { | |
320 | /* Event is a subset of the excluder */ | |
bf1413aa | 321 | ERR("Event %s: %s excludes all events from %s", pattern, exclusion, pattern); |
9f449915 PP |
322 | goto error; |
323 | } | |
324 | ||
325 | if (*e == '*') { | |
326 | /* | |
327 | * Reached the end of the event name before the | |
328 | * end of the exclusion: this is valid. | |
329 | */ | |
330 | goto end; | |
331 | } | |
332 | ||
28ab034a | 333 | cmp_chars: |
9f449915 PP |
334 | if (*x != *e) { |
335 | warn = true; | |
336 | break; | |
337 | } | |
338 | ||
339 | x++; | |
340 | e++; | |
748bde76 JI |
341 | } |
342 | ||
9f449915 | 343 | goto end; |
748bde76 | 344 | |
9f449915 PP |
345 | error: |
346 | ret = -1; | |
748bde76 | 347 | |
9f449915 PP |
348 | end: |
349 | if (warn) { | |
350 | WARN("Event %s: %s does not exclude any events from %s", | |
bf1413aa | 351 | pattern, |
28ab034a | 352 | exclusion, |
bf1413aa | 353 | pattern); |
9f449915 | 354 | } |
748bde76 | 355 | |
9f449915 PP |
356 | return ret; |
357 | } | |
358 | ||
bf1413aa | 359 | int create_exclusion_list_and_validate(const char *pattern, |
d512607f JG |
360 | const char *exclusions_arg, |
361 | struct lttng_dynamic_pointer_array *exclusions) | |
b03a81fb SM |
362 | { |
363 | int ret = 0; | |
b03a81fb SM |
364 | |
365 | /* Split exclusions. */ | |
e358ddd5 JG |
366 | ret = strutils_split(exclusions_arg, ',', true, exclusions); |
367 | if (ret < 0) { | |
b03a81fb SM |
368 | goto error; |
369 | } | |
370 | ||
bf1413aa | 371 | if (validate_exclusion_list(pattern, exclusions) != 0) { |
b03a81fb SM |
372 | goto error; |
373 | } | |
374 | ||
748bde76 | 375 | goto end; |
9f449915 | 376 | |
748bde76 | 377 | error: |
9f449915 | 378 | ret = -1; |
e358ddd5 | 379 | lttng_dynamic_pointer_array_reset(exclusions); |
9f449915 | 380 | |
748bde76 | 381 | end: |
748bde76 JI |
382 | return ret; |
383 | } | |
502bbe89 | 384 | |
d512607f JG |
385 | void warn_on_truncated_exclusion_names(const struct lttng_dynamic_pointer_array *exclusions, |
386 | int *warn) | |
502bbe89 | 387 | { |
e358ddd5 JG |
388 | size_t i; |
389 | const size_t num_exclusions = lttng_dynamic_pointer_array_get_count(exclusions); | |
390 | ||
391 | for (i = 0; i < num_exclusions; i++) { | |
28ab034a JG |
392 | const char *const exclusion = |
393 | (const char *) lttng_dynamic_pointer_array_get_pointer(exclusions, i); | |
502bbe89 | 394 | |
e358ddd5 | 395 | if (strlen(exclusion) >= LTTNG_SYMBOL_NAME_LEN) { |
28ab034a | 396 | WARN("Event exclusion \"%s\" will be truncated", exclusion); |
502bbe89 PP |
397 | *warn = 1; |
398 | } | |
399 | } | |
400 | } | |
401 | ||
f3ed775e | 402 | /* |
6181537c | 403 | * Enabling event using the lttng API. |
89476427 | 404 | * Note: in case of error only the last error code will be return. |
f3ed775e | 405 | */ |
bf1413aa | 406 | int enable_events(const std::string& session_name, const event_rule_patterns& patterns) |
f3ed775e | 407 | { |
89476427 JRJ |
408 | int ret = CMD_SUCCESS, command_ret = CMD_SUCCESS; |
409 | int error_holder = CMD_SUCCESS, warn = 0, error = 0, success = 1; | |
bf1413aa | 410 | char *channel_name = nullptr; |
91744e14 | 411 | struct lttng_event *ev; |
e358ddd5 JG |
412 | struct lttng_domain dom = {}; |
413 | struct lttng_dynamic_pointer_array exclusions; | |
cd9adb8b | 414 | struct lttng_userspace_probe_location *uprobe_loc = nullptr; |
f3ed775e | 415 | |
cd9adb8b | 416 | lttng_dynamic_pointer_array_init(&exclusions, nullptr); |
441c16a7 | 417 | |
91744e14 FD |
418 | ev = lttng_event_create(); |
419 | if (!ev) { | |
420 | ret = CMD_ERROR; | |
421 | goto error; | |
422 | } | |
423 | ||
53a80697 | 424 | if (opt_kernel) { |
67b58630 JG |
425 | if (opt_loglevel) { |
426 | WARN("Kernel loglevels are not supported."); | |
427 | } | |
53a80697 MD |
428 | } |
429 | ||
7d29a247 DG |
430 | /* Create lttng domain */ |
431 | if (opt_kernel) { | |
432 | dom.type = LTTNG_DOMAIN_KERNEL; | |
7972aab2 | 433 | dom.buf_type = LTTNG_BUFFER_GLOBAL; |
d78d6610 | 434 | } else if (opt_userspace) { |
2bdd86d4 | 435 | dom.type = LTTNG_DOMAIN_UST; |
7972aab2 | 436 | /* Default. */ |
8692d4e5 | 437 | dom.buf_type = LTTNG_BUFFER_PER_UID; |
b9dfb167 DG |
438 | } else if (opt_jul) { |
439 | dom.type = LTTNG_DOMAIN_JUL; | |
440 | /* Default. */ | |
441 | dom.buf_type = LTTNG_BUFFER_PER_UID; | |
5cdb6027 DG |
442 | } else if (opt_log4j) { |
443 | dom.type = LTTNG_DOMAIN_LOG4J; | |
444 | /* Default. */ | |
445 | dom.buf_type = LTTNG_BUFFER_PER_UID; | |
0e115563 DG |
446 | } else if (opt_python) { |
447 | dom.type = LTTNG_DOMAIN_PYTHON; | |
448 | /* Default. */ | |
449 | dom.buf_type = LTTNG_BUFFER_PER_UID; | |
6181537c | 450 | } else { |
3ecec76a | 451 | /* Checked by the caller. */ |
a0377dfe | 452 | abort(); |
2bdd86d4 | 453 | } |
7d29a247 | 454 | |
8b08c525 AB |
455 | if (opt_exclude) { |
456 | switch (dom.type) { | |
457 | case LTTNG_DOMAIN_KERNEL: | |
458 | case LTTNG_DOMAIN_JUL: | |
459 | case LTTNG_DOMAIN_LOG4J: | |
460 | case LTTNG_DOMAIN_PYTHON: | |
461 | ERR("Event name exclusions are not yet implemented for %s events", | |
28ab034a | 462 | lttng_domain_type_str(dom.type)); |
8b08c525 AB |
463 | ret = CMD_ERROR; |
464 | goto error; | |
465 | case LTTNG_DOMAIN_UST: | |
466 | /* Exclusions supported */ | |
467 | break; | |
468 | default: | |
a0377dfe | 469 | abort(); |
8b08c525 | 470 | } |
d5dd17fd JI |
471 | } |
472 | ||
4fd2697f FD |
473 | /* |
474 | * Adding a filter to a probe, function or userspace-probe would be | |
475 | * denied by the kernel tracer as it's not supported at the moment. We | |
476 | * do an early check here to warn the user. | |
477 | */ | |
478 | if (opt_filter && opt_kernel) { | |
479 | switch (opt_event_type) { | |
480 | case LTTNG_EVENT_ALL: | |
481 | case LTTNG_EVENT_TRACEPOINT: | |
482 | case LTTNG_EVENT_SYSCALL: | |
483 | break; | |
484 | case LTTNG_EVENT_PROBE: | |
485 | case LTTNG_EVENT_USERSPACE_PROBE: | |
486 | case LTTNG_EVENT_FUNCTION: | |
487 | ERR("Filter expressions are not supported for %s events", | |
28ab034a | 488 | get_event_type_str((lttng_event_type) opt_event_type)); |
4fd2697f FD |
489 | ret = CMD_ERROR; |
490 | goto error; | |
491 | default: | |
492 | ret = CMD_UNDEFINED; | |
493 | goto error; | |
494 | } | |
495 | } | |
496 | ||
85076754 | 497 | channel_name = opt_channel_name; |
ae856491 | 498 | |
bf1413aa | 499 | handle = lttng_create_handle(session_name.c_str(), &dom); |
cd9adb8b | 500 | if (handle == nullptr) { |
cd80958d DG |
501 | ret = -1; |
502 | goto error; | |
503 | } | |
1aef21b6 | 504 | |
89476427 JRJ |
505 | /* Prepare Mi */ |
506 | if (lttng_opt_mi) { | |
507 | /* Open a events element */ | |
8884bbc1 | 508 | ret = mi_lttng_writer_open_element(writer.get(), config_element_events); |
89476427 JRJ |
509 | if (ret) { |
510 | ret = CMD_ERROR; | |
511 | goto error; | |
512 | } | |
513 | } | |
514 | ||
cd80958d | 515 | if (opt_enable_all) { |
8c9ae521 | 516 | /* Default setup for enable all */ |
75e8c5ab | 517 | if (opt_kernel) { |
48a40005 | 518 | ev->type = (lttng_event_type) opt_event_type; |
91744e14 | 519 | strcpy(ev->name, "*"); |
300b8fd5 | 520 | /* kernel loglevels not implemented */ |
91744e14 | 521 | ev->loglevel_type = LTTNG_EVENT_LOGLEVEL_ALL; |
75e8c5ab | 522 | } else { |
91744e14 FD |
523 | ev->type = LTTNG_EVENT_TRACEPOINT; |
524 | strcpy(ev->name, "*"); | |
48a40005 | 525 | ev->loglevel_type = (lttng_loglevel_type) opt_loglevel_type; |
300b8fd5 | 526 | if (opt_loglevel) { |
7e8f2e9c JG |
527 | int name_search_ret; |
528 | ||
a0377dfe | 529 | LTTNG_ASSERT(opt_userspace || opt_jul || opt_log4j || opt_python); |
7e8f2e9c | 530 | |
b2064f54 | 531 | if (opt_userspace) { |
7e8f2e9c JG |
532 | enum lttng_loglevel loglevel; |
533 | ||
28ab034a JG |
534 | name_search_ret = |
535 | loglevel_name_to_value(opt_loglevel, &loglevel); | |
7e8f2e9c | 536 | ev->loglevel = (int) loglevel; |
b2064f54 | 537 | } else if (opt_jul) { |
7e8f2e9c JG |
538 | enum lttng_loglevel_jul loglevel; |
539 | ||
28ab034a JG |
540 | name_search_ret = |
541 | loglevel_jul_name_to_value(opt_loglevel, &loglevel); | |
7e8f2e9c | 542 | ev->loglevel = (int) loglevel; |
5cdb6027 | 543 | } else if (opt_log4j) { |
7e8f2e9c JG |
544 | enum lttng_loglevel_log4j loglevel; |
545 | ||
28ab034a JG |
546 | name_search_ret = loglevel_log4j_name_to_value(opt_loglevel, |
547 | &loglevel); | |
7e8f2e9c | 548 | ev->loglevel = (int) loglevel; |
7fefa907 JG |
549 | } else { |
550 | /* python domain. */ | |
7e8f2e9c JG |
551 | enum lttng_loglevel_python loglevel; |
552 | ||
28ab034a JG |
553 | name_search_ret = loglevel_python_name_to_value( |
554 | opt_loglevel, &loglevel); | |
7e8f2e9c | 555 | ev->loglevel = (int) loglevel; |
b2064f54 | 556 | } |
7e8f2e9c JG |
557 | |
558 | if (name_search_ret == -1) { | |
300b8fd5 | 559 | ERR("Unknown loglevel %s", opt_loglevel); |
2f70b271 | 560 | ret = -LTTNG_ERR_INVALID; |
300b8fd5 MD |
561 | goto error; |
562 | } | |
22e25b71 | 563 | } else { |
a0377dfe | 564 | LTTNG_ASSERT(opt_userspace || opt_jul || opt_log4j || opt_python); |
b2064f54 | 565 | if (opt_userspace) { |
91744e14 | 566 | ev->loglevel = -1; |
34aa3685 | 567 | } else if (opt_jul) { |
91744e14 | 568 | ev->loglevel = LTTNG_LOGLEVEL_JUL_ALL; |
34aa3685 | 569 | } else if (opt_log4j) { |
91744e14 | 570 | ev->loglevel = LTTNG_LOGLEVEL_LOG4J_ALL; |
0e115563 | 571 | } else if (opt_python) { |
91744e14 | 572 | ev->loglevel = LTTNG_LOGLEVEL_PYTHON_DEBUG; |
b2064f54 | 573 | } |
300b8fd5 | 574 | } |
75e8c5ab | 575 | } |
8c9ae521 | 576 | |
7ed70bc9 | 577 | if (opt_exclude) { |
28ab034a | 578 | ret = create_exclusion_list_and_validate("*", opt_exclude, &exclusions); |
9f449915 PP |
579 | if (ret) { |
580 | ret = CMD_ERROR; | |
7ed70bc9 JI |
581 | goto error; |
582 | } | |
502bbe89 | 583 | |
91744e14 | 584 | ev->exclusion = 1; |
28ab034a | 585 | warn_on_truncated_exclusion_names(&exclusions, &warn); |
7ed70bc9 | 586 | } |
025faf73 | 587 | if (!opt_filter) { |
28ab034a JG |
588 | ret = lttng_enable_event_with_exclusions( |
589 | handle, | |
590 | ev, | |
591 | channel_name, | |
cd9adb8b | 592 | nullptr, |
28ab034a JG |
593 | lttng_dynamic_pointer_array_get_count(&exclusions), |
594 | (char **) exclusions.array.buffer.data); | |
025faf73 DG |
595 | if (ret < 0) { |
596 | switch (-ret) { | |
597 | case LTTNG_ERR_KERN_EVENT_EXIST: | |
598 | WARN("Kernel events already enabled (channel %s, session %s)", | |
28ab034a | 599 | print_channel_name(channel_name), |
bf1413aa | 600 | session_name.c_str()); |
89476427 | 601 | warn = 1; |
025faf73 | 602 | break; |
45d5d421 CB |
603 | case LTTNG_ERR_TRACE_ALREADY_STARTED: |
604 | { | |
28ab034a JG |
605 | const char *msg = |
606 | "The command tried to enable an event in a new domain for a session that has already been started once."; | |
45d5d421 | 607 | ERR("Events: %s (channel %s, session %s)", |
28ab034a JG |
608 | msg, |
609 | print_channel_name(channel_name), | |
bf1413aa | 610 | session_name.c_str()); |
45d5d421 CB |
611 | error = 1; |
612 | break; | |
613 | } | |
025faf73 DG |
614 | default: |
615 | ERR("Events: %s (channel %s, session %s)", | |
28ab034a JG |
616 | lttng_strerror(ret), |
617 | ret == -LTTNG_ERR_NEED_CHANNEL_NAME ? | |
618 | print_raw_channel_name(channel_name) : | |
619 | print_channel_name(channel_name), | |
bf1413aa | 620 | session_name.c_str()); |
89476427 | 621 | error = 1; |
025faf73 DG |
622 | break; |
623 | } | |
624 | goto end; | |
42224349 | 625 | } |
8c9ae521 | 626 | |
025faf73 DG |
627 | switch (opt_event_type) { |
628 | case LTTNG_EVENT_TRACEPOINT: | |
67b58630 | 629 | if (opt_loglevel && dom.type != LTTNG_DOMAIN_KERNEL) { |
e358ddd5 | 630 | char *exclusion_string = print_exclusions(&exclusions); |
5ef79758 MD |
631 | |
632 | if (!exclusion_string) { | |
633 | PERROR("Cannot allocate exclusion_string"); | |
634 | error = 1; | |
635 | goto end; | |
636 | } | |
9c48cab3 | 637 | MSG("All %s tracepoints%s are enabled in channel %s for loglevel %s", |
28ab034a JG |
638 | lttng_domain_type_str(dom.type), |
639 | exclusion_string, | |
640 | print_channel_name(channel_name), | |
641 | opt_loglevel); | |
9c48cab3 | 642 | free(exclusion_string); |
025faf73 | 643 | } else { |
e358ddd5 | 644 | char *exclusion_string = print_exclusions(&exclusions); |
5ef79758 MD |
645 | |
646 | if (!exclusion_string) { | |
647 | PERROR("Cannot allocate exclusion_string"); | |
648 | error = 1; | |
649 | goto end; | |
650 | } | |
9c48cab3 | 651 | MSG("All %s tracepoints%s are enabled in channel %s", |
28ab034a JG |
652 | lttng_domain_type_str(dom.type), |
653 | exclusion_string, | |
654 | print_channel_name(channel_name)); | |
9c48cab3 | 655 | free(exclusion_string); |
025faf73 DG |
656 | } |
657 | break; | |
658 | case LTTNG_EVENT_SYSCALL: | |
659 | if (opt_kernel) { | |
6e911cad | 660 | MSG("All %s system calls are enabled in channel %s", |
28ab034a JG |
661 | lttng_domain_type_str(dom.type), |
662 | print_channel_name(channel_name)); | |
025faf73 DG |
663 | } |
664 | break; | |
665 | case LTTNG_EVENT_ALL: | |
67b58630 | 666 | if (opt_loglevel && dom.type != LTTNG_DOMAIN_KERNEL) { |
e358ddd5 | 667 | char *exclusion_string = print_exclusions(&exclusions); |
5ef79758 MD |
668 | |
669 | if (!exclusion_string) { | |
670 | PERROR("Cannot allocate exclusion_string"); | |
671 | error = 1; | |
672 | goto end; | |
673 | } | |
9c48cab3 | 674 | MSG("All %s events%s are enabled in channel %s for loglevel %s", |
28ab034a JG |
675 | lttng_domain_type_str(dom.type), |
676 | exclusion_string, | |
677 | print_channel_name(channel_name), | |
678 | opt_loglevel); | |
9c48cab3 | 679 | free(exclusion_string); |
025faf73 | 680 | } else { |
e358ddd5 | 681 | char *exclusion_string = print_exclusions(&exclusions); |
5ef79758 MD |
682 | |
683 | if (!exclusion_string) { | |
684 | PERROR("Cannot allocate exclusion_string"); | |
685 | error = 1; | |
686 | goto end; | |
687 | } | |
9c48cab3 | 688 | MSG("All %s events%s are enabled in channel %s", |
28ab034a JG |
689 | lttng_domain_type_str(dom.type), |
690 | exclusion_string, | |
691 | print_channel_name(channel_name)); | |
9c48cab3 | 692 | free(exclusion_string); |
025faf73 DG |
693 | } |
694 | break; | |
695 | default: | |
696 | /* | |
697 | * We should not be here since lttng_enable_event should have | |
698 | * failed on the event type. | |
699 | */ | |
700 | goto error; | |
57064ada | 701 | } |
f3ed775e | 702 | } |
89476427 | 703 | |
025faf73 | 704 | if (opt_filter) { |
28ab034a JG |
705 | command_ret = lttng_enable_event_with_exclusions( |
706 | handle, | |
707 | ev, | |
708 | channel_name, | |
709 | opt_filter, | |
710 | lttng_dynamic_pointer_array_get_count(&exclusions), | |
711 | (char **) exclusions.array.buffer.data); | |
89476427 JRJ |
712 | if (command_ret < 0) { |
713 | switch (-command_ret) { | |
16363652 | 714 | case LTTNG_ERR_FILTER_EXIST: |
85076754 | 715 | WARN("Filter on all events is already enabled" |
28ab034a JG |
716 | " (channel %s, session %s)", |
717 | print_channel_name(channel_name), | |
bf1413aa | 718 | session_name.c_str()); |
89476427 | 719 | warn = 1; |
16363652 | 720 | break; |
45d5d421 CB |
721 | case LTTNG_ERR_TRACE_ALREADY_STARTED: |
722 | { | |
28ab034a JG |
723 | const char *msg = |
724 | "The command tried to enable an event in a new domain for a session that has already been started once."; | |
45d5d421 | 725 | ERR("All events: %s (channel %s, session %s, filter \'%s\')", |
28ab034a JG |
726 | msg, |
727 | print_channel_name(channel_name), | |
bf1413aa | 728 | session_name.c_str(), |
28ab034a | 729 | opt_filter); |
45d5d421 CB |
730 | error = 1; |
731 | break; | |
732 | } | |
16363652 | 733 | default: |
85076754 | 734 | ERR("All events: %s (channel %s, session %s, filter \'%s\')", |
28ab034a JG |
735 | lttng_strerror(command_ret), |
736 | command_ret == -LTTNG_ERR_NEED_CHANNEL_NAME ? | |
737 | print_raw_channel_name(channel_name) : | |
738 | print_channel_name(channel_name), | |
bf1413aa | 739 | session_name.c_str(), |
28ab034a | 740 | opt_filter); |
89476427 | 741 | error = 1; |
16363652 DG |
742 | break; |
743 | } | |
89476427 | 744 | error_holder = command_ret; |
16363652 | 745 | } else { |
91744e14 | 746 | ev->filter = 1; |
16363652 DG |
747 | MSG("Filter '%s' successfully set", opt_filter); |
748 | } | |
749 | } | |
89476427 JRJ |
750 | |
751 | if (lttng_opt_mi) { | |
752 | /* The wildcard * is used for kernel and ust domain to | |
753 | * represent ALL. We copy * in event name to force the wildcard use | |
754 | * for kernel domain | |
755 | * | |
756 | * Note: this is strictly for semantic and printing while in | |
757 | * machine interface mode. | |
758 | */ | |
91744e14 | 759 | strcpy(ev->name, "*"); |
89476427 JRJ |
760 | |
761 | /* If we reach here the events are enabled */ | |
762 | if (!error && !warn) { | |
91744e14 | 763 | ev->enabled = 1; |
89476427 | 764 | } else { |
91744e14 | 765 | ev->enabled = 0; |
89476427 JRJ |
766 | success = 0; |
767 | } | |
8884bbc1 | 768 | ret = mi_lttng_event(writer.get(), ev, 1, handle->domain.type); |
89476427 JRJ |
769 | if (ret) { |
770 | ret = CMD_ERROR; | |
771 | goto error; | |
772 | } | |
773 | ||
774 | /* print exclusion */ | |
e358ddd5 | 775 | ret = mi_print_exclusion(&exclusions); |
89476427 JRJ |
776 | if (ret) { |
777 | ret = CMD_ERROR; | |
778 | goto error; | |
779 | } | |
780 | ||
781 | /* Success ? */ | |
28ab034a | 782 | ret = mi_lttng_writer_write_element_bool( |
8884bbc1 | 783 | writer.get(), mi_lttng_element_command_success, success); |
89476427 JRJ |
784 | if (ret) { |
785 | ret = CMD_ERROR; | |
786 | goto error; | |
787 | } | |
788 | ||
789 | /* Close event element */ | |
8884bbc1 | 790 | ret = mi_lttng_writer_close_element(writer.get()); |
89476427 JRJ |
791 | if (ret) { |
792 | ret = CMD_ERROR; | |
793 | goto error; | |
794 | } | |
795 | } | |
796 | ||
8c9ae521 | 797 | goto end; |
f3ed775e DG |
798 | } |
799 | ||
800 | /* Strip event list */ | |
bf1413aa | 801 | for (const auto& pattern : patterns) { |
6181537c | 802 | /* Copy name and type of the event */ |
bf1413aa | 803 | strncpy(ev->name, pattern.c_str(), LTTNG_SYMBOL_NAME_LEN); |
91744e14 | 804 | ev->name[LTTNG_SYMBOL_NAME_LEN - 1] = '\0'; |
48a40005 | 805 | ev->type = (lttng_event_type) opt_event_type; |
6181537c | 806 | |
f3ed775e DG |
807 | /* Kernel tracer action */ |
808 | if (opt_kernel) { | |
bf1413aa JG |
809 | DBG_FMT("Enabling kernel event: pattern=`{}`, channel_name=`{}`", |
810 | pattern, | |
811 | print_channel_name(channel_name)); | |
f3ed775e DG |
812 | |
813 | switch (opt_event_type) { | |
28ab034a | 814 | case LTTNG_EVENT_ALL: /* Enable tracepoints and syscalls */ |
29c62722 | 815 | /* If event name differs from *, select tracepoint. */ |
5c7248cd | 816 | if (strcmp(ev->name, "*") != 0) { |
91744e14 | 817 | ev->type = LTTNG_EVENT_TRACEPOINT; |
29c62722 MD |
818 | } |
819 | break; | |
e6ddca71 | 820 | case LTTNG_EVENT_TRACEPOINT: |
f3ed775e | 821 | break; |
7d29a247 | 822 | case LTTNG_EVENT_PROBE: |
91744e14 | 823 | ret = parse_probe_opts(ev, opt_probe); |
49d4e302 | 824 | if (ret) { |
cf0e5467 | 825 | ERR("Unable to parse probe options"); |
91744e14 | 826 | ret = CMD_ERROR; |
0d63dd19 DG |
827 | goto error; |
828 | } | |
f3ed775e | 829 | break; |
dcabc190 | 830 | case LTTNG_EVENT_USERSPACE_PROBE: |
a0377dfe | 831 | LTTNG_ASSERT(ev->type == LTTNG_EVENT_USERSPACE_PROBE); |
0c4e727b JR |
832 | |
833 | ret = parse_userspace_probe_opts(opt_userspace_probe, &uprobe_loc); | |
dcabc190 | 834 | if (ret) { |
36aa2f64 FD |
835 | switch (ret) { |
836 | case CMD_UNSUPPORTED: | |
837 | /* | |
838 | * Error message describing | |
839 | * what is not supported was | |
840 | * printed in the function. | |
841 | */ | |
842 | break; | |
843 | case CMD_ERROR: | |
844 | default: | |
845 | ERR("Unable to parse userspace probe options"); | |
846 | break; | |
847 | } | |
dcabc190 FD |
848 | goto error; |
849 | } | |
0c4e727b JR |
850 | |
851 | ret = lttng_event_set_userspace_probe_location(ev, uprobe_loc); | |
852 | if (ret) { | |
853 | WARN("Failed to set probe location on event"); | |
854 | ret = CMD_ERROR; | |
855 | goto error; | |
856 | } | |
857 | ||
858 | /* Ownership of the uprobe location was transferred to the event. */ | |
cd9adb8b | 859 | uprobe_loc = nullptr; |
dcabc190 | 860 | break; |
f3ed775e | 861 | case LTTNG_EVENT_FUNCTION: |
91744e14 | 862 | ret = parse_probe_opts(ev, opt_function); |
49d4e302 | 863 | if (ret) { |
8f0d098b | 864 | ERR("Unable to parse function probe options"); |
91744e14 | 865 | ret = CMD_ERROR; |
8f0d098b MD |
866 | goto error; |
867 | } | |
868 | break; | |
a54bd42d | 869 | case LTTNG_EVENT_SYSCALL: |
91744e14 | 870 | ev->type = LTTNG_EVENT_SYSCALL; |
c6aa2d41 | 871 | break; |
f3ed775e | 872 | default: |
1ab1ea0b | 873 | ret = CMD_UNDEFINED; |
f3ed775e DG |
874 | goto error; |
875 | } | |
0cda4f28 | 876 | |
0cda4f28 | 877 | /* kernel loglevels not implemented */ |
91744e14 | 878 | ev->loglevel_type = LTTNG_EVENT_LOGLEVEL_ALL; |
28ab034a JG |
879 | } else if (opt_userspace) { /* User-space tracer action */ |
880 | DBG("Enabling UST event %s for channel %s, loglevel %s", | |
bf1413aa | 881 | pattern.c_str(), |
28ab034a JG |
882 | print_channel_name(channel_name), |
883 | opt_loglevel ?: "<all>"); | |
2bdd86d4 MD |
884 | |
885 | switch (opt_event_type) { | |
28ab034a | 886 | case LTTNG_EVENT_ALL: /* Default behavior is tracepoint */ |
2bdd86d4 MD |
887 | /* Fall-through */ |
888 | case LTTNG_EVENT_TRACEPOINT: | |
e4baff1e | 889 | /* Copy name and type of the event */ |
91744e14 | 890 | ev->type = LTTNG_EVENT_TRACEPOINT; |
bf1413aa | 891 | strncpy(ev->name, pattern.c_str(), LTTNG_SYMBOL_NAME_LEN); |
91744e14 | 892 | ev->name[LTTNG_SYMBOL_NAME_LEN - 1] = '\0'; |
2bdd86d4 MD |
893 | break; |
894 | case LTTNG_EVENT_PROBE: | |
895 | case LTTNG_EVENT_FUNCTION: | |
2bdd86d4 | 896 | case LTTNG_EVENT_SYSCALL: |
dcabc190 | 897 | case LTTNG_EVENT_USERSPACE_PROBE: |
2bdd86d4 | 898 | default: |
cc62c0c0 | 899 | ERR("Event type not available for user-space tracing"); |
4ce78777 | 900 | ret = CMD_UNSUPPORTED; |
2bdd86d4 MD |
901 | goto error; |
902 | } | |
0cda4f28 | 903 | |
7ed70bc9 | 904 | if (opt_exclude) { |
91744e14 | 905 | ev->exclusion = 1; |
28ab034a JG |
906 | if (opt_event_type != LTTNG_EVENT_ALL && |
907 | opt_event_type != LTTNG_EVENT_TRACEPOINT) { | |
d5dd17fd JI |
908 | ERR("Exclusion option can only be used with tracepoint events"); |
909 | ret = CMD_ERROR; | |
910 | goto error; | |
911 | } | |
e358ddd5 JG |
912 | /* Free previously allocated items. */ |
913 | lttng_dynamic_pointer_array_reset(&exclusions); | |
9f449915 | 914 | ret = create_exclusion_list_and_validate( |
bf1413aa | 915 | pattern.c_str(), opt_exclude, &exclusions); |
9f449915 PP |
916 | if (ret) { |
917 | ret = CMD_ERROR; | |
7ed70bc9 JI |
918 | goto error; |
919 | } | |
502bbe89 | 920 | |
28ab034a | 921 | warn_on_truncated_exclusion_names(&exclusions, &warn); |
7ed70bc9 JI |
922 | } |
923 | ||
48a40005 | 924 | ev->loglevel_type = (lttng_loglevel_type) opt_loglevel_type; |
ed7f4083 | 925 | if (opt_loglevel) { |
7e8f2e9c | 926 | enum lttng_loglevel loglevel; |
28ab034a JG |
927 | const int name_search_ret = |
928 | loglevel_name_to_value(opt_loglevel, &loglevel); | |
7e8f2e9c JG |
929 | |
930 | if (name_search_ret == -1) { | |
8005f29a | 931 | ERR("Unknown loglevel %s", opt_loglevel); |
2f70b271 | 932 | ret = -LTTNG_ERR_INVALID; |
8005f29a MD |
933 | goto error; |
934 | } | |
7e8f2e9c JG |
935 | |
936 | ev->loglevel = (int) loglevel; | |
22e25b71 | 937 | } else { |
91744e14 | 938 | ev->loglevel = -1; |
ed7f4083 | 939 | } |
0e115563 | 940 | } else if (opt_jul || opt_log4j || opt_python) { |
b9dfb167 | 941 | if (opt_event_type != LTTNG_EVENT_ALL && |
28ab034a | 942 | opt_event_type != LTTNG_EVENT_TRACEPOINT) { |
5cdb6027 | 943 | ERR("Event type not supported for domain."); |
b9dfb167 DG |
944 | ret = CMD_UNSUPPORTED; |
945 | goto error; | |
946 | } | |
b2064f54 | 947 | |
48a40005 | 948 | ev->loglevel_type = (lttng_loglevel_type) opt_loglevel_type; |
b2064f54 | 949 | if (opt_loglevel) { |
7e8f2e9c JG |
950 | int name_search_ret; |
951 | ||
5cdb6027 | 952 | if (opt_jul) { |
7e8f2e9c JG |
953 | enum lttng_loglevel_jul loglevel; |
954 | ||
28ab034a JG |
955 | name_search_ret = |
956 | loglevel_jul_name_to_value(opt_loglevel, &loglevel); | |
7e8f2e9c | 957 | ev->loglevel = (int) loglevel; |
5cdb6027 | 958 | } else if (opt_log4j) { |
7e8f2e9c JG |
959 | enum lttng_loglevel_log4j loglevel; |
960 | ||
28ab034a JG |
961 | name_search_ret = loglevel_log4j_name_to_value(opt_loglevel, |
962 | &loglevel); | |
7e8f2e9c | 963 | ev->loglevel = (int) loglevel; |
7fefa907 JG |
964 | } else { |
965 | /* python domain. */ | |
7e8f2e9c JG |
966 | enum lttng_loglevel_python loglevel; |
967 | ||
28ab034a JG |
968 | name_search_ret = loglevel_python_name_to_value( |
969 | opt_loglevel, &loglevel); | |
7e8f2e9c | 970 | ev->loglevel = (int) loglevel; |
5cdb6027 | 971 | } |
7e8f2e9c JG |
972 | |
973 | if (name_search_ret) { | |
b2064f54 DG |
974 | ERR("Unknown loglevel %s", opt_loglevel); |
975 | ret = -LTTNG_ERR_INVALID; | |
976 | goto error; | |
977 | } | |
978 | } else { | |
5cdb6027 | 979 | if (opt_jul) { |
91744e14 | 980 | ev->loglevel = LTTNG_LOGLEVEL_JUL_ALL; |
5cdb6027 | 981 | } else if (opt_log4j) { |
91744e14 | 982 | ev->loglevel = LTTNG_LOGLEVEL_LOG4J_ALL; |
0e115563 | 983 | } else if (opt_python) { |
91744e14 | 984 | ev->loglevel = LTTNG_LOGLEVEL_PYTHON_DEBUG; |
5cdb6027 | 985 | } |
b2064f54 | 986 | } |
91744e14 | 987 | ev->type = LTTNG_EVENT_TRACEPOINT; |
bf1413aa | 988 | strncpy(ev->name, pattern.c_str(), LTTNG_SYMBOL_NAME_LEN); |
91744e14 | 989 | ev->name[LTTNG_SYMBOL_NAME_LEN - 1] = '\0'; |
f3ed775e | 990 | } else { |
a0377dfe | 991 | abort(); |
f3ed775e DG |
992 | } |
993 | ||
025faf73 | 994 | if (!opt_filter) { |
9c48cab3 JI |
995 | char *exclusion_string; |
996 | ||
28ab034a JG |
997 | command_ret = lttng_enable_event_with_exclusions( |
998 | handle, | |
999 | ev, | |
1000 | channel_name, | |
cd9adb8b | 1001 | nullptr, |
28ab034a JG |
1002 | lttng_dynamic_pointer_array_get_count(&exclusions), |
1003 | (char **) exclusions.array.buffer.data); | |
e358ddd5 | 1004 | exclusion_string = print_exclusions(&exclusions); |
5ef79758 MD |
1005 | if (!exclusion_string) { |
1006 | PERROR("Cannot allocate exclusion_string"); | |
1007 | error = 1; | |
1008 | goto end; | |
1009 | } | |
89476427 | 1010 | if (command_ret < 0) { |
025faf73 | 1011 | /* Turn ret to positive value to handle the positive error code */ |
89476427 | 1012 | switch (-command_ret) { |
025faf73 | 1013 | case LTTNG_ERR_KERN_EVENT_EXIST: |
9c48cab3 | 1014 | WARN("Kernel event %s%s already enabled (channel %s, session %s)", |
bf1413aa | 1015 | pattern.c_str(), |
28ab034a JG |
1016 | exclusion_string, |
1017 | print_channel_name(channel_name), | |
bf1413aa | 1018 | session_name.c_str()); |
89476427 | 1019 | warn = 1; |
025faf73 | 1020 | break; |
45d5d421 CB |
1021 | case LTTNG_ERR_TRACE_ALREADY_STARTED: |
1022 | { | |
28ab034a JG |
1023 | const char *msg = |
1024 | "The command tried to enable an event in a new domain for a session that has already been started once."; | |
1025 | ERR("Event %s%s: %s (channel %s, session %s)", | |
bf1413aa | 1026 | pattern.c_str(), |
28ab034a JG |
1027 | exclusion_string, |
1028 | msg, | |
1029 | print_channel_name(channel_name), | |
bf1413aa | 1030 | session_name.c_str()); |
45d5d421 CB |
1031 | error = 1; |
1032 | break; | |
1033 | } | |
dcabc190 FD |
1034 | case LTTNG_ERR_SDT_PROBE_SEMAPHORE: |
1035 | ERR("SDT probes %s guarded by semaphores are not supported (channel %s, session %s)", | |
bf1413aa | 1036 | pattern.c_str(), |
28ab034a | 1037 | print_channel_name(channel_name), |
bf1413aa | 1038 | session_name.c_str()); |
dcabc190 FD |
1039 | error = 1; |
1040 | break; | |
025faf73 | 1041 | default: |
28ab034a | 1042 | ERR("Event %s%s: %s (channel %s, session %s)", |
bf1413aa | 1043 | pattern.c_str(), |
28ab034a JG |
1044 | exclusion_string, |
1045 | lttng_strerror(command_ret), | |
1046 | command_ret == -LTTNG_ERR_NEED_CHANNEL_NAME ? | |
1047 | print_raw_channel_name(channel_name) : | |
1048 | print_channel_name(channel_name), | |
bf1413aa | 1049 | session_name.c_str()); |
89476427 | 1050 | error = 1; |
025faf73 DG |
1051 | break; |
1052 | } | |
89476427 | 1053 | error_holder = command_ret; |
025faf73 | 1054 | } else { |
8274eeba AB |
1055 | switch (dom.type) { |
1056 | case LTTNG_DOMAIN_KERNEL: | |
1057 | case LTTNG_DOMAIN_UST: | |
49ceaa70 | 1058 | MSG("%s event %s%s created in channel %s", |
28ab034a | 1059 | lttng_domain_type_str(dom.type), |
bf1413aa | 1060 | pattern.c_str(), |
28ab034a JG |
1061 | exclusion_string, |
1062 | print_channel_name(channel_name)); | |
8274eeba AB |
1063 | break; |
1064 | case LTTNG_DOMAIN_JUL: | |
1065 | case LTTNG_DOMAIN_LOG4J: | |
1066 | case LTTNG_DOMAIN_PYTHON: | |
1067 | /* | |
1068 | * Don't print the default channel | |
1069 | * name for agent domains. | |
1070 | */ | |
895707da | 1071 | MSG("%s event %s%s enabled", |
28ab034a | 1072 | lttng_domain_type_str(dom.type), |
bf1413aa | 1073 | pattern.c_str(), |
28ab034a | 1074 | exclusion_string); |
8274eeba AB |
1075 | break; |
1076 | default: | |
a0377dfe | 1077 | abort(); |
49ceaa70 | 1078 | } |
42224349 | 1079 | } |
9c48cab3 | 1080 | free(exclusion_string); |
6181537c | 1081 | } |
025faf73 DG |
1082 | |
1083 | if (opt_filter) { | |
9c48cab3 JI |
1084 | char *exclusion_string; |
1085 | ||
89476427 | 1086 | /* Filter present */ |
91744e14 | 1087 | ev->filter = 1; |
89476427 | 1088 | |
28ab034a JG |
1089 | command_ret = lttng_enable_event_with_exclusions( |
1090 | handle, | |
1091 | ev, | |
1092 | channel_name, | |
1093 | opt_filter, | |
1094 | lttng_dynamic_pointer_array_get_count(&exclusions), | |
1095 | (char **) exclusions.array.buffer.data); | |
e358ddd5 | 1096 | exclusion_string = print_exclusions(&exclusions); |
5ef79758 MD |
1097 | if (!exclusion_string) { |
1098 | PERROR("Cannot allocate exclusion_string"); | |
1099 | error = 1; | |
1100 | goto end; | |
1101 | } | |
89476427 JRJ |
1102 | if (command_ret < 0) { |
1103 | switch (-command_ret) { | |
7671f53c | 1104 | case LTTNG_ERR_FILTER_EXIST: |
9c48cab3 | 1105 | WARN("Filter on event %s%s is already enabled" |
28ab034a | 1106 | " (channel %s, session %s)", |
bf1413aa | 1107 | pattern.c_str(), |
28ab034a JG |
1108 | exclusion_string, |
1109 | print_channel_name(channel_name), | |
bf1413aa | 1110 | session_name.c_str()); |
89476427 | 1111 | warn = 1; |
7671f53c | 1112 | break; |
45d5d421 CB |
1113 | case LTTNG_ERR_TRACE_ALREADY_STARTED: |
1114 | { | |
28ab034a JG |
1115 | const char *msg = |
1116 | "The command tried to enable an event in a new domain for a session that has already been started once."; | |
1117 | ERR("Event %s%s: %s (channel %s, session %s, filter \'%s\')", | |
1118 | ev->name, | |
1119 | exclusion_string, | |
1120 | msg, | |
1121 | print_channel_name(channel_name), | |
bf1413aa | 1122 | session_name.c_str(), |
28ab034a | 1123 | opt_filter); |
45d5d421 CB |
1124 | error = 1; |
1125 | break; | |
1126 | } | |
7671f53c | 1127 | default: |
28ab034a JG |
1128 | ERR("Event %s%s: %s (channel %s, session %s, filter \'%s\')", |
1129 | ev->name, | |
1130 | exclusion_string, | |
1131 | lttng_strerror(command_ret), | |
1132 | command_ret == -LTTNG_ERR_NEED_CHANNEL_NAME ? | |
1133 | print_raw_channel_name(channel_name) : | |
1134 | print_channel_name(channel_name), | |
bf1413aa | 1135 | session_name.c_str(), |
28ab034a | 1136 | opt_filter); |
89476427 | 1137 | error = 1; |
7671f53c CB |
1138 | break; |
1139 | } | |
89476427 JRJ |
1140 | error_holder = command_ret; |
1141 | ||
16363652 | 1142 | } else { |
9c48cab3 | 1143 | MSG("Event %s%s: Filter '%s' successfully set", |
bf1413aa | 1144 | pattern.c_str(), |
28ab034a JG |
1145 | exclusion_string, |
1146 | opt_filter); | |
53a80697 | 1147 | } |
9c48cab3 | 1148 | free(exclusion_string); |
53a80697 | 1149 | } |
6181537c | 1150 | |
89476427 JRJ |
1151 | if (lttng_opt_mi) { |
1152 | if (command_ret) { | |
1153 | success = 0; | |
91744e14 | 1154 | ev->enabled = 0; |
89476427 | 1155 | } else { |
91744e14 | 1156 | ev->enabled = 1; |
89476427 JRJ |
1157 | } |
1158 | ||
8884bbc1 | 1159 | ret = mi_lttng_event(writer.get(), ev, 1, handle->domain.type); |
89476427 JRJ |
1160 | if (ret) { |
1161 | ret = CMD_ERROR; | |
1162 | goto error; | |
1163 | } | |
1164 | ||
1165 | /* print exclusion */ | |
e358ddd5 | 1166 | ret = mi_print_exclusion(&exclusions); |
89476427 JRJ |
1167 | if (ret) { |
1168 | ret = CMD_ERROR; | |
1169 | goto error; | |
1170 | } | |
1171 | ||
1172 | /* Success ? */ | |
28ab034a | 1173 | ret = mi_lttng_writer_write_element_bool( |
8884bbc1 | 1174 | writer.get(), mi_lttng_element_command_success, success); |
89476427 JRJ |
1175 | if (ret) { |
1176 | ret = CMD_ERROR; | |
1177 | goto end; | |
1178 | } | |
1179 | ||
1180 | /* Close event element */ | |
8884bbc1 | 1181 | ret = mi_lttng_writer_close_element(writer.get()); |
89476427 JRJ |
1182 | if (ret) { |
1183 | ret = CMD_ERROR; | |
1184 | goto end; | |
1185 | } | |
1186 | } | |
1187 | ||
89476427 JRJ |
1188 | /* Reset warn, error and success */ |
1189 | success = 1; | |
f3ed775e DG |
1190 | } |
1191 | ||
8c9ae521 | 1192 | end: |
89476427 JRJ |
1193 | /* Close Mi */ |
1194 | if (lttng_opt_mi) { | |
1195 | /* Close events element */ | |
8884bbc1 | 1196 | ret = mi_lttng_writer_close_element(writer.get()); |
89476427 JRJ |
1197 | if (ret) { |
1198 | ret = CMD_ERROR; | |
1199 | goto error; | |
1200 | } | |
1201 | } | |
f3ed775e | 1202 | error: |
ae856491 DG |
1203 | if (warn) { |
1204 | ret = CMD_WARNING; | |
1205 | } | |
89476427 JRJ |
1206 | if (error) { |
1207 | ret = CMD_ERROR; | |
1208 | } | |
cd80958d | 1209 | lttng_destroy_handle(handle); |
e358ddd5 | 1210 | lttng_dynamic_pointer_array_reset(&exclusions); |
0c4e727b | 1211 | lttng_userspace_probe_location_destroy(uprobe_loc); |
7ed70bc9 | 1212 | |
89476427 JRJ |
1213 | /* Overwrite ret with error_holder if there was an actual error with |
1214 | * enabling an event. | |
1215 | */ | |
1216 | ret = error_holder ? error_holder : ret; | |
1217 | ||
91744e14 | 1218 | lttng_event_destroy(ev); |
f3ed775e DG |
1219 | return ret; |
1220 | } | |
1221 | ||
c926bb36 JG |
1222 | void _poptContextFree_deleter_func(poptContext ctx) |
1223 | { | |
1224 | poptFreeContext(ctx); | |
1225 | } | |
1226 | ||
d512607f JG |
1227 | } /* namespace */ |
1228 | ||
bf1413aa | 1229 | int validate_exclusion_list(const char *pattern, |
d512607f JG |
1230 | const struct lttng_dynamic_pointer_array *exclusions) |
1231 | { | |
1232 | int ret; | |
1233 | ||
1234 | /* Event name must be a valid globbing pattern to allow exclusions. */ | |
bf1413aa JG |
1235 | if (!strutils_is_star_glob_pattern(pattern)) { |
1236 | ERR("Event %s: Exclusions can only be used with a globbing pattern", pattern); | |
d512607f JG |
1237 | goto error; |
1238 | } | |
1239 | ||
1240 | /* | |
1241 | * If the event name is a star-at-end only globbing pattern, | |
1242 | * then we can validate the individual exclusions. Otherwise | |
1243 | * all exclusions are passed to the session daemon. | |
1244 | */ | |
bf1413aa | 1245 | if (strutils_is_star_at_the_end_only_glob_pattern(pattern)) { |
d512607f JG |
1246 | size_t i, num_exclusions; |
1247 | ||
1248 | num_exclusions = lttng_dynamic_pointer_array_get_count(exclusions); | |
1249 | ||
1250 | for (i = 0; i < num_exclusions; i++) { | |
1251 | const char *exclusion = | |
1252 | (const char *) lttng_dynamic_pointer_array_get_pointer(exclusions, | |
1253 | i); | |
1254 | ||
1255 | if (!strutils_is_star_glob_pattern(exclusion) || | |
1256 | strutils_is_star_at_the_end_only_glob_pattern(exclusion)) { | |
bf1413aa | 1257 | ret = check_exclusion_subsets(pattern, exclusion); |
d512607f JG |
1258 | if (ret) { |
1259 | goto error; | |
1260 | } | |
1261 | } | |
1262 | } | |
1263 | } | |
1264 | ||
1265 | ret = 0; | |
1266 | goto end; | |
1267 | ||
1268 | error: | |
1269 | ret = -1; | |
1270 | ||
1271 | end: | |
1272 | return ret; | |
1273 | } | |
1274 | ||
f3ed775e | 1275 | /* |
6181537c | 1276 | * Add event to trace session |
f3ed775e DG |
1277 | */ |
1278 | int cmd_enable_events(int argc, const char **argv) | |
1279 | { | |
89476427 | 1280 | int opt, ret = CMD_SUCCESS, command_ret = CMD_SUCCESS, success = 1; |
bf1413aa | 1281 | std::string session_name; |
cd9adb8b JG |
1282 | const char *arg_event_list = nullptr; |
1283 | const char *leftover = nullptr; | |
de044b7a | 1284 | int event_type = -1; |
bf1413aa JG |
1285 | event_rule_patterns patterns; |
1286 | std::stringstream event_list_arg_stream(arg_event_list); | |
f3ed775e | 1287 | |
c926bb36 JG |
1288 | auto pc = lttng::make_unique_wrapper<poptContext_s, _poptContextFree_deleter_func>( |
1289 | poptGetContext(nullptr, argc, argv, long_options, 0)); | |
1290 | poptReadDefaultConfig(pc.get(), 0); | |
f3ed775e DG |
1291 | |
1292 | /* Default event type */ | |
7a3d1328 | 1293 | opt_event_type = LTTNG_EVENT_ALL; |
f3ed775e | 1294 | |
c926bb36 | 1295 | while ((opt = poptGetNextOpt(pc.get())) != -1) { |
f3ed775e DG |
1296 | switch (opt) { |
1297 | case OPT_HELP: | |
4ba92f18 | 1298 | SHOW_HELP(); |
27b5aa57 | 1299 | return CMD_SUCCESS; |
f3ed775e | 1300 | case OPT_TRACEPOINT: |
e6ddca71 | 1301 | opt_event_type = LTTNG_EVENT_TRACEPOINT; |
f3ed775e | 1302 | break; |
cf0e5467 | 1303 | case OPT_PROBE: |
7d29a247 | 1304 | opt_event_type = LTTNG_EVENT_PROBE; |
f3ed775e | 1305 | break; |
dcabc190 FD |
1306 | case OPT_USERSPACE_PROBE: |
1307 | opt_event_type = LTTNG_EVENT_USERSPACE_PROBE; | |
1308 | break; | |
f3ed775e DG |
1309 | case OPT_FUNCTION: |
1310 | opt_event_type = LTTNG_EVENT_FUNCTION; | |
8f0d098b | 1311 | break; |
a54bd42d MD |
1312 | case OPT_SYSCALL: |
1313 | opt_event_type = LTTNG_EVENT_SYSCALL; | |
0133c199 | 1314 | break; |
eeac7d46 MD |
1315 | case OPT_USERSPACE: |
1316 | opt_userspace = 1; | |
eeac7d46 | 1317 | break; |
0cda4f28 | 1318 | case OPT_LOGLEVEL: |
8005f29a | 1319 | opt_loglevel_type = LTTNG_EVENT_LOGLEVEL_RANGE; |
c926bb36 | 1320 | opt_loglevel = poptGetOptArg(pc.get()); |
0cda4f28 MD |
1321 | break; |
1322 | case OPT_LOGLEVEL_ONLY: | |
8005f29a | 1323 | opt_loglevel_type = LTTNG_EVENT_LOGLEVEL_SINGLE; |
c926bb36 | 1324 | opt_loglevel = poptGetOptArg(pc.get()); |
13dce3b7 | 1325 | break; |
679b4943 SM |
1326 | case OPT_LIST_OPTIONS: |
1327 | list_cmd_options(stdout, long_options); | |
27b5aa57 | 1328 | return CMD_SUCCESS; |
53a80697 MD |
1329 | case OPT_FILTER: |
1330 | break; | |
fac3366c JI |
1331 | case OPT_EXCLUDE: |
1332 | break; | |
f3ed775e | 1333 | default: |
27b5aa57 | 1334 | return CMD_UNDEFINED; |
f3ed775e | 1335 | } |
de044b7a DG |
1336 | |
1337 | /* Validate event type. Multiple event type are not supported. */ | |
1338 | if (event_type == -1) { | |
1339 | event_type = opt_event_type; | |
1340 | } else { | |
1341 | if (event_type != opt_event_type) { | |
1342 | ERR("Multiple event type not supported."); | |
27b5aa57 | 1343 | return CMD_ERROR; |
de044b7a DG |
1344 | } |
1345 | } | |
f3ed775e DG |
1346 | } |
1347 | ||
3ecec76a | 1348 | ret = print_missing_or_multiple_domains( |
28ab034a | 1349 | opt_kernel + opt_userspace + opt_jul + opt_log4j + opt_python, true); |
3ecec76a | 1350 | if (ret) { |
27b5aa57 | 1351 | return CMD_ERROR; |
3ecec76a PP |
1352 | } |
1353 | ||
89476427 JRJ |
1354 | /* Mi check */ |
1355 | if (lttng_opt_mi) { | |
8884bbc1 | 1356 | writer = mi_writer_uptr(mi_lttng_writer_create(fileno(stdout), lttng_opt_mi)); |
89476427 | 1357 | if (!writer) { |
27b5aa57 JG |
1358 | LTTNG_THROW_ERROR(lttng::format( |
1359 | "Failed to create MI writer: format_code={}", lttng_opt_mi)); | |
89476427 JRJ |
1360 | } |
1361 | ||
1362 | /* Open command element */ | |
8884bbc1 JG |
1363 | ret = mi_lttng_writer_command_open(writer.get(), |
1364 | mi_lttng_element_command_enable_event); | |
89476427 | 1365 | if (ret) { |
27b5aa57 JG |
1366 | LTTNG_THROW_ERROR(lttng::format( |
1367 | "Failed to open MI command element: command_name=`{}`", | |
1368 | mi_lttng_element_command_enable_event)); | |
89476427 JRJ |
1369 | } |
1370 | ||
1371 | /* Open output element */ | |
8884bbc1 | 1372 | ret = mi_lttng_writer_open_element(writer.get(), mi_lttng_element_command_output); |
89476427 | 1373 | if (ret) { |
27b5aa57 JG |
1374 | LTTNG_THROW_ERROR( |
1375 | lttng::format("Failed to open MI element: element_name=`{}`", | |
1376 | mi_lttng_element_command_output)); | |
89476427 JRJ |
1377 | } |
1378 | } | |
1379 | ||
27b5aa57 JG |
1380 | /* Close the MI command context when leaving the function, no matter the result. */ |
1381 | const auto close_mi_on_exit = lttng::make_scope_exit([&success]() noexcept { | |
1382 | if (!lttng_opt_mi) { | |
1383 | return; | |
1384 | } | |
1385 | ||
1386 | /* Close output element. */ | |
1387 | if (mi_lttng_writer_close_element(writer.get())) { | |
1388 | ERR_FMT("Failed to close MI output element"); | |
1389 | return; | |
1390 | } | |
1391 | ||
1392 | if (mi_lttng_writer_write_element_bool( | |
1393 | writer.get(), mi_lttng_element_command_success, success)) { | |
1394 | ERR_FMT("Failed to write MI element: element_name=`{}`, value={}", | |
1395 | mi_lttng_element_command_success, | |
1396 | success); | |
1397 | return; | |
1398 | } | |
1399 | ||
1400 | /* Command element close. */ | |
1401 | if (mi_lttng_writer_command_close(writer.get())) { | |
1402 | ERR_FMT("Failed to close MI command element"); | |
1403 | return; | |
1404 | } | |
1405 | }); | |
1406 | ||
c926bb36 | 1407 | arg_event_list = poptGetArg(pc.get()); |
cd9adb8b | 1408 | if (arg_event_list == nullptr && opt_enable_all == 0) { |
5b915816 | 1409 | ERR("Missing event name(s)."); |
27b5aa57 | 1410 | return CMD_ERROR; |
f3ed775e DG |
1411 | } |
1412 | ||
bf1413aa JG |
1413 | for (std::string line; std::getline(event_list_arg_stream, line, ',');) { |
1414 | patterns.emplace_back(std::move(line)); | |
5b915816 MJ |
1415 | } |
1416 | ||
c926bb36 | 1417 | leftover = poptGetArg(pc.get()); |
68c7f6e5 JD |
1418 | if (leftover) { |
1419 | ERR("Unknown argument: %s", leftover); | |
27b5aa57 | 1420 | return CMD_ERROR; |
68c7f6e5 JD |
1421 | } |
1422 | ||
cd80958d | 1423 | if (!opt_session_name) { |
bf1413aa JG |
1424 | const auto rc_file_session_name = |
1425 | lttng::make_unique_wrapper<char, lttng::free>(get_session_name()); | |
1426 | ||
1427 | if (!rc_file_session_name) { | |
27b5aa57 | 1428 | return CMD_ERROR; |
cd80958d | 1429 | } |
bf1413aa JG |
1430 | |
1431 | session_name = rc_file_session_name.get(); | |
cd80958d DG |
1432 | } else { |
1433 | session_name = opt_session_name; | |
1434 | } | |
1435 | ||
bf1413aa | 1436 | command_ret = enable_events(session_name, patterns); |
89476427 | 1437 | if (command_ret) { |
27b5aa57 | 1438 | return CMD_ERROR; |
89476427 | 1439 | } |
f3ed775e | 1440 | |
27b5aa57 | 1441 | return CMD_SUCCESS; |
f3ed775e | 1442 | } |