From 9fd30396a597942084b007f33cc7f2c279f746e9 Mon Sep 17 00:00:00 2001 From: Mathieu Desnoyers Date: Thu, 19 Sep 2019 10:10:31 -0400 Subject: [PATCH] Fix: provide errno as argument to urcu_die() commit 1a990de3add "Fix: rculfhash worker needs to unblock to SIGRCU" provides "ret" (-1) as argument to urcu_die(), but should rather provide errno. Reported by Coverity: ** CID 1405700: Error handling issues (NEGATIVE_RETURNS) /src/rculfhash.c: 2171 in cds_lfht_worker_init() Signed-off-by: Mathieu Desnoyers --- src/rculfhash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rculfhash.c b/src/rculfhash.c index 5b3c06b..811d515 100644 --- a/src/rculfhash.c +++ b/src/rculfhash.c @@ -2168,7 +2168,7 @@ static void cds_lfht_worker_init(struct urcu_workqueue *workqueue, urcu_die(errno); ret = sigdelset(&mask, SIGRCU); if (ret) - urcu_die(ret); + urcu_die(errno); ret = pthread_sigmask(SIG_SETMASK, &mask, NULL); if (ret) urcu_die(ret); -- 2.34.1