From 356c8794ee9e562954a52653fbb8f37b7fe16082 Mon Sep 17 00:00:00 2001 From: Lai Jiangshan Date: Thu, 15 Sep 2011 11:24:03 -0400 Subject: [PATCH] avoid leaking crdp for failed path [ Comment: now that set_cpu_call_rcu_data() is not racy and detects overwrites, we can effectively trust its return value and free the crdp if already set. ] Signed-off-by: Lai Jiangshan Signed-off-by: Mathieu Desnoyers --- urcu-call-rcu-impl.h | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/urcu-call-rcu-impl.h b/urcu-call-rcu-impl.h index ae93468..f9250e8 100644 --- a/urcu-call-rcu-impl.h +++ b/urcu-call-rcu-impl.h @@ -522,8 +522,13 @@ int create_all_cpu_call_rcu_data(unsigned long flags) } call_rcu_unlock(&call_rcu_mutex); if ((ret = set_cpu_call_rcu_data(i, crdp)) != 0) { - /* FIXME: Leaks crdp for now. */ - return ret; /* Can happen on race. */ + call_rcu_data_free(crdp); + + /* it has been created by other thread */ + if (ret == -EEXIST) + continue; + + return ret; } } return 0; -- 2.34.1