From: Paolo Bonzini Date: Tue, 13 Sep 2011 17:49:28 +0000 (-0400) Subject: urcu-qsbr: use rcu_thread_offline/rcu_thread_online instead of inlining them X-Git-Tag: v0.6.5~24 X-Git-Url: https://git.liburcu.org/?p=urcu.git;a=commitdiff_plain;h=27b940e7a3f4ebd44ac60636905374e59751e835;hp=27b940e7a3f4ebd44ac60636905374e59751e835 urcu-qsbr: use rcu_thread_offline/rcu_thread_online instead of inlining them * Mathieu Desnoyers wrote: > Just to let you know that I pushed two updates into urcu: one fixes a > grace period hang caused by a missing wakeup in the synchronize_rcu > QSBR code. This appears to hit us due to the more fine-grained wakeup > code brought by Paolo. The wakeup was really missing from the > synchronize_rcu code (so Paolo's code just triggered an existing > problem). I thought it would be good to let you know the effect: grace > periods are delayed forever. This problem never appeared in a release > (I caught it before). Good catch. Why not use rcu_thread_offline/online in synchronize_rcu, instead of touching rcu_reader.ctr directly? I had this in my QEMU branch but hadn't posted yet because it was meant as a cleanup only. Signed-off-by: Mathieu Desnoyers ---