X-Git-Url: https://git.liburcu.org/?p=urcu.git;a=blobdiff_plain;f=urcu.c;h=8ff39db1331e5a33cfc102b9fb3283e6c58fc2df;hp=07661a3cb448b34505f24a8552a421741bb282bd;hb=3644b3ee9ca6a858cf733579012ef595d652dcdf;hpb=bc6c15bba37d0e6192c006c4d9815201b36d1988 diff --git a/urcu.c b/urcu.c index 07661a3..8ff39db 100644 --- a/urcu.c +++ b/urcu.c @@ -63,25 +63,14 @@ long urcu_gp_ctr = RCU_GP_COUNT; * Written to only by each individual reader. Read by both the reader and the * writers. */ -long __thread urcu_active_readers; - -/* Thread IDs of registered readers */ -#define INIT_NUM_THREADS 4 - -struct reader_registry { - pthread_t tid; - long *urcu_active_readers; - char *need_mb; -}; +struct urcu_reader __thread urcu_reader; #ifdef DEBUG_YIELD unsigned int yield_active; unsigned int __thread rand_yield; #endif -static struct reader_registry *registry; -static char __thread need_mb; -static int num_readers, alloc_readers; +static LIST_HEAD(registry); static void internal_urcu_lock(void) { @@ -100,9 +89,9 @@ static void internal_urcu_lock(void) perror("Error in pthread mutex lock"); exit(-1); } - if (need_mb) { + if (urcu_reader.need_mb) { smp_mb(); - need_mb = 0; + urcu_reader.need_mb = 0; smp_mb(); } poll(NULL,0,10); @@ -130,26 +119,29 @@ static void switch_next_urcu_qparity(void) } #ifdef URCU_MB -static void force_mb_single_thread(struct reader_registry *index) +#if 0 /* unused */ +static void force_mb_single_thread(struct urcu_reader *index) { smp_mb(); } +#endif //0 static void force_mb_all_threads(void) { smp_mb(); } #else /* #ifdef URCU_MB */ -static void force_mb_single_thread(struct reader_registry *index) +#if 0 /* unused */ +static void force_mb_single_thread(struct urcu_reader *index) { - assert(registry); + assert(!list_empty(®istry)); /* * pthread_kill has a smp_mb(). But beware, we assume it performs * a cache flush on architectures with non-coherent cache. Let's play * safe and don't assume anything : we use smp_mc() to make sure the * cache flush is enforced. */ - *index->need_mb = 1; + index->need_mb = 1; smp_mc(); /* write ->need_mb before sending the signals */ pthread_kill(index->tid, SIGURCU); smp_mb(); @@ -157,20 +149,22 @@ static void force_mb_single_thread(struct reader_registry *index) * Wait for sighandler (and thus mb()) to execute on every thread. * BUSY-LOOP. */ - while (*index->need_mb) { + while (index->need_mb) { poll(NULL, 0, 1); } smp_mb(); /* read ->need_mb before ending the barrier */ } +#endif //0 static void force_mb_all_threads(void) { - struct reader_registry *index; + struct urcu_reader *index; + /* * Ask for each threads to execute a smp_mb() so we can consider the * compiler barriers around rcu read lock as real memory barriers. */ - if (!registry) + if (list_empty(®istry)) return; /* * pthread_kill has a smp_mb(). But beware, we assume it performs @@ -178,8 +172,8 @@ static void force_mb_all_threads(void) * safe and don't assume anything : we use smp_mc() to make sure the * cache flush is enforced. */ - for (index = registry; index < registry + num_readers; index++) { - *index->need_mb = 1; + list_for_each_entry(index, ®istry, head) { + index->need_mb = 1; smp_mc(); /* write need_mb before sending the signal */ pthread_kill(index->tid, SIGURCU); } @@ -196,8 +190,8 @@ static void force_mb_all_threads(void) * relevant bug report. For Linux kernels, we recommend getting * the Linux Test Project (LTP). */ - for (index = registry; index < registry + num_readers; index++) { - while (*index->need_mb) { + list_for_each_entry(index, ®istry, head) { + while (index->need_mb) { pthread_kill(index->tid, SIGURCU); poll(NULL, 0, 1); } @@ -209,63 +203,82 @@ static void force_mb_all_threads(void) /* * synchronize_rcu() waiting. Single thread. */ -static void wait_gp(struct reader_registry *index) +static void wait_gp(void) { - atomic_dec(&gp_futex); - force_mb_single_thread(index); /* Write futex before read reader_gp */ - if (!rcu_old_gp_ongoing(index->urcu_active_readers)) { - /* Read reader_gp before write futex */ - force_mb_single_thread(index); - /* Callbacks are queued, don't wait. */ - atomic_set(&gp_futex, 0); - } else { - /* Read reader_gp before read futex */ - force_mb_single_thread(index); - if (atomic_read(&gp_futex) == -1) - futex(&gp_futex, FUTEX_WAIT, -1, - NULL, NULL, 0); - } + /* Read reader_gp before read futex */ + force_mb_all_threads(); + if (uatomic_read(&gp_futex) == -1) + futex(&gp_futex, FUTEX_WAIT, -1, + NULL, NULL, 0); } void wait_for_quiescent_state(void) { - struct reader_registry *index; + LIST_HEAD(qsreaders); + int wait_loops = 0; + struct urcu_reader *index, *tmp; - if (!registry) + if (list_empty(®istry)) return; /* - * Wait for each thread urcu_active_readers count to become 0. + * Wait for each thread urcu_reader.ctr count to become 0. */ - for (index = registry; index < registry + num_readers; index++) { - int wait_loops = 0; + for (;;) { + wait_loops++; + if (wait_loops == RCU_QS_ACTIVE_ATTEMPTS) { + uatomic_dec(&gp_futex); + /* Write futex before read reader_gp */ + force_mb_all_threads(); + } + + list_for_each_entry_safe(index, tmp, ®istry, head) { + if (!rcu_old_gp_ongoing(&index->ctr)) + list_move(&index->head, &qsreaders); + } + #ifndef HAS_INCOHERENT_CACHES - while (rcu_old_gp_ongoing(index->urcu_active_readers)) { - if (wait_loops++ == RCU_QS_ACTIVE_ATTEMPTS) { - wait_gp(index); - } else { - cpu_relax(); + if (list_empty(®istry)) { + if (wait_loops == RCU_QS_ACTIVE_ATTEMPTS) { + /* Read reader_gp before write futex */ + force_mb_all_threads(); + uatomic_set(&gp_futex, 0); } + break; + } else { + if (wait_loops == RCU_QS_ACTIVE_ATTEMPTS) + wait_gp(); + else + cpu_relax(); } #else /* #ifndef HAS_INCOHERENT_CACHES */ /* * BUSY-LOOP. Force the reader thread to commit its - * urcu_active_readers update to memory if we wait for too long. + * urcu_reader.ctr update to memory if we wait for too long. */ - while (rcu_old_gp_ongoing(index->urcu_active_readers)) { - switch (wait_loops++) { + if (list_empty(®istry)) { + if (wait_loops == RCU_QS_ACTIVE_ATTEMPTS) { + /* Read reader_gp before write futex */ + force_mb_all_threads(); + uatomic_set(&gp_futex, 0); + } + break; + } else { + switch (wait_loops) { case RCU_QS_ACTIVE_ATTEMPTS: - wait_gp(index); - break; + wait_gp(); + break; /* only escape switch */ case KICK_READER_LOOPS: - force_mb_single_thread(index); + force_mb_all_threads(); wait_loops = 0; - break; + break; /* only escape switch */ default: cpu_relax(); } } #endif /* #else #ifndef HAS_INCOHERENT_CACHES */ } + /* put back the reader list in the registry */ + list_splice(&qsreaders, ®istry); } void synchronize_rcu(void) @@ -359,99 +372,22 @@ void rcu_read_unlock(void) _rcu_read_unlock(); } -void *rcu_dereference(void *p) -{ - return _rcu_dereference(p); -} - -void *rcu_assign_pointer_sym(void **p, void *v) -{ - wmb(); - return STORE_SHARED(p, v); -} - -void *rcu_xchg_pointer_sym(void **p, void *v) -{ - wmb(); - return xchg(p, v); -} - -void *rcu_cmpxchg_pointer_sym(void **p, void *old, void *_new) -{ - wmb(); - return cmpxchg(p, old, _new); -} - -void *rcu_publish_content_sym(void **p, void *v) -{ - void *oldptr; - - oldptr = _rcu_xchg_pointer(p, v); - synchronize_rcu(); - return oldptr; -} - -static void rcu_add_reader(pthread_t id) -{ - struct reader_registry *oldarray; - - if (!registry) { - alloc_readers = INIT_NUM_THREADS; - num_readers = 0; - registry = - malloc(sizeof(struct reader_registry) * alloc_readers); - } - if (alloc_readers < num_readers + 1) { - oldarray = registry; - registry = malloc(sizeof(struct reader_registry) - * (alloc_readers << 1)); - memcpy(registry, oldarray, - sizeof(struct reader_registry) * alloc_readers); - alloc_readers <<= 1; - free(oldarray); - } - registry[num_readers].tid = id; - /* reference to the TLS of _this_ reader thread. */ - registry[num_readers].urcu_active_readers = &urcu_active_readers; - registry[num_readers].need_mb = &need_mb; - num_readers++; -} - -/* - * Never shrink (implementation limitation). - * This is O(nb threads). Eventually use a hash table. - */ -static void rcu_remove_reader(pthread_t id) -{ - struct reader_registry *index; - - assert(registry != NULL); - for (index = registry; index < registry + num_readers; index++) { - if (pthread_equal(index->tid, id)) { - memcpy(index, ®istry[num_readers - 1], - sizeof(struct reader_registry)); - registry[num_readers - 1].tid = 0; - registry[num_readers - 1].urcu_active_readers = NULL; - num_readers--; - return; - } - } - /* Hrm not found, forgot to register ? */ - assert(0); -} - void rcu_register_thread(void) { + urcu_reader.tid = pthread_self(); + assert(urcu_reader.need_mb == 0); + assert(urcu_reader.ctr == 0); + internal_urcu_lock(); urcu_init(); /* In case gcc does not support constructor attribute */ - rcu_add_reader(pthread_self()); + list_add(&urcu_reader.head, ®istry); internal_urcu_unlock(); } void rcu_unregister_thread(void) { internal_urcu_lock(); - rcu_remove_reader(pthread_self()); + list_del(&urcu_reader.head); internal_urcu_unlock(); } @@ -464,7 +400,7 @@ static void sigurcu_handler(int signo, siginfo_t *siginfo, void *context) * executed on. */ smp_mb(); - need_mb = 0; + urcu_reader.need_mb = 0; smp_mb(); } @@ -506,6 +442,6 @@ void urcu_exit(void) exit(-1); } assert(act.sa_sigaction == sigurcu_handler); - free(registry); + assert(list_empty(®istry)); } #endif /* #ifndef URCU_MB */