X-Git-Url: https://git.liburcu.org/?p=urcu.git;a=blobdiff_plain;f=urcu-bp.c;h=93d781fcf44e5f2c9ee89928631a9d0d6cbb3e21;hp=a823659f78d4ce93d82a23b95dc05216feb9c903;hb=9d8612b71148c42a430e1419bad3b9b09453f64a;hpb=f61dfd97f545ebbc45fafd96b57bdc6eb655716d diff --git a/urcu-bp.c b/urcu-bp.c index a823659..93d781f 100644 --- a/urcu-bp.c +++ b/urcu-bp.c @@ -305,26 +305,37 @@ int rcu_read_ongoing(void) */ static void resize_arena(struct registry_arena *arena, size_t len) { - void *new_arena; + void *new_p; + size_t old_len; + + old_len = arena->len; if (!arena->p) - new_arena = mmap(arena->p, len, - PROT_READ | PROT_WRITE, - MAP_ANONYMOUS | MAP_PRIVATE, - -1, 0); + new_p = mmap(arena->p, len, + PROT_READ | PROT_WRITE, + MAP_ANONYMOUS | MAP_PRIVATE, + -1, 0); else - new_arena = mremap_wrapper(arena->p, arena->len, - len, MREMAP_MAYMOVE); - assert(new_arena != MAP_FAILED); + new_p = mremap_wrapper(arena->p, old_len, + len, MREMAP_MAYMOVE); + assert(new_p != MAP_FAILED); + + /* + * Zero the newly allocated memory. Since mmap() does not + * clearly specify if memory is zeroed or not (although it is + * very likely that it is), be extra careful by not expecting + * the new range to be zeroed by mremap. + */ + bzero(new_p + old_len, len - old_len); /* - * re-used the same region ? + * If we did not re-use the same region, we need to update the + * arena pointer. */ - if (new_arena == arena->p) - return; + if (new_p != arena->p) + arena->p = new_p; - bzero(new_arena + arena->len, len - arena->len); - arena->p = new_arena; + arena->len = len; } /* Called with signals off and mutex locked */