X-Git-Url: https://git.liburcu.org/?p=urcu.git;a=blobdiff_plain;f=tests%2Ftest_urcu_lfq.c;h=b61a7d4815788af2bcd9e197dc319a8eb053791a;hp=5fd0ff38cb0ecd15a462072394a18ac7598a3ae1;hb=6e5f88cf94a225b155719046d87bfd32ba47e06a;hpb=6ade67d5cb23ae9e2c18e7c2a62e3202552fb9e2

diff --git a/tests/test_urcu_lfq.c b/tests/test_urcu_lfq.c
index 5fd0ff3..b61a7d4 100644
--- a/tests/test_urcu_lfq.c
+++ b/tests/test_urcu_lfq.c
@@ -34,12 +34,15 @@
 #include <unistd.h>
 #include <stdio.h>
 #include <assert.h>
-#include <sys/syscall.h>
 #include <sched.h>
 #include <errno.h>
 
 #include <urcu/arch.h>
 
+#ifdef __linux__
+#include <syscall.h>
+#endif
+
 /* hardcoded number of CPUs */
 #define NR_CPUS 16384
 
@@ -62,7 +65,7 @@ static inline pid_t gettid(void)
 #define _LGPL_SOURCE
 #endif
 #include <urcu.h>
-#include <urcu/rculfqueue.h>
+#include <urcu/cds.h>
 #include <urcu-defer.h>
 
 static volatile int test_go, test_stop;
@@ -177,7 +180,9 @@ void *thr_enqueuer(void *_count)
 		if (!node)
 			goto fail;
 		cds_lfq_node_init_rcu(node);
+		rcu_read_lock();
 		cds_lfq_enqueue_rcu(&q, node);
+		rcu_read_unlock();
 		nr_successful_enqueues++;
 
 		if (unlikely(wdelay))
@@ -200,17 +205,10 @@ fail:
 
 }
 
-static void rcu_release_node(struct urcu_ref *ref)
-{
-	struct cds_lfq_node_rcu *node = caa_container_of(ref, struct cds_lfq_node_rcu, ref);
-	defer_rcu(free, node);
-	//synchronize_rcu();
-	//free(node);
-}
-
 void *thr_dequeuer(void *_count)
 {
 	unsigned long long *count = _count;
+	int ret;
 
 	printf_verbose("thread_begin %s, thread id : %lx, tid %lu\n",
 			"dequeuer", pthread_self(), (unsigned long)gettid());
@@ -230,11 +228,14 @@ void *thr_dequeuer(void *_count)
 	cmm_smp_mb();
 
 	for (;;) {
-		struct cds_lfq_node_rcu *node = cds_lfq_dequeue_rcu(&q,
-							    rcu_release_node);
+		struct cds_lfq_node_rcu *node;
+
+		rcu_read_lock();
+		node = cds_lfq_dequeue_rcu(&q);
+		rcu_read_unlock();
 
 		if (node) {
-			urcu_ref_put(&node->ref, rcu_release_node);
+			defer_rcu(free, node);
 			nr_successful_dequeues++;
 		}
 
@@ -247,7 +248,6 @@ void *thr_dequeuer(void *_count)
 
 	rcu_unregister_thread();
 	rcu_defer_unregister_thread();
-
 	printf_verbose("dequeuer thread_end, thread id : %lx, tid %lu, "
 		       "dequeues %llu, successful_dequeues %llu\n",
 		       pthread_self(), (unsigned long)gettid(), nr_dequeues,
@@ -257,20 +257,16 @@ void *thr_dequeuer(void *_count)
 	return ((void*)2);
 }
 
-static void release_node(struct urcu_ref *ref)
-{
-	struct cds_lfq_node_rcu *node = caa_container_of(ref, struct cds_lfq_node_rcu, ref);
-	free(node);
-}
-
 void test_end(struct cds_lfq_queue_rcu *q, unsigned long long *nr_dequeues)
 {
 	struct cds_lfq_node_rcu *node;
 
 	do {
-		node = cds_lfq_dequeue_rcu(q, release_node);
+		rcu_read_lock();
+		node = cds_lfq_dequeue_rcu(q);
+		rcu_read_unlock();
 		if (node) {
-			urcu_ref_put(&node->ref, release_node);
+			free(node);	/* no more concurrent access */
 			(*nr_dequeues)++;
 		}
 	} while (node);
@@ -367,7 +363,7 @@ int main(int argc, char **argv)
 	tid_dequeuer = malloc(sizeof(*tid_dequeuer) * nr_dequeuers);
 	count_enqueuer = malloc(2 * sizeof(*count_enqueuer) * nr_enqueuers);
 	count_dequeuer = malloc(2 * sizeof(*count_dequeuer) * nr_dequeuers);
-	cds_lfq_init_rcu(&q);
+	cds_lfq_init_rcu(&q, call_rcu);
 
 	next_aff = 0;
 
@@ -412,6 +408,8 @@ int main(int argc, char **argv)
 	}
 	
 	test_end(&q, &end_dequeues);
+	err = cds_lfq_destroy_rcu(&q);
+	assert(!err);
 
 	printf_verbose("total number of enqueues : %llu, dequeues %llu\n",
 		       tot_enqueues, tot_dequeues);