X-Git-Url: https://git.liburcu.org/?p=urcu.git;a=blobdiff_plain;f=tests%2Fbenchmark%2Ftest_rwlock.c;h=7ee73b42a25f162e024edcff3fdb8b4c8ce41171;hp=444859770fbc1127c1b73afa88084d8a4fee103e;hb=2388c075d46055bd33ee824c399d72c219b98d90;hpb=6893800a4d1cc14dff0395ddcd660a5138db183d diff --git a/tests/benchmark/test_rwlock.c b/tests/benchmark/test_rwlock.c index 4448597..7ee73b4 100644 --- a/tests/benchmark/test_rwlock.c +++ b/tests/benchmark/test_rwlock.c @@ -33,7 +33,6 @@ #include #include -#include "cpuset.h" #include "thread-id.h" /* hardcoded number of CPUs */ @@ -48,7 +47,11 @@ struct test_array { int a; }; -pthread_rwlock_t lock = PTHREAD_RWLOCK_INITIALIZER; +/* + * static rwlock initializer is broken on Cygwin. Use runtime + * initialization. + */ +pthread_rwlock_t lock; static volatile int test_go, test_stop; @@ -86,7 +89,7 @@ pthread_mutex_t affinity_mutex = PTHREAD_MUTEX_INITIALIZER; static void set_affinity(void) { -#if HAVE_SCHED_SETAFFINITY +#ifdef HAVE_SCHED_SETAFFINITY cpu_set_t mask; int cpu, ret; #endif /* HAVE_SCHED_SETAFFINITY */ @@ -94,7 +97,7 @@ static void set_affinity(void) if (!use_affinity) return; -#if HAVE_SCHED_SETAFFINITY +#ifdef HAVE_SCHED_SETAFFINITY ret = pthread_mutex_lock(&affinity_mutex); if (ret) { perror("Error in pthread mutex lock"); @@ -109,11 +112,7 @@ static void set_affinity(void) CPU_ZERO(&mask); CPU_SET(cpu, &mask); -#if SCHED_SETAFFINITY_ARGS == 2 - sched_setaffinity(0, &mask); -#else sched_setaffinity(0, sizeof(mask), &mask); -#endif #endif /* HAVE_SCHED_SETAFFINITY */ } @@ -138,27 +137,7 @@ static unsigned int nr_writers; pthread_mutex_t rcu_copy_mutex = PTHREAD_MUTEX_INITIALIZER; -void rcu_copy_mutex_lock(void) -{ - int ret; - ret = pthread_mutex_lock(&rcu_copy_mutex); - if (ret) { - perror("Error in pthread mutex lock"); - exit(-1); - } -} - -void rcu_copy_mutex_unlock(void) -{ - int ret; - - ret = pthread_mutex_unlock(&rcu_copy_mutex); - if (ret) { - perror("Error in pthread mutex unlock"); - exit(-1); - } -} - +static void *thr_reader(void *_count) { unsigned long long *count = _count; @@ -173,26 +152,39 @@ void *thr_reader(void *_count) } for (;;) { - int a; + int a, ret; + + ret = pthread_rwlock_rdlock(&lock); + if (ret) { + fprintf(stderr, "reader pthread_rwlock_rdlock: %s\n", strerror(ret)); + abort(); + } - pthread_rwlock_rdlock(&lock); a = test_array.a; assert(a == 8); if (caa_unlikely(rduration)) loop_sleep(rduration); - pthread_rwlock_unlock(&lock); + + ret = pthread_rwlock_unlock(&lock); + if (ret) { + fprintf(stderr, "reader pthread_rwlock_unlock: %s\n", strerror(ret)); + abort(); + } + URCU_TLS(nr_reads)++; if (caa_unlikely(!test_duration_read())) break; } *count = URCU_TLS(nr_reads); - printf_verbose("thread_end %s, tid %lu\n", - "reader", urcu_get_thread_id()); + + printf_verbose("thread_end %s, tid %lu, count %llu\n", + "reader", urcu_get_thread_id(), *count); return ((void*)1); } +static void *thr_writer(void *_count) { unsigned long long *count = _count; @@ -208,26 +200,40 @@ void *thr_writer(void *_count) cmm_smp_mb(); for (;;) { - pthread_rwlock_wrlock(&lock); + int ret; + + ret = pthread_rwlock_wrlock(&lock); + if (ret) { + fprintf(stderr, "writer pthread_rwlock_wrlock: %s\n", strerror(ret)); + abort(); + } + test_array.a = 0; test_array.a = 8; if (caa_unlikely(wduration)) loop_sleep(wduration); - pthread_rwlock_unlock(&lock); + + ret = pthread_rwlock_unlock(&lock); + if (ret) { + fprintf(stderr, "writer pthread_rwlock_unlock: %s\n", strerror(ret)); + abort(); + } + URCU_TLS(nr_writes)++; if (caa_unlikely(!test_duration_write())) break; if (caa_unlikely(wdelay)) loop_sleep(wdelay); } - - printf_verbose("thread_end %s, tid %lu\n", - "writer", urcu_get_thread_id()); *count = URCU_TLS(nr_writes); + + printf_verbose("thread_end %s, tid %lu, count %llu\n", + "writer", urcu_get_thread_id(), *count); return ((void*)2); } -void show_usage(int argc, char **argv) +static +void show_usage(char **argv) { printf("Usage : %s nr_readers nr_writers duration (s) \n", argv[0]); @@ -248,28 +254,29 @@ int main(int argc, char **argv) unsigned long long *count_reader, *count_writer; unsigned long long tot_reads = 0, tot_writes = 0; int i, a; + unsigned int i_thr; if (argc < 4) { - show_usage(argc, argv); + show_usage(argv); return -1; } cmm_smp_mb(); err = sscanf(argv[1], "%u", &nr_readers); if (err != 1) { - show_usage(argc, argv); + show_usage(argv); return -1; } err = sscanf(argv[2], "%u", &nr_writers); if (err != 1) { - show_usage(argc, argv); + show_usage(argv); return -1; } err = sscanf(argv[3], "%lu", &duration); if (err != 1) { - show_usage(argc, argv); + show_usage(argv); return -1; } @@ -279,7 +286,7 @@ int main(int argc, char **argv) switch (argv[i][1]) { case 'a': if (argc < i + 2) { - show_usage(argc, argv); + show_usage(argv); return -1; } a = atoi(argv[++i]); @@ -289,21 +296,21 @@ int main(int argc, char **argv) break; case 'c': if (argc < i + 2) { - show_usage(argc, argv); + show_usage(argv); return -1; } rduration = atol(argv[++i]); break; case 'd': if (argc < i + 2) { - show_usage(argc, argv); + show_usage(argv); return -1; } wdelay = atol(argv[++i]); break; case 'e': if (argc < i + 2) { - show_usage(argc, argv); + show_usage(argv); return -1; } wduration = atol(argv[++i]); @@ -317,10 +324,17 @@ int main(int argc, char **argv) printf_verbose("running test for %lu seconds, %u readers, %u writers.\n", duration, nr_readers, nr_writers); printf_verbose("Writer delay : %lu loops.\n", wdelay); + printf_verbose("Writer duration : %lu loops.\n", wduration); printf_verbose("Reader duration : %lu loops.\n", rduration); printf_verbose("thread %-6s, tid %lu\n", "main", urcu_get_thread_id()); + err = pthread_rwlock_init(&lock, NULL); + if (err != 0) { + fprintf(stderr, "pthread_rwlock_init: (%d) %s\n", err, strerror(err)); + exit(1); + } + tid_reader = calloc(nr_readers, sizeof(*tid_reader)); tid_writer = calloc(nr_writers, sizeof(*tid_writer)); count_reader = calloc(nr_readers, sizeof(*count_reader)); @@ -328,15 +342,15 @@ int main(int argc, char **argv) next_aff = 0; - for (i = 0; i < nr_readers; i++) { - err = pthread_create(&tid_reader[i], NULL, thr_reader, - &count_reader[i]); + for (i_thr = 0; i_thr < nr_readers; i_thr++) { + err = pthread_create(&tid_reader[i_thr], NULL, thr_reader, + &count_reader[i_thr]); if (err != 0) exit(1); } - for (i = 0; i < nr_writers; i++) { - err = pthread_create(&tid_writer[i], NULL, thr_writer, - &count_writer[i]); + for (i_thr = 0; i_thr < nr_writers; i_thr++) { + err = pthread_create(&tid_writer[i_thr], NULL, thr_writer, + &count_writer[i_thr]); if (err != 0) exit(1); } @@ -349,17 +363,17 @@ int main(int argc, char **argv) test_stop = 1; - for (i = 0; i < nr_readers; i++) { - err = pthread_join(tid_reader[i], &tret); + for (i_thr = 0; i_thr < nr_readers; i_thr++) { + err = pthread_join(tid_reader[i_thr], &tret); if (err != 0) exit(1); - tot_reads += count_reader[i]; + tot_reads += count_reader[i_thr]; } - for (i = 0; i < nr_writers; i++) { - err = pthread_join(tid_writer[i], &tret); + for (i_thr = 0; i_thr < nr_writers; i_thr++) { + err = pthread_join(tid_writer[i_thr], &tret); if (err != 0) exit(1); - tot_writes += count_writer[i]; + tot_writes += count_writer[i_thr]; } printf_verbose("total number of reads : %llu, writes %llu\n", tot_reads, @@ -371,6 +385,11 @@ int main(int argc, char **argv) nr_writers, wdelay, tot_reads, tot_writes, tot_reads + tot_writes); + err = pthread_rwlock_destroy(&lock); + if (err != 0) { + fprintf(stderr, "pthread_rwlock_destroy: (%d) %s\n", err, strerror(err)); + exit(1); + } free(tid_reader); free(tid_writer); free(count_reader);