X-Git-Url: https://git.liburcu.org/?p=urcu.git;a=blobdiff_plain;f=tests%2Fbenchmark%2Ftest_rwlock.c;h=530db82f782be27b34990522a68023239732448d;hp=32e3c39d99d25b5819339f4b2a4c8336ca6929eb;hb=bd23a6c64e8ccff9a666441958e34793748ebd3a;hpb=f5ab766ee2c8300cb00ca5878b1cb464f960a66d diff --git a/tests/benchmark/test_rwlock.c b/tests/benchmark/test_rwlock.c index 32e3c39..530db82 100644 --- a/tests/benchmark/test_rwlock.c +++ b/tests/benchmark/test_rwlock.c @@ -20,8 +20,6 @@ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ -#define _GNU_SOURCE -#include "config.h" #include #include #include @@ -35,7 +33,6 @@ #include #include -#include "cpuset.h" #include "thread-id.h" /* hardcoded number of CPUs */ @@ -43,8 +40,6 @@ #ifndef DYNAMIC_LINK_TEST #define _LGPL_SOURCE -#else -#define debug_yield_read() #endif #include @@ -52,7 +47,11 @@ struct test_array { int a; }; -pthread_rwlock_t lock = PTHREAD_RWLOCK_INITIALIZER; +/* + * static rwlock initializer is broken on Cygwin. Use runtime + * initialization. + */ +pthread_rwlock_t lock; static volatile int test_go, test_stop; @@ -113,11 +112,7 @@ static void set_affinity(void) CPU_ZERO(&mask); CPU_SET(cpu, &mask); -#if SCHED_SETAFFINITY_ARGS == 2 - sched_setaffinity(0, &mask); -#else sched_setaffinity(0, sizeof(mask), &mask); -#endif #endif /* HAVE_SCHED_SETAFFINITY */ } @@ -142,27 +137,7 @@ static unsigned int nr_writers; pthread_mutex_t rcu_copy_mutex = PTHREAD_MUTEX_INITIALIZER; -void rcu_copy_mutex_lock(void) -{ - int ret; - ret = pthread_mutex_lock(&rcu_copy_mutex); - if (ret) { - perror("Error in pthread mutex lock"); - exit(-1); - } -} - -void rcu_copy_mutex_unlock(void) -{ - int ret; - - ret = pthread_mutex_unlock(&rcu_copy_mutex); - if (ret) { - perror("Error in pthread mutex unlock"); - exit(-1); - } -} - +static void *thr_reader(void *_count) { unsigned long long *count = _count; @@ -177,23 +152,39 @@ void *thr_reader(void *_count) } for (;;) { - pthread_rwlock_rdlock(&lock); - assert(test_array.a == 8); + int a, ret; + + ret = pthread_rwlock_rdlock(&lock); + if (ret) { + fprintf(stderr, "reader pthread_rwlock_rdlock: %s\n", strerror(ret)); + abort(); + } + + a = test_array.a; + assert(a == 8); if (caa_unlikely(rduration)) loop_sleep(rduration); - pthread_rwlock_unlock(&lock); + + ret = pthread_rwlock_unlock(&lock); + if (ret) { + fprintf(stderr, "reader pthread_rwlock_unlock: %s\n", strerror(ret)); + abort(); + } + URCU_TLS(nr_reads)++; if (caa_unlikely(!test_duration_read())) break; } *count = URCU_TLS(nr_reads); - printf_verbose("thread_end %s, tid %lu\n", - "reader", urcu_get_thread_id()); + + printf_verbose("thread_end %s, tid %lu, count %llu\n", + "reader", urcu_get_thread_id(), *count); return ((void*)1); } +static void *thr_writer(void *_count) { unsigned long long *count = _count; @@ -209,33 +200,44 @@ void *thr_writer(void *_count) cmm_smp_mb(); for (;;) { - pthread_rwlock_wrlock(&lock); + int ret; + + ret = pthread_rwlock_wrlock(&lock); + if (ret) { + fprintf(stderr, "writer pthread_rwlock_wrlock: %s\n", strerror(ret)); + abort(); + } + test_array.a = 0; test_array.a = 8; if (caa_unlikely(wduration)) loop_sleep(wduration); - pthread_rwlock_unlock(&lock); + + ret = pthread_rwlock_unlock(&lock); + if (ret) { + fprintf(stderr, "writer pthread_rwlock_unlock: %s\n", strerror(ret)); + abort(); + } + URCU_TLS(nr_writes)++; if (caa_unlikely(!test_duration_write())) break; if (caa_unlikely(wdelay)) loop_sleep(wdelay); } - - printf_verbose("thread_end %s, tid %lu\n", - "writer", urcu_get_thread_id()); *count = URCU_TLS(nr_writes); + + printf_verbose("thread_end %s, tid %lu, count %llu\n", + "writer", urcu_get_thread_id(), *count); return ((void*)2); } +static void show_usage(int argc, char **argv) { printf("Usage : %s nr_readers nr_writers duration (s) \n", argv[0]); printf("OPTIONS:\n"); -#ifdef DEBUG_YIELD - printf(" [-r] [-w] (yield reader and/or writer)\n"); -#endif printf(" [-d delay] (writer period (us))\n"); printf(" [-c duration] (reader C.S. duration (in loops))\n"); printf(" [-e duration] (writer C.S. duration (in loops))\n"); @@ -252,6 +254,7 @@ int main(int argc, char **argv) unsigned long long *count_reader, *count_writer; unsigned long long tot_reads = 0, tot_writes = 0; int i, a; + unsigned int i_thr; if (argc < 4) { show_usage(argc, argv); @@ -281,14 +284,6 @@ int main(int argc, char **argv) if (argv[i][0] != '-') continue; switch (argv[i][1]) { -#ifdef DEBUG_YIELD - case 'r': - yield_active |= YIELD_READ; - break; - case 'w': - yield_active |= YIELD_WRITE; - break; -#endif case 'a': if (argc < i + 2) { show_usage(argc, argv); @@ -329,10 +324,17 @@ int main(int argc, char **argv) printf_verbose("running test for %lu seconds, %u readers, %u writers.\n", duration, nr_readers, nr_writers); printf_verbose("Writer delay : %lu loops.\n", wdelay); + printf_verbose("Writer duration : %lu loops.\n", wduration); printf_verbose("Reader duration : %lu loops.\n", rduration); printf_verbose("thread %-6s, tid %lu\n", "main", urcu_get_thread_id()); + err = pthread_rwlock_init(&lock, NULL); + if (err != 0) { + fprintf(stderr, "pthread_rwlock_init: (%d) %s\n", err, strerror(err)); + exit(1); + } + tid_reader = calloc(nr_readers, sizeof(*tid_reader)); tid_writer = calloc(nr_writers, sizeof(*tid_writer)); count_reader = calloc(nr_readers, sizeof(*count_reader)); @@ -340,15 +342,15 @@ int main(int argc, char **argv) next_aff = 0; - for (i = 0; i < nr_readers; i++) { - err = pthread_create(&tid_reader[i], NULL, thr_reader, - &count_reader[i]); + for (i_thr = 0; i_thr < nr_readers; i_thr++) { + err = pthread_create(&tid_reader[i_thr], NULL, thr_reader, + &count_reader[i_thr]); if (err != 0) exit(1); } - for (i = 0; i < nr_writers; i++) { - err = pthread_create(&tid_writer[i], NULL, thr_writer, - &count_writer[i]); + for (i_thr = 0; i_thr < nr_writers; i_thr++) { + err = pthread_create(&tid_writer[i_thr], NULL, thr_writer, + &count_writer[i_thr]); if (err != 0) exit(1); } @@ -361,17 +363,17 @@ int main(int argc, char **argv) test_stop = 1; - for (i = 0; i < nr_readers; i++) { - err = pthread_join(tid_reader[i], &tret); + for (i_thr = 0; i_thr < nr_readers; i_thr++) { + err = pthread_join(tid_reader[i_thr], &tret); if (err != 0) exit(1); - tot_reads += count_reader[i]; + tot_reads += count_reader[i_thr]; } - for (i = 0; i < nr_writers; i++) { - err = pthread_join(tid_writer[i], &tret); + for (i_thr = 0; i_thr < nr_writers; i_thr++) { + err = pthread_join(tid_writer[i_thr], &tret); if (err != 0) exit(1); - tot_writes += count_writer[i]; + tot_writes += count_writer[i_thr]; } printf_verbose("total number of reads : %llu, writes %llu\n", tot_reads, @@ -383,6 +385,11 @@ int main(int argc, char **argv) nr_writers, wdelay, tot_reads, tot_writes, tot_reads + tot_writes); + err = pthread_rwlock_destroy(&lock); + if (err != 0) { + fprintf(stderr, "pthread_rwlock_destroy: (%d) %s\n", err, strerror(err)); + exit(1); + } free(tid_reader); free(tid_writer); free(count_reader);