X-Git-Url: https://git.liburcu.org/?p=urcu.git;a=blobdiff_plain;f=compat_futex.c;h=a3571343ca37d086e77620da1ed0dd5e9fd71778;hp=e7342fe38ccda2330b45e157cd0c1d7cb02cd3ef;hb=b0a841b4ff807dd29fe0cdbfe24900312f0e627b;hpb=5c02e37d09b7b89f68429751344d2af00c89f4fd

diff --git a/compat_futex.c b/compat_futex.c
index e7342fe..a357134 100644
--- a/compat_futex.c
+++ b/compat_futex.c
@@ -30,6 +30,7 @@
 
 #include <urcu/arch.h>
 #include <urcu/futex.h>
+#include <urcu/system.h>
 
 /*
  * Using attribute "weak" for __urcu_compat_futex_lock and
@@ -53,7 +54,7 @@ pthread_cond_t __urcu_compat_futex_cond = PTHREAD_COND_INITIALIZER;
 int compat_futex_noasync(int32_t *uaddr, int op, int32_t val,
 	const struct timespec *timeout, int32_t *uaddr2, int32_t val3)
 {
-	int ret, gret = 0;
+	int ret;
 
 	/*
 	 * Check if NULL. Don't let users expect that they are taken into
@@ -69,23 +70,41 @@ int compat_futex_noasync(int32_t *uaddr, int op, int32_t val,
 	cmm_smp_mb();
 
 	ret = pthread_mutex_lock(&__urcu_compat_futex_lock);
-	assert(!ret);
+	if (ret) {
+		errno = ret;
+		ret = -1;
+		goto end;
+	}
 	switch (op) {
 	case FUTEX_WAIT:
-		if (*uaddr != val)
-			goto end;
-		pthread_cond_wait(&__urcu_compat_futex_cond, &__urcu_compat_futex_lock);
+		/*
+		 * Wait until *uaddr is changed to something else than "val".
+		 * Comparing *uaddr content against val figures out which
+		 * thread has been awakened.
+		 */
+		while (CMM_LOAD_SHARED(*uaddr) == val)
+			pthread_cond_wait(&__urcu_compat_futex_cond,
+				&__urcu_compat_futex_lock);
 		break;
 	case FUTEX_WAKE:
+		/*
+		 * Each wake is sending a broadcast, thus attempting wakeup of
+		 * all awaiting threads, independently of their respective
+		 * uaddr.
+		 */
 		pthread_cond_broadcast(&__urcu_compat_futex_cond);
 		break;
 	default:
-		gret = -EINVAL;
+		errno = EINVAL;
+		ret = -1;
 	}
-end:
 	ret = pthread_mutex_unlock(&__urcu_compat_futex_lock);
-	assert(!ret);
-	return gret;
+	if (ret) {
+		errno = ret;
+		ret = -1;
+	}
+end:
+	return ret;
 }
 
 /*
@@ -97,6 +116,8 @@ end:
 int compat_futex_async(int32_t *uaddr, int op, int32_t val,
 	const struct timespec *timeout, int32_t *uaddr2, int32_t val3)
 {
+	int ret = 0;
+
 	/*
 	 * Check if NULL. Don't let users expect that they are taken into
 	 * account. 
@@ -112,13 +133,20 @@ int compat_futex_async(int32_t *uaddr, int op, int32_t val,
 
 	switch (op) {
 	case FUTEX_WAIT:
-		while (*uaddr == val)
-			poll(NULL, 0, 10);
+		while (CMM_LOAD_SHARED(*uaddr) == val) {
+			if (poll(NULL, 0, 10) < 0) {
+				ret = -1;
+				/* Keep poll errno. Caller handles EINTR. */
+				goto end;
+			}
+		}
 		break;
 	case FUTEX_WAKE:
 		break;
 	default:
-		return -EINVAL;
+		errno = EINVAL;
+		ret = -1;
 	}
-	return 0;
+end:
+	return ret;
 }