update Makefile, -Wall

[urcu.git] / urcu.c

diff --git a/urcu.c b/urcu.c
index 7e79207be6a88eaaf6d2b74c0b16b4543368a6fd..d0d61385385d713bf221e078767295bd3ecfb2d6 100644 (file)
--- a/urcu.c
+++ b/urcu.c
@@ -1,3 +1,13 @@
+/*
+ * urcu.c
+ *
+ * Userspace RCU library
+ *
+ * Copyright February 2009 - Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
+ *
+ * Distributed under GPLv2
+ */
+
 #include <stdio.h>
 #include <pthread.h>
 #include <signal.h>
@@ -91,7 +101,7 @@ void wait_for_quiescent_state(int parity)
                /*
                 * BUSY-LOOP.
                 */
-               while (*index->urcu_active_readers != 0)
+               while (index->urcu_active_readers[parity] != 0)
                        barrier();
        }
        /*
@@ -109,7 +119,7 @@ void wait_for_quiescent_state(int parity)
  */
 void *urcu_publish_content(void **ptr, void *new)
 {
-       int ret, prev_parity;
+       int prev_parity;
        void *oldptr;
 
        /*
@@ -124,8 +134,8 @@ void *urcu_publish_content(void **ptr, void *new)
         */
        oldptr = *ptr;
        *ptr = new;
-       wmb();          /* Write ptr before changing the qparity */
        /* All threads should read qparity before ptr */
+       /* Write ptr before changing the qparity */
        force_mb_all_threads();
        prev_parity = switch_next_urcu_qparity();
 
@@ -197,7 +207,6 @@ void urcu_register_thread(void)
 
 void urcu_unregister_thread(void)
 {
-       pthread_t self = pthread_self();
        rcu_write_lock();
        urcu_remove_reader(pthread_self());
        rcu_write_unlock();