From ffce811cff28f0c357c1edc2b06cf10d2cda21c4 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=A9mie=20Galarneau?= Date: Wed, 19 Apr 2023 17:48:25 -0400 Subject: [PATCH] Tests: enable test_callstack on 32-bit x86 MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The test application used by test_callstack defines syscall stubs (instead of using the libc) for both 32 and 64 bit variants of x86. This limits the architectures that can run this test. However, the `uname` check is erroneous as it assumes that `uname -m` will return x86 for both architectures. It doesn't; it returns i386 or i686 (and I presume others) for 32-bit kernels. As such, the check is modified to check for '86' which, as far as I know, doesn't clash with other architectures. Signed-off-by: Jérémie Galarneau Change-Id: I267a81fadb2f1db6b135c6886ae5700184f2ae5b --- tests/regression/kernel/test_callstack | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/regression/kernel/test_callstack b/tests/regression/kernel/test_callstack index cd853ecde..cf39089af 100755 --- a/tests/regression/kernel/test_callstack +++ b/tests/regression/kernel/test_callstack @@ -120,8 +120,8 @@ function test_kernel_callstack() rm -rf "$TRACE_PATH" } -# Only run userspace callstack test on x86 -uname -m | grep -E "x86" >/dev/null 2>&1 +# Only run userspace callstack test on x86 (32 and 64 variants) +uname -m | grep "86" >/dev/null 2>&1 if test $? == 0; then NUM_TESTS=$((NUM_TESTS+10)) RUN_USERSPACE_TEST=1 -- 2.34.1