From b9a0350ae89f3b1d597eaa21389794e344f416d7 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=A9mie=20Galarneau?= Date: Tue, 25 Apr 2023 22:24:17 -0400 Subject: [PATCH] Test: mi: inverted logic in stop validation test MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Stopping a session twice should succeed (no-op). Moreover, the test mentions it tests a 'start' while it tests a 'stop' operation. Signed-off-by: Jérémie Galarneau Change-Id: I4c8f19f0ecc181921fb5e3dd4f882e3c2285adcd --- tests/regression/tools/mi/test_mi | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/regression/tools/mi/test_mi b/tests/regression/tools/mi/test_mi index 2c469f108..faeb3d09b 100755 --- a/tests/regression/tools/mi/test_mi +++ b/tests/regression/tools/mi/test_mi @@ -656,14 +656,14 @@ function test_start_stop () ok $? "Mi test: enabled element : $result expected: false" #Test failing stop command - stop_lttng_tracing_fail $session_name + stop_lttng_tracing_ok $session_name $MI_VALIDATE $OUTPUT_DEST - ok $? "Mi test: failed stop xsd validation" + ok $? "Mi test: stop warning xsd validation" - #Expect a false element + #Expect a true element extract_xml $OUTPUT_DEST $XPATH_COMMAND_SUCCESS result - test "$result" = "false" - ok $? "Mi test: mi report failure on start command as expected" + test "$result" = "true" + ok $? "Mi test: mi reports success on stop command as expected" #Teardown OUTPUT_DEST=$DEVNULL -- 2.34.1