From 18fc4860a6d3e3ec49c8a71c45ee7fcb4b25cf46 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Tue, 21 Sep 2021 09:30:09 -0400 Subject: [PATCH] Fix: include: remove unneeded declaration of lttng_session_descriptor_get_session_name MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit There is a declaration of lttng_session_descriptor_get_session_name in both session-descriptor.h and session-descriptor-internal.h. Since this is a function exposed by the API, the one in -internal.h is not needed, remove it. Since the removed declaration had LTTNG_HIDDEN, this has the effect of making the lttng_session_descriptor_get_session_name symbol of liblttng-ctl exported / part of the ABI. I think it was a mistake that it wasn't previously exported. Change-Id: I79d383f012d161a6df42240c6849b1b3af109def Signed-off-by: Simon Marchi Signed-off-by: Jérémie Galarneau --- include/lttng/session-descriptor-internal.h | 6 ------ 1 file changed, 6 deletions(-) diff --git a/include/lttng/session-descriptor-internal.h b/include/lttng/session-descriptor-internal.h index c8e26a856..96ba07c98 100644 --- a/include/lttng/session-descriptor-internal.h +++ b/include/lttng/session-descriptor-internal.h @@ -69,12 +69,6 @@ unsigned long long lttng_session_descriptor_live_get_timer_interval( const struct lttng_session_descriptor *descriptor); -LTTNG_HIDDEN -enum lttng_session_descriptor_status -lttng_session_descriptor_get_session_name( - const struct lttng_session_descriptor *descriptor, - const char **name); - LTTNG_HIDDEN int lttng_session_descriptor_set_session_name( struct lttng_session_descriptor *descriptor, -- 2.34.1