From: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Date: Wed, 26 Apr 2023 02:24:17 +0000 (-0400)
Subject: Test: mi: inverted logic in stop validation test
X-Git-Url: https://git.liburcu.org/?p=lttng-tools.git;a=commitdiff_plain;h=b9a0350ae89f3b1d597eaa21389794e344f416d7

Test: mi: inverted logic in stop validation test

Stopping a session twice should succeed (no-op). Moreover, the test
mentions it tests a 'start' while it tests a 'stop' operation.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: I4c8f19f0ecc181921fb5e3dd4f882e3c2285adcd
---

diff --git a/tests/regression/tools/mi/test_mi b/tests/regression/tools/mi/test_mi
index 2c469f108..faeb3d09b 100755
--- a/tests/regression/tools/mi/test_mi
+++ b/tests/regression/tools/mi/test_mi
@@ -656,14 +656,14 @@ function test_start_stop ()
 	ok $? "Mi test: enabled element : $result expected: false"
 
 	#Test failing stop command
-	stop_lttng_tracing_fail $session_name
+	stop_lttng_tracing_ok $session_name
 	$MI_VALIDATE $OUTPUT_DEST
-	ok $? "Mi test: failed stop xsd validation"
+	ok $? "Mi test: stop warning xsd validation"
 
-	#Expect a false element
+	#Expect a true element
 	extract_xml $OUTPUT_DEST $XPATH_COMMAND_SUCCESS result
-	test "$result" = "false"
-	ok $? "Mi test: mi report failure on start command as expected"
+	test "$result" = "true"
+	ok $? "Mi test: mi reports success on stop command as expected"
 
 	#Teardown
 	OUTPUT_DEST=$DEVNULL