From: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Date: Tue, 1 Mar 2022 15:27:37 +0000 (-0500)
Subject: Fix: common: local_attr might leak
X-Git-Tag: v2.13.5~31
X-Git-Url: https://git.liburcu.org/?p=lttng-tools.git;a=commitdiff_plain;h=1c6806108ad529966516cb253ac96996ca2777cd

Fix: common: local_attr might leak

Reported by Coverity:

    CID 1475808: Resource leak (RESOURCE_LEAK)
    Variable local_attr going out of scope leaks the storage it points to.

    CID 1475810: Resource leak (RESOURCE_LEAK)
    Variable local_attr going out of scope leaks the storage it points to.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: Ibe2ee6516618827b6f52676d9a9f7d510cadf1bc
---

diff --git a/src/common/event.c b/src/common/event.c
index 304b0fe95..c3f040ff4 100644
--- a/src/common/event.c
+++ b/src/common/event.c
@@ -201,6 +201,7 @@ static ssize_t lttng_event_probe_attr_create_from_payload(
 	local_attr = NULL;
 	ret = offset;
 end:
+	free(local_attr);
 	return ret;
 }
 
@@ -262,6 +263,7 @@ static ssize_t lttng_event_function_attr_create_from_payload(
 	local_attr = NULL;
 	ret = offset;
 end:
+	free(local_attr);
 	return ret;
 }