Fix: pthread::mutex unlock must not throw

unlock() is often called by destructors (e.g. lock guard); it must not
throw. We don't expect unlock to fail given our current usage anyhow.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: I5dfd856f8a2dd29fd7c480c6ab6289b5b91c4391

diff --git a/src/common/pthread-lock.hpp b/src/common/pthread-lock.hpp
index 35fde097cadbf92ea6f6744bc236272c2120c5e7..d19e3f3fbeb9ba066c19494ce209191859d2b495 100644 (file)
--- a/src/common/pthread-lock.hpp
+++ b/src/common/pthread-lock.hpp
@@ -57,7 +57,10 @@ public:
        void unlock()
        {
                if (pthread_mutex_unlock(&_mutex) != 0) {
-                       LTTNG_THROW_POSIX("Failed to unlock mutex", errno);
+                       /*
+                        * Unlock cannot throw as it is called as part of lock_guard's destructor.
+                        */
+                       abort();
                }
        }