lttng-ctl: separate support of named/unnamed trigger registration
[lttng-tools.git] / tests / regression / tools / notification / notification.c
index e1d57f9635fb15a5ac31bf80810b149a840593a4..092ac5f1ec5e978fafbdaf89467bf3eb3ac2c6ee 100644 (file)
@@ -579,33 +579,30 @@ struct capture_base_field_tuple test_capture_base_fields[] = {
 static const char *get_notification_trigger_name(
                struct lttng_notification *notification)
 {
-       const char *name = NULL;
-       enum lttng_evaluation_status status;
-       const struct lttng_evaluation *evaluation;
-       evaluation = lttng_notification_get_evaluation(notification);
-       if (evaluation == NULL) {
-               fail("lttng_notification_get_evaluation");
+       const char *trigger_name = NULL;
+       enum lttng_trigger_status trigger_status;
+       const struct lttng_trigger *trigger;
+
+       trigger = lttng_notification_get_trigger(notification);
+       if (!trigger) {
+               fail("Failed to get trigger from notification");
                goto end;
        }
 
-       switch (lttng_evaluation_get_type(evaluation)) {
-       case LTTNG_CONDITION_TYPE_ON_EVENT:
-       {
-               status = lttng_evaluation_on_event_get_trigger_name(
-                               evaluation, &name);
-               if (status != LTTNG_EVALUATION_STATUS_OK) {
-                       fail("lttng_evaluation_on_event_get_trigger_name");
-                       name = NULL;
-                       goto end;
-               }
+       trigger_status = lttng_trigger_get_name(trigger, &trigger_name);
+       switch (trigger_status) {
+       case LTTNG_TRIGGER_STATUS_OK:
+               break;
+       case LTTNG_TRIGGER_STATUS_UNSET:
+               trigger_name = "(anonymous)";
                break;
-       }
        default:
-               fail("Wrong notification evaluation type \n");
+               fail("Failed to get name from notification's trigger");
                goto end;
        }
+
 end:
-       return name;
+       return trigger_name;
 }
 
 static int validator_notification_trigger_name(
@@ -1452,13 +1449,12 @@ static void create_tracepoint_event_rule_trigger(const char *event_pattern,
                struct lttng_trigger **trigger)
 {
        enum lttng_event_rule_status event_rule_status;
-       enum lttng_trigger_status trigger_status;
-
        struct lttng_action *tmp_action = NULL;
        struct lttng_event_rule *event_rule = NULL;
        struct lttng_condition *tmp_condition = NULL;
        struct lttng_trigger *tmp_trigger = NULL;
        int ret;
+       enum lttng_error_code ret_code;
 
        assert(event_pattern);
        assert(trigger_name);
@@ -1504,7 +1500,7 @@ static void create_tracepoint_event_rule_trigger(const char *event_pattern,
                ok(success, "Setting tracepoint event rule exclusions");
        }
 
-       tmp_condition = lttng_condition_on_event_create(event_rule);
+       tmp_condition = lttng_condition_event_rule_matches_create(event_rule);
        ok(tmp_condition, "Condition event rule object creation");
 
        if (capture_desc_cb) {
@@ -1521,12 +1517,8 @@ static void create_tracepoint_event_rule_trigger(const char *event_pattern,
        tmp_trigger = lttng_trigger_create(tmp_condition, tmp_action);
        ok(tmp_trigger, "Trigger object creation %s", trigger_name);
 
-       trigger_status = lttng_trigger_set_name(tmp_trigger, trigger_name);
-       ok(trigger_status == LTTNG_TRIGGER_STATUS_OK,
-                       "Setting name to trigger %s", trigger_name);
-
-       ret = lttng_register_trigger(tmp_trigger);
-       ok(ret == 0, "Trigger registration %s", trigger_name);
+       ret_code = lttng_register_trigger_with_name(tmp_trigger, trigger_name);
+       ok(ret_code == LTTNG_OK, "Trigger registration %s", trigger_name);
 
        lttng_event_rule_destroy(event_rule);
 
@@ -1835,10 +1827,10 @@ static void test_kprobe_event_rule_notification(
                enum lttng_domain_type domain_type)
 {
        int i, ret;
+       enum lttng_error_code ret_code;
        const int notification_count = 3;
        enum lttng_notification_channel_status nc_status;
        enum lttng_event_rule_status event_rule_status;
-       enum lttng_trigger_status trigger_status;
        struct lttng_notification_channel *notification_channel = NULL;
        struct lttng_condition *condition = NULL;
        struct lttng_kernel_probe_location *location = NULL;
@@ -1872,7 +1864,7 @@ static void test_kprobe_event_rule_notification(
        ok(event_rule_status == LTTNG_EVENT_RULE_STATUS_OK,
                        "Setting kprobe event rule name: '%s'", trigger_name);
 
-       condition = lttng_condition_on_event_create(event_rule);
+       condition = lttng_condition_event_rule_matches_create(event_rule);
        ok(condition, "Condition event rule object creation");
 
        /* Register the trigger for condition. */
@@ -1882,12 +1874,8 @@ static void test_kprobe_event_rule_notification(
                goto end;
        }
 
-       trigger_status = lttng_trigger_set_name(trigger, trigger_name);
-       ok(trigger_status == LTTNG_TRIGGER_STATUS_OK,
-                       "Setting trigger name to '%s'", trigger_name);
-
-       ret = lttng_register_trigger(trigger);
-       if (ret) {
+       ret_code = lttng_register_trigger_with_name(trigger, trigger_name);
+       if (ret_code != LTTNG_OK) {
                fail("Failed to register trigger with kernel probe event rule condition and notify action");
                goto end;
        }
@@ -1936,10 +1924,10 @@ static void test_uprobe_event_rule_notification(
                const char *test_symbol_name)
 {
        int i, ret;
+       enum lttng_error_code ret_code;
        const int notification_count = 3;
        enum lttng_notification_channel_status nc_status;
        enum lttng_event_rule_status event_rule_status;
-       enum lttng_trigger_status trigger_status;
        struct lttng_notification_channel *notification_channel = NULL;
        struct lttng_userspace_probe_location *probe_location = NULL;
        struct lttng_userspace_probe_location_lookup_method *lookup_method =
@@ -1973,20 +1961,15 @@ static void test_uprobe_event_rule_notification(
                        lttng_session_daemon_notification_endpoint);
        ok(notification_channel, "Notification channel object creation");
 
-       event_rule = lttng_event_rule_userspace_probe_create();
+       event_rule = lttng_event_rule_userspace_probe_create(probe_location);
        ok(event_rule, "kprobe event rule object creation");
 
-       event_rule_status = lttng_event_rule_userspace_probe_set_location(
-                       event_rule, probe_location);
-       ok(event_rule_status == LTTNG_EVENT_RULE_STATUS_OK,
-                       "Setting uprobe event rule location");
-
-       event_rule_status = lttng_event_rule_userspace_probe_set_name(
+       event_rule_status = lttng_event_rule_userspace_probe_set_event_name(
                        event_rule, trigger_name);
        ok(event_rule_status == LTTNG_EVENT_RULE_STATUS_OK,
                        "Setting uprobe event rule name: '%s'", trigger_name);
 
-       condition = lttng_condition_on_event_create(event_rule);
+       condition = lttng_condition_event_rule_matches_create(event_rule);
        ok(condition, "Condition event rule object creation");
 
        /* Register the trigger for condition. */
@@ -1996,12 +1979,8 @@ static void test_uprobe_event_rule_notification(
                goto end;
        }
 
-       trigger_status = lttng_trigger_set_name(trigger, trigger_name);
-       ok(trigger_status == LTTNG_TRIGGER_STATUS_OK,
-                       "Setting name to trigger '%s'", trigger_name);
-
-       ret = lttng_register_trigger(trigger);
-       if (ret) {
+       ret_code = lttng_register_trigger_with_name(trigger, trigger_name);
+       if (ret_code != LTTNG_OK) {
                fail("Failed to register trigger with userspace probe event rule condition and notify action");
                goto end;
        }
@@ -2048,10 +2027,10 @@ static void test_syscall_event_rule_notification(
                enum lttng_domain_type domain_type)
 {
        int i, ret;
+       enum lttng_error_code ret_code;
        const int notification_count = 3;
        enum lttng_notification_channel_status nc_status;
        enum lttng_event_rule_status event_rule_status;
-       enum lttng_trigger_status trigger_status;
        struct lttng_notification_channel *notification_channel = NULL;
        struct lttng_condition *condition = NULL;
        struct lttng_event_rule *event_rule = NULL;
@@ -2070,7 +2049,7 @@ static void test_syscall_event_rule_notification(
                        lttng_session_daemon_notification_endpoint);
        ok(notification_channel, "Notification channel object creation");
 
-       event_rule = lttng_event_rule_syscall_create();
+       event_rule = lttng_event_rule_syscall_create(LTTNG_EVENT_RULE_SYSCALL_EMISSION_SITE_ENTRY);
        ok(event_rule, "syscall event rule object creation");
 
        event_rule_status = lttng_event_rule_syscall_set_pattern(
@@ -2078,7 +2057,7 @@ static void test_syscall_event_rule_notification(
        ok(event_rule_status == LTTNG_EVENT_RULE_STATUS_OK,
                        "Setting syscall event rule pattern: '%s'", syscall_name);
 
-       condition = lttng_condition_on_event_create(event_rule);
+       condition = lttng_condition_event_rule_matches_create(event_rule);
        ok(condition, "Condition syscall event rule object creation");
 
        /* Register the trigger for condition. */
@@ -2088,12 +2067,8 @@ static void test_syscall_event_rule_notification(
                goto end;
        }
 
-       trigger_status = lttng_trigger_set_name(trigger, trigger_name);
-       ok(trigger_status == LTTNG_TRIGGER_STATUS_OK,
-                       "Setting name to trigger '%s'", trigger_name);
-
-       ret = lttng_register_trigger(trigger);
-       if (ret) {
+       ret_code = lttng_register_trigger_with_name(trigger, trigger_name);
+       if (ret_code != LTTNG_OK) {
                fail("Failed to register trigger with syscall event rule condition and notify action");
                goto end;
        }
@@ -2137,10 +2112,10 @@ static void test_syscall_event_rule_notification_filter(
                enum lttng_domain_type domain_type)
 {
        int i, ret;
+       enum lttng_error_code ret_code;
        const int notification_count = 3;
        enum lttng_notification_channel_status nc_status;
        enum lttng_event_rule_status event_rule_status;
-       enum lttng_trigger_status trigger_status;
        struct lttng_notification_channel *notification_channel = NULL;
        struct lttng_condition *condition = NULL;
        struct lttng_event_rule *event_rule = NULL;
@@ -2160,7 +2135,7 @@ static void test_syscall_event_rule_notification_filter(
                        lttng_session_daemon_notification_endpoint);
        ok(notification_channel, "Notification channel object creation");
 
-       event_rule = lttng_event_rule_syscall_create();
+       event_rule = lttng_event_rule_syscall_create(LTTNG_EVENT_RULE_SYSCALL_EMISSION_SITE_ENTRY);
        ok(event_rule, "syscall event rule object creation");
 
        event_rule_status = lttng_event_rule_syscall_set_pattern(
@@ -2173,7 +2148,7 @@ static void test_syscall_event_rule_notification_filter(
        ok(event_rule_status == LTTNG_EVENT_RULE_STATUS_OK,
                        "Setting filter: '%s'", filter_pattern);
 
-       condition = lttng_condition_on_event_create(event_rule);
+       condition = lttng_condition_event_rule_matches_create(event_rule);
        ok(condition, "Condition event rule object creation");
 
        /* Register the triggers for condition */
@@ -2183,12 +2158,8 @@ static void test_syscall_event_rule_notification_filter(
                goto end;
        }
 
-       trigger_status = lttng_trigger_set_name(trigger, trigger_name);
-       ok(trigger_status == LTTNG_TRIGGER_STATUS_OK,
-                       "Setting name to trigger '%s'", trigger_name);
-
-       ret = lttng_register_trigger(trigger);
-       if (ret) {
+       ret_code = lttng_register_trigger_with_name(trigger, trigger_name);
+       if (ret_code != LTTNG_OK) {
                fail("Failed to register trigger with syscall filtering event rule condition and notify action");
                goto end;
        }
@@ -2288,7 +2259,7 @@ static int generate_capture_descr(struct lttng_condition *condition)
                        goto end;
                }
 
-               cond_status = lttng_condition_on_event_append_capture_descriptor(
+               cond_status = lttng_condition_event_rule_matches_append_capture_descriptor(
                                condition, expr);
                if (cond_status != LTTNG_CONDITION_STATUS_OK) {
                        fail("Failed to append capture descriptor");
@@ -2311,7 +2282,8 @@ static int validator_notification_trigger_capture(
 {
        int ret;
        unsigned int capture_count, i;
-       enum lttng_evaluation_status evaluation_status;
+       enum lttng_evaluation_event_rule_matches_status
+                       event_rule_matches_evaluation_status;
        enum lttng_event_field_value_status event_field_value_status;
        const struct lttng_evaluation *evaluation;
        const struct lttng_event_field_value *captured_fields;
@@ -2324,11 +2296,13 @@ static int validator_notification_trigger_capture(
                goto end;
        }
 
-       evaluation_status = lttng_evaluation_on_event_get_captured_values(
-                       evaluation, &captured_fields);
-       if (evaluation_status != LTTNG_EVALUATION_STATUS_OK) {
+       event_rule_matches_evaluation_status =
+                       lttng_evaluation_event_rule_matches_get_captured_values(
+                                       evaluation, &captured_fields);
+       if (event_rule_matches_evaluation_status !=
+                       LTTNG_EVALUATION_EVENT_RULE_MATCHES_STATUS_OK) {
                diag("Failed to get event rule evaluation captured values: status = %d",
-                               (int) evaluation_status);
+                               (int) event_rule_matches_evaluation_status);
                ret = 1;
                goto end;
        }
@@ -2514,7 +2488,7 @@ int main(int argc, const char *argv[])
        switch (test_scenario) {
        case 1:
        {
-               plan_tests(44);
+               plan_tests(41);
 
                /* Test cases that need gen-ust-event testapp. */
                diag("Test basic notification error paths for %s domain",
@@ -2580,7 +2554,7 @@ int main(int argc, const char *argv[])
                 * Test cases that need a test app with more than one event
                 * type.
                 */
-               plan_tests(25);
+               plan_tests(23);
 
                /*
                 * At the moment, the only test case of this scenario is
@@ -2628,7 +2602,7 @@ int main(int argc, const char *argv[])
        {
                const char *testapp_path, *test_symbol_name;
 
-               plan_tests(13);
+               plan_tests(12);
 
                if (argc < 7) {
                        fail("Missing parameter for tests to run %d", argc);
@@ -2652,7 +2626,7 @@ int main(int argc, const char *argv[])
        {
                switch(domain_type) {
                case LTTNG_DOMAIN_UST:
-                       plan_tests(222);
+                       plan_tests(221);
                        break;
                case LTTNG_DOMAIN_KERNEL:
                        plan_tests(216);
This page took 0.028441 seconds and 4 git commands to generate.