From: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Date: Tue, 14 Jul 2015 15:33:41 +0000 (-0400)
Subject: Fix: Follow struct dirent allocation guidelines of READDIR(3)
X-Git-Tag: v2.6.1~94
X-Git-Url: https://git.liburcu.org/?a=commitdiff_plain;h=dc5141b9bf8323b45582c255fd3afd541fa63e14;p=lttng-tools.git

Fix: Follow struct dirent allocation guidelines of READDIR(3)

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
---

diff --git a/src/common/config/config.c b/src/common/config/config.c
index 9b78e1778..35d9bb254 100644
--- a/src/common/config/config.c
+++ b/src/common/config/config.c
@@ -2458,6 +2458,23 @@ end:
 	return ret;
 }
 
+/* Allocate dirent as recommended by READDIR(3), NOTES on readdir_r */
+static
+struct dirent *alloc_dirent(const char *path)
+{
+	size_t len;
+	long name_max;
+	struct dirent *entry;
+
+	name_max = pathconf(path, _PC_NAME_MAX);
+	if (name_max == -1) {
+		name_max = PATH_MAX;
+	}
+	len = offsetof(struct dirent, d_name) + name_max + 1;
+	entry = zmalloc(len);
+	return entry;
+}
+
 static
 int load_session_from_path(const char *path, const char *session_name,
 	struct session_config_validation_ctx *validation_ctx, int override)
@@ -2493,7 +2510,7 @@ int load_session_from_path(const char *path, const char *session_name,
 			goto end;
 		}
 
-		entry = zmalloc(sizeof(*entry));
+		entry = alloc_dirent(path);
 		if (!entry) {
 			ret = -LTTNG_ERR_NOMEM;
 			goto end;