From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date: Tue, 5 Apr 2016 13:26:51 +0000 (-0400)
Subject: Fix: Remove dead code from filter interpreter
X-Git-Tag: v2.8.0-rc2~7
X-Git-Url: https://git.liburcu.org/?a=commitdiff_plain;h=310dd967fbdf35dbfae5ea1e1f16cfc543536376;p=lttng-modules.git

Fix: Remove dead code from filter interpreter

Detected by Coverity:
** CID 1353794:  Control flow issues  (DEADCODE)
/lttng-filter-interpreter.c: 123 in stack_strcmp()

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
---

diff --git a/lttng-filter-interpreter.c b/lttng-filter-interpreter.c
index 8323fbbb..c7e9f1f1 100644
--- a/lttng-filter-interpreter.c
+++ b/lttng-filter-interpreter.c
@@ -119,21 +119,16 @@ int stack_strcmp(struct estack *stack, int top, const char *cmp_type)
 			}
 		}
 		if (unlikely(char_ax == '\0')) {
-			if (char_bx == '\0') {
-				diff = 0;
-				break;
-			} else {
-				if (estack_bx(stack, top)->u.s.literal) {
-					ret = parse_char(estack_bx(stack, top),
-						&char_bx, &offset_bx);
-					if (ret == -1) {
-						diff = 0;
-						break;
-					}
+			if (estack_bx(stack, top)->u.s.literal) {
+				ret = parse_char(estack_bx(stack, top),
+					&char_bx, &offset_bx);
+				if (ret == -1) {
+					diff = 0;
+					break;
 				}
-				diff = 1;
-				break;
 			}
+			diff = 1;
+			break;
 		}
 		if (estack_bx(stack, top)->u.s.literal) {
 			ret = parse_char(estack_bx(stack, top),