X-Git-Url: https://git.liburcu.org/?a=blobdiff_plain;f=urcu.c;h=9542b264a6dbf53d36d2fb63e7578b4e7ff2b2f5;hb=9598a4814c854780e9ca9bb2cfff8d77442c3db6;hp=d4a06844885cde3da2d03092e3e9c45a939e0438;hpb=128166c908bfaa915c76e060522abd20241ac69c;p=urcu.git

diff --git a/urcu.c b/urcu.c
index d4a0684..9542b26 100644
--- a/urcu.c
+++ b/urcu.c
@@ -74,6 +74,12 @@ static void switch_next_urcu_qparity(void)
 	urcu_gp_ctr ^= RCU_GP_CTR_BIT;
 }
 
+#ifdef DEBUG_FULL_MB
+static void force_mb_all_threads(void)
+{
+	mb();
+}
+#else
 static void force_mb_all_threads(void)
 {
 	struct reader_data *index;
@@ -102,6 +108,7 @@ static void force_mb_all_threads(void)
 	mb();	/* read sig_done before ending the barrier */
 	debug_yield_write();
 }
+#endif
 
 void wait_for_quiescent_state(void)
 {
@@ -118,41 +125,70 @@ void wait_for_quiescent_state(void)
 		while (rcu_old_gp_ongoing(index->urcu_active_readers))
 			barrier();
 	}
-	/*
-	 * Locally : read *index->urcu_active_readers before freeing old
-	 * pointer.
-	 * Remote (reader threads) : Order urcu_qparity update and other
-	 * thread's quiescent state counter read.
-	 */
-	force_mb_all_threads();
 }
 
-static void switch_qparity(void)
+void synchronize_rcu(void)
 {
-	/* All threads should read qparity before accessing data structure. */
-	/* Write ptr before changing the qparity */
+	/* All threads should read qparity before accessing data structure
+	 * where new ptr points to. */
+	/* Write new ptr before changing the qparity */
 	force_mb_all_threads();
 	debug_yield_write();
-	switch_next_urcu_qparity();
+
+	internal_urcu_lock();
+	debug_yield_write();
+
+	switch_next_urcu_qparity();	/* 0 -> 1 */
 	debug_yield_write();
 
 	/*
-	 * Wait for previous parity to be empty of readers.
+	 * Must commit qparity update to memory before waiting for parity
+	 * 0 quiescent state. Failure to do so could result in the writer
+	 * waiting forever while new readers are always accessing data (no
+	 * progress).
 	 */
-	wait_for_quiescent_state();
-}
+	mb();
 
-void synchronize_rcu(void)
-{
-	debug_yield_write();
-	internal_urcu_lock();
+	/*
+	 * Wait for previous parity to be empty of readers.
+	 */
+	wait_for_quiescent_state();	/* Wait readers in parity 0 */
 	debug_yield_write();
-	switch_qparity();
+
+	/*
+	 * Must finish waiting for quiescent state for parity 0 before
+	 * committing qparity update to memory. Failure to do so could result in
+	 * the writer waiting forever while new readers are always accessing
+	 * data (no progress).
+	 */
+	mb();
+
+	switch_next_urcu_qparity();	/* 1 -> 0 */
 	debug_yield_write();
-	switch_qparity();
+
+	/*
+	 * Must commit qparity update to memory before waiting for parity
+	 * 1 quiescent state. Failure to do so could result in the writer
+	 * waiting forever while new readers are always accessing data (no
+	 * progress).
+	 */
+	mb();
+
+	/*
+	 * Wait for previous parity to be empty of readers.
+	 */
+	wait_for_quiescent_state();	/* Wait readers in parity 1 */
 	debug_yield_write();
+
 	internal_urcu_unlock();
 	debug_yield_write();
+
+	/* All threads should finish using the data referred to by old ptr
+	 * before decrementing their urcu_active_readers count */
+	/* Finish waiting for reader threads before letting the old ptr being
+	 * freed. */
+	force_mb_all_threads();
+	debug_yield_write();
 }
 
 void urcu_add_reader(pthread_t id)
@@ -217,6 +253,7 @@ void urcu_unregister_thread(void)
 	internal_urcu_unlock();
 }
 
+#ifndef DEBUG_FULL_MB
 void sigurcu_handler(int signo, siginfo_t *siginfo, void *context)
 {
 	mb();
@@ -249,3 +286,4 @@ void __attribute__((destructor)) urcu_exit(void)
 	assert(act.sa_sigaction == sigurcu_handler);
 	free(reader_data);
 }
+#endif