X-Git-Url: https://git.liburcu.org/?a=blobdiff_plain;f=urcu-qsbr.c;h=4da10d6121e3d6518315e601c40ced1ec284875b;hb=b6953cd76fe3068c601059879924a6afca76b10f;hp=ccecab4e7b02b63d80f6c87085486dee0a5452f5;hpb=727f819de5737f4be5b9f7e50aacf84c7a3f7999;p=urcu.git

diff --git a/urcu-qsbr.c b/urcu-qsbr.c
index ccecab4..4da10d6 100644
--- a/urcu-qsbr.c
+++ b/urcu-qsbr.c
@@ -106,11 +106,6 @@ static void force_mb_single_thread(struct reader_registry *index)
 }
 #endif /* #ifdef HAS_INCOHERENT_CACHES */
 
-static void force_mb_all_threads(void)
-{
-	smp_mb();
-}
-
 static void wait_for_quiescent_state(void)
 {
 	struct reader_registry *index;
@@ -122,8 +117,7 @@ static void wait_for_quiescent_state(void)
 	 */
 	for (index = registry; index < registry + num_readers; index++) {
 #ifndef HAS_INCOHERENT_CACHES
-		while (rcu_gp_ongoing(index->rcu_reader_qs_gp) &&
-		       (*index->rcu_reader_qs_gp - urcu_gp_ctr < 0))
+		while (rcu_gp_ongoing(index->rcu_reader_qs_gp))
 			cpu_relax();
 #else /* #ifndef HAS_INCOHERENT_CACHES */
 		int wait_loops = 0;
@@ -131,8 +125,7 @@ static void wait_for_quiescent_state(void)
 		 * BUSY-LOOP. Force the reader thread to commit its
 		 * rcu_reader_qs_gp update to memory if we wait for too long.
 		 */
-		while (rcu_gp_ongoing(index->rcu_reader_qs_gp) &&
-		       (*index->rcu_reader_qs_gp - urcu_gp_ctr < 0)) {
+		while (rcu_gp_ongoing(index->rcu_reader_qs_gp)) {
 			if (wait_loops++ == KICK_READER_LOOPS) {
 				force_mb_single_thread(index);
 				wait_loops = 0;
@@ -158,12 +151,12 @@ void synchronize_rcu(void)
 	if (was_online)
 		_rcu_thread_offline();
 
+	smp_mb();
 	internal_urcu_lock();
-	force_mb_all_threads();
-	urcu_gp_ctr += 2;
+	STORE_SHARED(urcu_gp_ctr, urcu_gp_ctr + 2);
 	wait_for_quiescent_state();
-	force_mb_all_threads();
 	internal_urcu_unlock();
+	smp_mb();
 
 	if (was_online)
 		_rcu_thread_online();