X-Git-Url: https://git.liburcu.org/?a=blobdiff_plain;f=src%2Fcommon%2Funix.c;h=141e85233ed7dea5c4a2c8b4deb1cab0dbafb72a;hb=52cf181f441bb969ca20d8a444281d66d7e60271;hp=d37313c5aed87ee6600b1953ce6ba84a97d6f660;hpb=6380c001e51ad337ca283c36b59408bda59afe84;p=lttng-tools.git

diff --git a/src/common/unix.c b/src/common/unix.c
index d37313c5a..141e85233 100644
--- a/src/common/unix.c
+++ b/src/common/unix.c
@@ -220,6 +220,9 @@ ssize_t lttcomm_recv_unix_sock(int sock, void *buf, size_t len)
  * Receive data of size len in put that data into the buf param. Using recvmsg
  * API. Only use with sockets set in non-blocking mode.
  *
+ * NOTE: EPIPE errors are NOT reported. This call expects the socket to be in a
+ * poll set. The poll loop will handle the EPIPE original cause.
+ *
  * Return the size of received data.
  */
 LTTNG_HIDDEN
@@ -243,17 +246,24 @@ retry:
 			goto retry;
 		} else {
 			/*
-			 * Only warn about EPIPE when quiet mode is
-			 * deactivated.
-			 * We consider EPIPE as expected.
+			 * We consider EPIPE and EAGAIN/EWOULDBLOCK as expected.
 			 */
-			if (errno != EPIPE || !lttng_opt_quiet) {
-				PERROR("recvmsg");
+			if (errno == EAGAIN || errno == EWOULDBLOCK ||
+					errno == EPIPE) {
+				/*
+				 * Nothing was recv.
+				 */
+				ret = 0;
+				goto end;
 			}
+
+			/* Unexpected error */
+			PERROR("recvmsg");
+			ret = -1;
 			goto end;
 		}
 	}
-	ret = len;
+
 end:
 	return ret;
 }
@@ -308,6 +318,9 @@ end:
  * of the function is that this one does not retry to send on partial sends,
  * except if the interruption was caused by a signal (EINTR).
  *
+ * NOTE: EPIPE errors are NOT reported. This call expects the socket to be in a
+ * poll set. The poll loop will handle the EPIPE original cause.
+ *
  * Return the size of sent data.
  */
 LTTNG_HIDDEN
@@ -331,17 +344,24 @@ retry:
 			goto retry;
 		} else {
 			/*
-			 * Only warn about EPIPE when quiet mode is
-			 * deactivated.
-			 * We consider EPIPE as expected.
+			 * We consider EPIPE and EAGAIN/EWOULDBLOCK as expected.
 			 */
-			if (errno != EPIPE || !lttng_opt_quiet) {
-				PERROR("sendmsg");
+			if (errno == EAGAIN || errno == EWOULDBLOCK ||
+					errno == EPIPE) {
+				/*
+				 * This can happen in non blocking mode.
+				 * Nothing was sent.
+				 */
+				ret = 0;
+				goto end;
 			}
+
+			/* Unexpected error */
+			PERROR("sendmsg");
+			ret = -1;
 			goto end;
 		}
 	}
-	ret = len;
 end:
 	return ret;
 }