X-Git-Url: https://git.liburcu.org/?a=blobdiff_plain;f=src%2Fbin%2Flttng-sessiond%2Fclient.cpp;h=a52062e07f877ddc08ccf84604a56c5f2ff1fd59;hb=de5abcb02431896a1827dff5d3376e1f2e124cd7;hp=46f524896ed2dd82e1a1ced94cff9092b937a8c2;hpb=999af9c1150784f8676c6fce0764772d2314854a;p=lttng-tools.git

diff --git a/src/bin/lttng-sessiond/client.cpp b/src/bin/lttng-sessiond/client.cpp
index 46f524896..a52062e07 100644
--- a/src/bin/lttng-sessiond/client.cpp
+++ b/src/bin/lttng-sessiond/client.cpp
@@ -7,25 +7,25 @@
  *
  */
 
-#include "common/buffer-view.h"
-#include "common/compat/socket.h"
-#include "common/dynamic-array.h"
-#include "common/dynamic-buffer.h"
-#include "common/fd-handle.h"
-#include "common/payload-view.h"
-#include "common/payload.h"
-#include "common/sessiond-comm/sessiond-comm.h"
+#include "common/buffer-view.hpp"
+#include "common/compat/socket.hpp"
+#include "common/dynamic-array.hpp"
+#include "common/dynamic-buffer.hpp"
+#include "common/fd-handle.hpp"
+#include "common/payload-view.hpp"
+#include "common/payload.hpp"
+#include "common/sessiond-comm/sessiond-comm.hpp"
 #include "lttng/lttng-error.h"
 #include "lttng/tracker.h"
-#include <common/compat/getenv.h>
-#include <common/tracker.h>
-#include <common/unix.h>
-#include <common/utils.h>
-#include <lttng/error-query-internal.h>
-#include <lttng/event-internal.h>
-#include <lttng/session-descriptor-internal.h>
-#include <lttng/session-internal.h>
-#include <lttng/userspace-probe-internal.h>
+#include <common/compat/getenv.hpp>
+#include <common/tracker.hpp>
+#include <common/unix.hpp>
+#include <common/utils.hpp>
+#include <lttng/error-query-internal.hpp>
+#include <lttng/event-internal.hpp>
+#include <lttng/session-descriptor-internal.hpp>
+#include <lttng/session-internal.hpp>
+#include <lttng/userspace-probe-internal.hpp>
 #include <pthread.h>
 #include <signal.h>
 #include <stddef.h>
@@ -33,25 +33,27 @@
 #include <sys/stat.h>
 #include <unistd.h>
 
-#include "agent-thread.h"
-#include "clear.h"
-#include "client.h"
-#include "cmd.h"
-#include "health-sessiond.h"
-#include "kernel.h"
-#include "lttng-sessiond.h"
-#include "manage-consumer.h"
-#include "save.h"
-#include "testpoint.h"
-#include "utils.h"
-
-static bool is_root;
-
-static struct thread_state {
+#include "agent-thread.hpp"
+#include "clear.hpp"
+#include "client.hpp"
+#include "cmd.hpp"
+#include "health-sessiond.hpp"
+#include "kernel.hpp"
+#include "lttng-sessiond.hpp"
+#include "manage-consumer.hpp"
+#include "save.hpp"
+#include "testpoint.hpp"
+#include "utils.hpp"
+
+namespace {
+bool is_root;
+
+struct thread_state {
 	sem_t ready;
 	bool running;
 	int client_sock;
 } thread_state;
+} /* namespace */
 
 static void set_thread_status(bool running)
 {
@@ -264,7 +266,7 @@ static pid_t spawn_consumerd(struct consumer_data *consumer_data)
 					tmp = "";
 				}
 				tmplen = strlen(the_config.consumerd64_lib_dir.value) + 1 /* : */ + strlen(tmp);
-				tmpnew = (char *) zmalloc(tmplen + 1 /* \0 */);
+				tmpnew = zmalloc<char>(tmplen + 1 /* \0 */);
 				if (!tmpnew) {
 					ret = -ENOMEM;
 					goto error;
@@ -306,7 +308,7 @@ static pid_t spawn_consumerd(struct consumer_data *consumer_data)
 					tmp = "";
 				}
 				tmplen = strlen(the_config.consumerd32_lib_dir.value) + 1 /* : */ + strlen(tmp);
-				tmpnew = (char *) zmalloc(tmplen + 1 /* \0 */);
+				tmpnew = zmalloc<char>(tmplen + 1 /* \0 */);
 				if (!tmpnew) {
 					ret = -ENOMEM;
 					goto error;
@@ -583,7 +585,8 @@ error_create:
 /*
  * Count number of session permitted by uid/gid.
  */
-static unsigned int lttng_sessions_count(uid_t uid, gid_t gid)
+static unsigned int lttng_sessions_count(uid_t uid,
+		gid_t gid __attribute__((unused)))
 {
 	unsigned int i = 0;
 	struct ltt_session *session;
@@ -606,103 +609,6 @@ static unsigned int lttng_sessions_count(uid_t uid, gid_t gid)
 	return i;
 }
 
-static int receive_userspace_probe(struct command_ctx *cmd_ctx, int sock,
-		int *sock_error, struct lttng_event *event)
-{
-	int fd = -1, ret;
-	struct lttng_userspace_probe_location *probe_location;
-	struct lttng_payload probe_location_payload;
-	struct fd_handle *handle = NULL;
-
-	/*
-	 * Create a payload to store the serialized version of the probe
-	 * location.
-	 */
-	lttng_payload_init(&probe_location_payload);
-
-	ret = lttng_dynamic_buffer_set_size(&probe_location_payload.buffer,
-			cmd_ctx->lsm.u.enable.userspace_probe_location_len);
-	if (ret) {
-		ret = LTTNG_ERR_NOMEM;
-		goto error;
-	}
-
-	/*
-	 * Receive the probe location.
-	 */
-	ret = lttcomm_recv_unix_sock(sock, probe_location_payload.buffer.data,
-			probe_location_payload.buffer.size);
-	if (ret <= 0) {
-		DBG("Nothing recv() from client var len data... continuing");
-		*sock_error = 1;
-		ret = LTTNG_ERR_PROBE_LOCATION_INVAL;
-		goto error;
-	}
-
-	/*
-	 * Receive the file descriptor to the target binary from the client.
-	 */
-	DBG("Receiving userspace probe target FD from client ...");
-	ret = lttcomm_recv_fds_unix_sock(sock, &fd, 1);
-	if (ret <= 0) {
-		DBG("Nothing recv() from client userspace probe fd... continuing");
-		*sock_error = 1;
-		ret = LTTNG_ERR_PROBE_LOCATION_INVAL;
-		goto error;
-	}
-
-	handle = fd_handle_create(fd);
-	if (!handle) {
-		ret = LTTNG_ERR_NOMEM;
-		goto error;
-	}
-
-	/* Transferred to the handle. */
-	fd = -1;
-
-	ret = lttng_payload_push_fd_handle(&probe_location_payload, handle);
-	if (ret) {
-		ERR("Failed to add userspace probe file descriptor to payload");
-		ret = LTTNG_ERR_NOMEM;
-		goto error;
-	}
-
-	fd_handle_put(handle);
-	handle = NULL;
-
-	{
-		struct lttng_payload_view view = lttng_payload_view_from_payload(
-			&probe_location_payload, 0, -1);
-
-		/* Extract the probe location from the serialized version. */
-		ret = lttng_userspace_probe_location_create_from_payload(
-				&view, &probe_location);
-	}
-	if (ret < 0) {
-		WARN("Failed to create a userspace probe location from the received buffer");
-		ret = LTTNG_ERR_PROBE_LOCATION_INVAL;
-		goto error;
-	}
-
-	/* Attach the probe location to the event. */
-	ret = lttng_event_set_userspace_probe_location(event, probe_location);
-	if (ret) {
-		ret = LTTNG_ERR_PROBE_LOCATION_INVAL;
-		goto error;
-	}
-
-error:
-	if (fd >= 0) {
-		if (close(fd)) {
-			PERROR("Failed to close userspace probe location binary fd");
-		}
-	}
-
-	fd_handle_put(handle);
-	lttng_payload_reset(&probe_location_payload);
-	return ret;
-}
-
 static enum lttng_error_code receive_lttng_trigger(struct command_ctx *cmd_ctx,
 		int sock,
 		int *sock_error,
@@ -847,6 +753,178 @@ end:
 	return ret_code;
 }
 
+static enum lttng_error_code receive_lttng_event(struct command_ctx *cmd_ctx,
+		int sock,
+		int *sock_error,
+		struct lttng_event **out_event,
+		char **out_filter_expression,
+		struct lttng_bytecode **out_bytecode,
+		struct lttng_event_exclusion **out_exclusion)
+{
+	int ret;
+	size_t event_len;
+	ssize_t sock_recv_len;
+	enum lttng_error_code ret_code;
+	struct lttng_payload event_payload;
+	struct lttng_event *local_event = NULL;
+	char *local_filter_expression = NULL;
+	struct lttng_bytecode *local_bytecode = NULL;
+	struct lttng_event_exclusion *local_exclusion = NULL;
+
+	lttng_payload_init(&event_payload);
+	if (cmd_ctx->lsm.cmd_type == LTTNG_ENABLE_EVENT) {
+		event_len = (size_t) cmd_ctx->lsm.u.enable.length;
+	} else if (cmd_ctx->lsm.cmd_type == LTTNG_DISABLE_EVENT) {
+		event_len = (size_t) cmd_ctx->lsm.u.disable.length;
+	} else {
+		abort();
+	}
+
+	ret = lttng_dynamic_buffer_set_size(&event_payload.buffer, event_len);
+	if (ret) {
+		ret_code = LTTNG_ERR_NOMEM;
+		goto end;
+	}
+
+	sock_recv_len = lttcomm_recv_unix_sock(
+			sock, event_payload.buffer.data, event_len);
+	if (sock_recv_len < 0 || sock_recv_len != event_len) {
+		ERR("Failed to receive event in command payload");
+		*sock_error = 1;
+		ret_code = LTTNG_ERR_INVALID_PROTOCOL;
+		goto end;
+	}
+
+	/* Receive fds, if any. */
+	if (cmd_ctx->lsm.fd_count > 0) {
+		sock_recv_len = lttcomm_recv_payload_fds_unix_sock(
+				sock, cmd_ctx->lsm.fd_count, &event_payload);
+		if (sock_recv_len > 0 &&
+				sock_recv_len != cmd_ctx->lsm.fd_count * sizeof(int)) {
+			ERR("Failed to receive all file descriptors for event in command payload: expected fd count = %u, ret = %d",
+					cmd_ctx->lsm.fd_count, (int) ret);
+			ret_code = LTTNG_ERR_INVALID_PROTOCOL;
+			*sock_error = 1;
+			goto end;
+		} else if (sock_recv_len <= 0) {
+			ERR("Failed to receive file descriptors for event in command payload: expected fd count = %u, ret = %d",
+					cmd_ctx->lsm.fd_count, (int) ret);
+			ret_code = LTTNG_ERR_FATAL;
+			*sock_error = 1;
+			goto end;
+		}
+	}
+
+	/* Deserialize event. */
+	{
+		ssize_t len;
+		struct lttng_payload_view event_view =
+				lttng_payload_view_from_payload(
+						&event_payload, 0, -1);
+
+		len = lttng_event_create_from_payload(&event_view, &local_event,
+				    &local_exclusion, &local_filter_expression,
+				    &local_bytecode);
+
+		if (len < 0) {
+			ERR("Failed to create an event from the received buffer");
+			ret_code = LTTNG_ERR_INVALID_PROTOCOL;
+			goto end;
+		}
+
+		if (len != event_len) {
+			ERR("Userspace probe location from the received buffer is not the advertised length: header length = %zu" PRIu32 ", payload length = %zd", event_len, len);
+			ret_code = LTTNG_ERR_INVALID_PROTOCOL;
+			goto end;
+		}
+	}
+
+	*out_event = local_event;
+	*out_exclusion = local_exclusion;
+	*out_filter_expression = local_filter_expression;
+	*out_bytecode = local_bytecode;
+	local_event = NULL;
+	local_exclusion = NULL;
+	local_filter_expression = NULL;
+	local_bytecode = NULL;
+
+	ret_code = LTTNG_OK;
+
+end:
+	lttng_payload_reset(&event_payload);
+	lttng_event_destroy(local_event);
+	free(local_filter_expression);
+	free(local_bytecode);
+	free(local_exclusion);
+	return ret_code;
+}
+
+static enum lttng_error_code receive_lttng_event_context(
+		const struct command_ctx *cmd_ctx,
+		int sock,
+		int *sock_error,
+		struct lttng_event_context **out_event_context)
+{
+	int ret;
+	const size_t event_context_len =
+			(size_t) cmd_ctx->lsm.u.context.length;
+	ssize_t sock_recv_len;
+	enum lttng_error_code ret_code;
+	struct lttng_payload event_context_payload;
+	struct lttng_event_context *context = NULL;
+
+	lttng_payload_init(&event_context_payload);
+
+	ret = lttng_dynamic_buffer_set_size(&event_context_payload.buffer,
+			event_context_len);
+	if (ret) {
+		ret_code = LTTNG_ERR_NOMEM;
+		goto end;
+	}
+
+	sock_recv_len = lttcomm_recv_unix_sock(
+			sock, event_context_payload.buffer.data,
+			event_context_len);
+	if (sock_recv_len < 0 || sock_recv_len != event_context_len) {
+		ERR("Failed to receive event context in command payload");
+		*sock_error = 1;
+		ret_code = LTTNG_ERR_INVALID_PROTOCOL;
+		goto end;
+	}
+
+	/* Deserialize event. */
+	{
+		ssize_t len;
+		struct lttng_payload_view event_context_view =
+				lttng_payload_view_from_payload(
+						&event_context_payload, 0, -1);
+
+		len = lttng_event_context_create_from_payload(
+				&event_context_view, &context);
+
+		if (len < 0) {
+			ERR("Failed to create a event context from the received buffer");
+			ret_code = LTTNG_ERR_INVALID_PROTOCOL;
+			goto end;
+		}
+
+		if (len != event_context_len) {
+			ERR("Event context from the received buffer is not the advertised length: expected length = %zu, payload length = %zd", event_context_len, len);
+			ret_code = LTTNG_ERR_INVALID_PROTOCOL;
+			goto end;
+		}
+	}
+
+	*out_event_context = context;
+	context = NULL;
+	ret_code = LTTNG_OK;
+
+end:
+	lttng_event_context_destroy(context);
+	lttng_payload_reset(&event_context_payload);
+	return ret_code;
+}
+
 /*
  * Version of setup_lttng_msg() without command header.
  */
@@ -1316,77 +1394,18 @@ skip_domain:
 	switch (cmd_ctx->lsm.cmd_type) {
 	case LTTNG_ADD_CONTEXT:
 	{
-		lttng_event_context ctx;
-
-		/*
-		 * An LTTNG_ADD_CONTEXT command might have a supplementary
-		 * payload if the context being added is an application context.
-		 */
-		if (cmd_ctx->lsm.u.context.ctx.ctx ==
-				LTTNG_EVENT_CONTEXT_APP_CONTEXT) {
-			char *provider_name = NULL, *context_name = NULL;
-			size_t provider_name_len =
-					cmd_ctx->lsm.u.context.provider_name_len;
-			size_t context_name_len =
-					cmd_ctx->lsm.u.context.context_name_len;
-
-			if (provider_name_len == 0 || context_name_len == 0) {
-				/*
-				 * Application provider and context names MUST
-				 * be provided.
-				 */
-				ret = -LTTNG_ERR_INVALID;
-				goto error;
-			}
-
-			provider_name = (char *) zmalloc(provider_name_len + 1);
-			if (!provider_name) {
-				ret = -LTTNG_ERR_NOMEM;
-				goto error;
-			}
-			cmd_ctx->lsm.u.context.ctx.u.app_ctx.provider_name =
-					provider_name;
-
-			context_name = (char *) zmalloc(context_name_len + 1);
-			if (!context_name) {
-				ret = -LTTNG_ERR_NOMEM;
-				goto error_add_context;
-			}
-			cmd_ctx->lsm.u.context.ctx.u.app_ctx.ctx_name =
-					context_name;
-
-			ret = lttcomm_recv_unix_sock(*sock, provider_name,
-					provider_name_len);
-			if (ret < 0) {
-				goto error_add_context;
-			}
-
-			ret = lttcomm_recv_unix_sock(*sock, context_name,
-					context_name_len);
-			if (ret < 0) {
-				goto error_add_context;
-			}
-		}
+		struct lttng_event_context *event_context = NULL;
+		const enum lttng_error_code ret_code =
+			receive_lttng_event_context(
+				cmd_ctx, *sock, sock_error, &event_context);
 
-		/*
-		 * cmd_add_context assumes ownership of the provider and context
-		 * names.
-		 */
-		ctx = cmd_ctx->lsm.u.context.ctx;
-		ret = cmd_add_context(cmd_ctx->session,
-				cmd_ctx->lsm.domain.type,
-				cmd_ctx->lsm.u.context.channel_name,
-				&ctx,
-				the_kernel_poll_pipe[1]);
-
-		cmd_ctx->lsm.u.context.ctx.u.app_ctx.provider_name = NULL;
-		cmd_ctx->lsm.u.context.ctx.u.app_ctx.ctx_name = NULL;
-error_add_context:
-		free(cmd_ctx->lsm.u.context.ctx.u.app_ctx.provider_name);
-		free(cmd_ctx->lsm.u.context.ctx.u.app_ctx.ctx_name);
-		if (ret < 0) {
+		if (ret_code != LTTNG_OK) {
+			ret = (int) ret_code;
 			goto error;
 		}
+
+		ret = cmd_add_context(cmd_ctx, event_context, the_kernel_poll_pipe[1]);
+		lttng_event_context_destroy(event_context);
 		break;
 	}
 	case LTTNG_DISABLE_CHANNEL:
@@ -1395,42 +1414,6 @@ error_add_context:
 				cmd_ctx->lsm.u.disable.channel_name);
 		break;
 	}
-	case LTTNG_DISABLE_EVENT:
-	{
-		lttng_event event;
-
-		/*
-		 * FIXME: handle filter; for now we just receive the filter's
-		 * bytecode along with the filter expression which are sent by
-		 * liblttng-ctl and discard them.
-		 *
-		 * This fixes an issue where the client may block while sending
-		 * the filter payload and encounter an error because the session
-		 * daemon closes the socket without ever handling this data.
-		 */
-		size_t count = cmd_ctx->lsm.u.disable.expression_len +
-			cmd_ctx->lsm.u.disable.bytecode_len;
-
-		if (count) {
-			char data[LTTNG_FILTER_MAX_LEN];
-
-			DBG("Discarding disable event command payload of size %zu", count);
-			while (count) {
-				ret = lttcomm_recv_unix_sock(*sock, data,
-				        count > sizeof(data) ? sizeof(data) : count);
-				if (ret < 0) {
-					goto error;
-				}
-
-				count -= (size_t) ret;
-			}
-		}
-		event = cmd_ctx->lsm.u.disable.event;
-		ret = cmd_disable_event(cmd_ctx->session, cmd_ctx->lsm.domain.type,
-				cmd_ctx->lsm.u.disable.channel_name,
-				&event);
-		break;
-	}
 	case LTTNG_ENABLE_CHANNEL:
 	{
 		ret = cmd_enable_channel(
@@ -1637,229 +1620,123 @@ error_add_context:
 		break;
 	}
 	case LTTNG_ENABLE_EVENT:
+	case LTTNG_DISABLE_EVENT:
 	{
-		struct lttng_event *ev = NULL;
-		struct lttng_event_exclusion *exclusion = NULL;
-		struct lttng_bytecode *bytecode = NULL;
-		char *filter_expression = NULL;
-		lttng_event event;
-		lttng_domain domain;
-
-		/* Handle exclusion events and receive it from the client. */
-		if (cmd_ctx->lsm.u.enable.exclusion_count > 0) {
-			size_t count = cmd_ctx->lsm.u.enable.exclusion_count;
-
-			exclusion = (lttng_event_exclusion *) zmalloc(sizeof(struct lttng_event_exclusion) +
-					(count * LTTNG_SYMBOL_NAME_LEN));
-			if (!exclusion) {
-				ret = LTTNG_ERR_EXCLUSION_NOMEM;
-				goto error;
-			}
-
-			DBG("Receiving var len exclusion event list from client ...");
-			exclusion->count = count;
-			ret = lttcomm_recv_unix_sock(*sock, exclusion->names,
-					count * LTTNG_SYMBOL_NAME_LEN);
-			if (ret <= 0) {
-				DBG("Nothing recv() from client var len data... continuing");
-				*sock_error = 1;
-				free(exclusion);
-				ret = LTTNG_ERR_EXCLUSION_INVAL;
-				goto error;
-			}
-		}
-
-		/* Get filter expression from client. */
-		if (cmd_ctx->lsm.u.enable.expression_len > 0) {
-			size_t expression_len =
-				cmd_ctx->lsm.u.enable.expression_len;
+		struct lttng_event *event;
+		char *filter_expression;
+		struct lttng_event_exclusion *exclusions;
+		struct lttng_bytecode *bytecode;
+		const enum lttng_error_code ret_code = receive_lttng_event(
+				cmd_ctx, *sock, sock_error, &event,
+				&filter_expression, &bytecode, &exclusions);
 
-			if (expression_len > LTTNG_FILTER_MAX_LEN) {
-				ret = LTTNG_ERR_FILTER_INVAL;
-				free(exclusion);
-				goto error;
-			}
-
-			filter_expression = (char *) zmalloc(expression_len);
-			if (!filter_expression) {
-				free(exclusion);
-				ret = LTTNG_ERR_FILTER_NOMEM;
-				goto error;
-			}
-
-			/* Receive var. len. data */
-			DBG("Receiving var len filter's expression from client ...");
-			ret = lttcomm_recv_unix_sock(*sock, filter_expression,
-				expression_len);
-			if (ret <= 0) {
-				DBG("Nothing recv() from client var len data... continuing");
-				*sock_error = 1;
-				free(filter_expression);
-				free(exclusion);
-				ret = LTTNG_ERR_FILTER_INVAL;
-				goto error;
-			}
-		}
-
-		/* Handle filter and get bytecode from client. */
-		if (cmd_ctx->lsm.u.enable.bytecode_len > 0) {
-			size_t bytecode_len = cmd_ctx->lsm.u.enable.bytecode_len;
-
-			if (bytecode_len > LTTNG_FILTER_MAX_LEN) {
-				ret = LTTNG_ERR_FILTER_INVAL;
-				free(filter_expression);
-				free(exclusion);
-				goto error;
-			}
-
-			bytecode = (lttng_bytecode *) zmalloc(bytecode_len);
-			if (!bytecode) {
-				free(filter_expression);
-				free(exclusion);
-				ret = LTTNG_ERR_FILTER_NOMEM;
-				goto error;
-			}
-
-			/* Receive var. len. data */
-			DBG("Receiving var len filter's bytecode from client ...");
-			ret = lttcomm_recv_unix_sock(*sock, bytecode, bytecode_len);
-			if (ret <= 0) {
-				DBG("Nothing recv() from client var len data... continuing");
-				*sock_error = 1;
-				free(filter_expression);
-				free(bytecode);
-				free(exclusion);
-				ret = LTTNG_ERR_FILTER_INVAL;
-				goto error;
-			}
-
-			if ((bytecode->len + sizeof(*bytecode)) != bytecode_len) {
-				free(filter_expression);
-				free(bytecode);
-				free(exclusion);
-				ret = LTTNG_ERR_FILTER_INVAL;
-				goto error;
-			}
-		}
-
-		event = cmd_ctx->lsm.u.enable.event;
-		ev = lttng_event_copy(&event);
-		if (!ev) {
-			DBG("Failed to copy event: %s",
-					cmd_ctx->lsm.u.enable.event.name);
-			free(filter_expression);
-			free(bytecode);
-			free(exclusion);
-			ret = LTTNG_ERR_NOMEM;
+		if (ret_code != LTTNG_OK) {
+			ret = (int) ret_code;
 			goto error;
 		}
 
-
-		if (cmd_ctx->lsm.u.enable.userspace_probe_location_len > 0) {
-			/* Expect a userspace probe description. */
-			ret = receive_userspace_probe(cmd_ctx, *sock, sock_error, ev);
-			if (ret) {
-				free(filter_expression);
-				free(bytecode);
-				free(exclusion);
-				lttng_event_destroy(ev);
-				goto error;
-			}
-		}
-
-		domain = cmd_ctx->lsm.domain;
-		ret = cmd_enable_event(cmd_ctx->session,
-				&domain,
-				cmd_ctx->lsm.u.enable.channel_name,
-				ev,
-				filter_expression, bytecode, exclusion,
-				the_kernel_poll_pipe[1]);
-		lttng_event_destroy(ev);
+		/*
+		 * Ownership of filter_expression, exclusions, and bytecode is
+		 * always transferred.
+		 */
+		ret = cmd_ctx->lsm.cmd_type == LTTNG_ENABLE_EVENT ?
+				cmd_enable_event(cmd_ctx, event,
+						filter_expression, exclusions,
+						bytecode,
+						the_kernel_poll_pipe[1]) :
+				cmd_disable_event(cmd_ctx, event,
+						filter_expression, bytecode,
+						exclusions);
+		lttng_event_destroy(event);
 		break;
 	}
 	case LTTNG_LIST_TRACEPOINTS:
 	{
-		struct lttng_event *events;
-		ssize_t nb_events;
+		enum lttng_error_code ret_code;
+		size_t original_payload_size;
+		size_t payload_size;
+		const size_t command_header_size = sizeof(struct lttcomm_list_command_header);
+
+		ret = setup_empty_lttng_msg(cmd_ctx);
+		if (ret) {
+			ret = LTTNG_ERR_NOMEM;
+			goto setup_error;
+		}
+
+		original_payload_size = cmd_ctx->reply_payload.buffer.size;
 
 		session_lock_list();
-		nb_events = cmd_list_tracepoints(cmd_ctx->lsm.domain.type, &events);
+		ret_code = cmd_list_tracepoints(cmd_ctx->lsm.domain.type,
+				&cmd_ctx->reply_payload);
 		session_unlock_list();
-		if (nb_events < 0) {
-			/* Return value is a negative lttng_error_code. */
-			ret = -nb_events;
+		if (ret_code != LTTNG_OK) {
+			ret = (int) ret_code;
 			goto error;
 		}
 
-		/*
-		 * Setup lttng message with payload size set to the event list size in
-		 * bytes and then copy list into the llm payload.
-		 */
-		ret = setup_lttng_msg_no_cmd_header(cmd_ctx, events,
-			sizeof(struct lttng_event) * nb_events);
-		free(events);
-
-		if (ret < 0) {
-			goto setup_error;
-		}
+		payload_size = cmd_ctx->reply_payload.buffer.size -
+				command_header_size - original_payload_size;
+		update_lttng_msg(cmd_ctx, command_header_size, payload_size);
 
 		ret = LTTNG_OK;
 		break;
 	}
 	case LTTNG_LIST_TRACEPOINT_FIELDS:
 	{
-		struct lttng_event_field *fields;
-		ssize_t nb_fields;
+		enum lttng_error_code ret_code;
+		size_t original_payload_size;
+		size_t payload_size;
+		const size_t command_header_size = sizeof(struct lttcomm_list_command_header);
+
+		ret = setup_empty_lttng_msg(cmd_ctx);
+		if (ret) {
+			ret = LTTNG_ERR_NOMEM;
+			goto setup_error;
+		}
+
+		original_payload_size = cmd_ctx->reply_payload.buffer.size;
 
 		session_lock_list();
-		nb_fields = cmd_list_tracepoint_fields(cmd_ctx->lsm.domain.type,
-				&fields);
+		ret_code = cmd_list_tracepoint_fields(
+				cmd_ctx->lsm.domain.type, &cmd_ctx->reply_payload);
 		session_unlock_list();
-		if (nb_fields < 0) {
-			/* Return value is a negative lttng_error_code. */
-			ret = -nb_fields;
+		if (ret_code != LTTNG_OK) {
+			ret = (int) ret_code;
 			goto error;
 		}
 
-		/*
-		 * Setup lttng message with payload size set to the event list size in
-		 * bytes and then copy list into the llm payload.
-		 */
-		ret = setup_lttng_msg_no_cmd_header(cmd_ctx, fields,
-				sizeof(struct lttng_event_field) * nb_fields);
-		free(fields);
-
-		if (ret < 0) {
-			goto setup_error;
-		}
+		payload_size = cmd_ctx->reply_payload.buffer.size -
+				command_header_size - original_payload_size;
+		update_lttng_msg(cmd_ctx, command_header_size, payload_size);
 
 		ret = LTTNG_OK;
 		break;
 	}
 	case LTTNG_LIST_SYSCALLS:
 	{
-		struct lttng_event *events;
-		ssize_t nb_events;
+		enum lttng_error_code ret_code;
+		size_t original_payload_size;
+		size_t payload_size;
+		const size_t command_header_size = sizeof(struct lttcomm_list_command_header);
 
-		nb_events = cmd_list_syscalls(&events);
-		if (nb_events < 0) {
-			/* Return value is a negative lttng_error_code. */
-			ret = -nb_events;
-			goto error;
+		ret = setup_empty_lttng_msg(cmd_ctx);
+		if (ret) {
+			ret = LTTNG_ERR_NOMEM;
+			goto setup_error;
 		}
 
-		/*
-		 * Setup lttng message with payload size set to the event list size in
-		 * bytes and then copy list into the llm payload.
-		 */
-		ret = setup_lttng_msg_no_cmd_header(cmd_ctx, events,
-			sizeof(struct lttng_event) * nb_events);
-		free(events);
+		original_payload_size = cmd_ctx->reply_payload.buffer.size;
 
-		if (ret < 0) {
-			goto setup_error;
+		ret_code = cmd_list_syscalls(&cmd_ctx->reply_payload);
+		if (ret_code != LTTNG_OK) {
+			ret = (int) ret_code;
+			goto error;
 		}
 
+		payload_size = cmd_ctx->reply_payload.buffer.size -
+				command_header_size - original_payload_size;
+		update_lttng_msg(cmd_ctx, command_header_size, payload_size);
+
 		ret = LTTNG_OK;
 		break;
 	}
@@ -1876,7 +1753,7 @@ error_add_context:
 			goto error;
 		}
 
-		uris = (lttng_uri *) zmalloc(len);
+		uris = calloc<lttng_uri>(nb_uri);
 		if (uris == NULL) {
 			ret = LTTNG_ERR_FATAL;
 			goto error;
@@ -1986,10 +1863,10 @@ error_add_context:
 	}
 	case LTTNG_LIST_EVENTS:
 	{
-		ssize_t list_ret;
-		struct lttcomm_event_command_header cmd_header = {};
+		enum lttng_error_code ret_code;
 		size_t original_payload_size;
 		size_t payload_size;
+		const size_t command_header_size = sizeof(struct lttcomm_list_command_header);
 
 		ret = setup_empty_lttng_msg(cmd_ctx);
 		if (ret) {
@@ -1999,20 +1876,17 @@ error_add_context:
 
 		original_payload_size = cmd_ctx->reply_payload.buffer.size;
 
-		/* Extended infos are included at the end of the payload. */
-		list_ret = cmd_list_events(cmd_ctx->lsm.domain.type,
+		ret_code = cmd_list_events(cmd_ctx->lsm.domain.type,
 				cmd_ctx->session,
-				cmd_ctx->lsm.u.list.channel_name,
-				&cmd_ctx->reply_payload);
-		if (list_ret < 0) {
-			/* Return value is a negative lttng_error_code. */
-			ret = -list_ret;
+				cmd_ctx->lsm.u.list.channel_name, &cmd_ctx->reply_payload);
+		if (ret_code != LTTNG_OK) {
+			ret = (int) ret_code;
 			goto error;
 		}
 
 		payload_size = cmd_ctx->reply_payload.buffer.size -
-				sizeof(cmd_header) - original_payload_size;
-		update_lttng_msg(cmd_ctx, sizeof(cmd_header), payload_size);
+				command_header_size - original_payload_size;
+		update_lttng_msg(cmd_ctx, command_header_size, payload_size);
 
 		ret = LTTNG_OK;
 		break;
@@ -2020,31 +1894,35 @@ error_add_context:
 	case LTTNG_LIST_SESSIONS:
 	{
 		unsigned int nr_sessions;
-		lttng_session *sessions_payload;
-		size_t payload_len;
+		lttng_session *sessions_payload = nullptr;
+		size_t payload_len = 0;
 
 		session_lock_list();
 		nr_sessions = lttng_sessions_count(
 				LTTNG_SOCK_GET_UID_CRED(&cmd_ctx->creds),
 				LTTNG_SOCK_GET_GID_CRED(&cmd_ctx->creds));
 
-		payload_len = (sizeof(struct lttng_session) * nr_sessions) +
-				(sizeof(struct lttng_session_extended) * nr_sessions);
-		sessions_payload = (lttng_session *) zmalloc(payload_len);
+		if (nr_sessions > 0) {
+			payload_len = (sizeof(struct lttng_session) *
+						      nr_sessions) +
+					(sizeof(struct lttng_session_extended) *
+							nr_sessions);
+			sessions_payload = zmalloc<lttng_session>(payload_len);
+			if (!sessions_payload) {
+				session_unlock_list();
+				ret = -ENOMEM;
+				goto setup_error;
+			}
 
-		if (!sessions_payload) {
-			session_unlock_list();
-			ret = -ENOMEM;
-			goto setup_error;
+			cmd_list_lttng_sessions(sessions_payload, nr_sessions,
+					LTTNG_SOCK_GET_UID_CRED(&cmd_ctx->creds),
+					LTTNG_SOCK_GET_GID_CRED(&cmd_ctx->creds));
 		}
 
-		cmd_list_lttng_sessions(sessions_payload, nr_sessions,
-			LTTNG_SOCK_GET_UID_CRED(&cmd_ctx->creds),
-			LTTNG_SOCK_GET_GID_CRED(&cmd_ctx->creds));
 		session_unlock_list();
 
-		ret = setup_lttng_msg_no_cmd_header(cmd_ctx, sessions_payload,
-			payload_len);
+		ret = setup_lttng_msg_no_cmd_header(
+				cmd_ctx, sessions_payload, payload_len);
 		free(sessions_payload);
 
 		if (ret < 0) {
@@ -2170,8 +2048,7 @@ error_add_context:
 	{
 		lttng_snapshot_output output = cmd_ctx->lsm.u.snapshot_record.output;
 		ret = cmd_snapshot_record(cmd_ctx->session,
-				&output,
-				cmd_ctx->lsm.u.snapshot_record.wait);
+				&output, 0); // RFC: set to zero since it's ignored by cmd_snapshot_record
 		break;
 	}
 	case LTTNG_CREATE_SESSION_EXT:
@@ -2519,7 +2396,6 @@ init_setup_error:
 static int create_client_sock(void)
 {
 	int ret, client_sock;
-	const mode_t old_umask = umask(0);
 
 	/* Create client tool unix socket */
 	client_sock = lttcomm_create_unix_sock(
@@ -2553,7 +2429,6 @@ static int create_client_sock(void)
 	DBG("Created client socket (fd = %i)", client_sock);
 	ret = client_sock;
 end:
-	umask(old_umask);
 	return ret;
 }
 
@@ -2564,7 +2439,7 @@ static void cleanup_client_thread(void *data)
 	lttng_pipe_destroy(quit_pipe);
 }
 
-static void thread_init_cleanup(void *data)
+static void thread_init_cleanup(void *data __attribute__((unused)))
 {
 	set_thread_status(false);
 }