X-Git-Url: https://git.liburcu.org/?a=blobdiff_plain;f=src%2Fbin%2Flttng%2Fcommands%2Fstart.cpp;h=87df0f72f13273cacfa731784d4826e1d838d376;hb=9497e2f771b05ba0cf6ca690f24f73cadc8c6e1d;hp=d8e3569760298a1c7850bf8e29a9dff1ee0c2880;hpb=cd9adb8b829564212158943a0d279bb35322ab30;p=lttng-tools.git diff --git a/src/bin/lttng/commands/start.cpp b/src/bin/lttng/commands/start.cpp index d8e356976..87df0f72f 100644 --- a/src/bin/lttng/commands/start.cpp +++ b/src/bin/lttng/commands/start.cpp @@ -7,7 +7,9 @@ #define _LGPL_SOURCE #include "../command.hpp" +#include "../utils.hpp" +#include #include #include @@ -19,27 +21,32 @@ #include #include -static struct mi_writer *writer; +enum { + OPT_HELP = 1, + OPT_LIST_OPTIONS, + OPT_ENABLE_GLOB, + OPT_ALL, +}; + +namespace { +struct mi_writer *writer; #ifdef LTTNG_EMBED_HELP -static const char help_msg[] = +const char help_msg[] = #include ; #endif -enum { - OPT_HELP = 1, - OPT_LIST_OPTIONS, -}; - -static struct poptOption long_options[] = { +struct poptOption long_options[] = { /* longName, shortName, argInfo, argPtr, value, descrip, argDesc */ { "help", 'h', POPT_ARG_NONE, nullptr, OPT_HELP, nullptr, nullptr }, { "list-options", 0, POPT_ARG_NONE, nullptr, OPT_LIST_OPTIONS, nullptr, nullptr }, + { "glob", 'g', POPT_ARG_NONE, nullptr, OPT_ENABLE_GLOB, nullptr, nullptr }, + { "all", 'a', POPT_ARG_NONE, nullptr, OPT_ALL, nullptr, nullptr }, { nullptr, 0, 0, nullptr, 0, nullptr, nullptr } }; -static int mi_print_session(char *session_name, int enabled) +int mi_print_session(const char *session_name, int enabled) { int ret; @@ -72,56 +79,103 @@ end: * * Start tracing for all trace of the session. */ -static int start_tracing(const char *arg_session_name) +cmd_error_code start_tracing(const char *session_name) { - int ret; - char *session_name; + if (session_name == nullptr) { + return CMD_ERROR; + } - if (arg_session_name == nullptr) { - session_name = get_session_name(); - } else { - session_name = strdup(arg_session_name); - if (session_name == nullptr) { - PERROR("Failed to copy session name"); - } + DBG("Starting tracing for session `%s`", session_name); + + const int ret = lttng_start_tracing(session_name); + if (ret < 0) { + LTTNG_THROW_CTL(fmt::format("Failed to start session `{}`", session_name), + static_cast(-ret)); } - if (session_name == nullptr) { - ret = CMD_ERROR; - goto error; + MSG("Tracing started for session `%s`", session_name); + if (lttng_opt_mi) { + if (mi_print_session(session_name, 1)) { + return CMD_ERROR; + } } - DBG("Starting tracing for session %s", session_name); + return CMD_SUCCESS; +} - ret = lttng_start_tracing(session_name); - if (ret < 0) { - switch (-ret) { - case LTTNG_ERR_TRACE_ALREADY_STARTED: - WARN("Tracing already started for session %s", session_name); - break; - default: - ERR("%s", lttng_strerror(ret)); - break; +cmd_error_code start_tracing(const session_spec& spec) noexcept +{ + bool had_warning = false; + bool had_error = false; + bool listing_failed = false; + + const auto sessions = [&listing_failed, &spec]() -> session_list { + try { + return list_sessions(spec); + } catch (const lttng::ctl::error& ctl_exception) { + ERR_FMT("Failed to list sessions ({})", + lttng_strerror(-ctl_exception.code())); + listing_failed = true; + return {}; } - goto free_name; + }(); + + if (!listing_failed && sessions.size() == 0 && spec.type == session_spec::type::NAME) { + ERR_FMT("Session `{}` not found", spec.value); + return CMD_ERROR; } - ret = CMD_SUCCESS; + if (listing_failed) { + return CMD_FATAL; + } - MSG("Tracing started for session %s", session_name); - if (lttng_opt_mi) { - ret = mi_print_session(session_name, 1); - if (ret) { - ret = CMD_ERROR; - goto free_name; + for (const auto& session : sessions) { + cmd_error_code sub_ret; + + try { + sub_ret = start_tracing(session.name); + } catch (const lttng::ctl::error& ctl_exception) { + switch (ctl_exception.code()) { + case LTTNG_ERR_TRACE_ALREADY_STARTED: + WARN_FMT("Tracing already started for session `{}`", session.name); + sub_ret = CMD_SUCCESS; + break; + case LTTNG_ERR_NO_SESSION: + if (spec.type != session_spec::type::NAME) { + /* Session destroyed during command, ignore and carry-on. */ + sub_ret = CMD_SUCCESS; + break; + } else { + sub_ret = CMD_ERROR; + break; + } + case LTTNG_ERR_NO_SESSIOND: + /* Don't keep going on a fatal error. */ + return CMD_FATAL; + default: + /* Generic error. */ + sub_ret = CMD_ERROR; + ERR_FMT("Failed to start session `{}` ({})", + session.name, + lttng_strerror(-ctl_exception.code())); + break; + } } + + /* Keep going, but report the most serious state. */ + had_warning |= sub_ret == CMD_WARNING; + had_error |= sub_ret == CMD_ERROR; } -free_name: - free(session_name); -error: - return ret; + if (had_error) { + return CMD_ERROR; + } else if (had_warning) { + return CMD_WARNING; + } else { + return CMD_SUCCESS; + } } +} /* namespace */ /* * cmd_start @@ -130,10 +184,15 @@ error: */ int cmd_start(int argc, const char **argv) { - int opt, ret = CMD_SUCCESS, command_ret = CMD_SUCCESS, success = 1; + int opt; + cmd_error_code command_ret = CMD_SUCCESS; + bool success = true; static poptContext pc; - const char *arg_session_name = nullptr; const char *leftover = nullptr; + session_spec session_spec = { + .type = session_spec::NAME, + .value = nullptr, + }; pc = poptGetContext(nullptr, argc, argv, long_options, 0); poptReadDefaultConfig(pc, 0); @@ -141,23 +200,34 @@ int cmd_start(int argc, const char **argv) while ((opt = poptGetNextOpt(pc)) != -1) { switch (opt) { case OPT_HELP: + { + int ret; + SHOW_HELP(); + command_ret = static_cast(ret); goto end; + } case OPT_LIST_OPTIONS: list_cmd_options(stdout, long_options); goto end; + case OPT_ENABLE_GLOB: + session_spec.type = session_spec::GLOB_PATTERN; + break; + case OPT_ALL: + session_spec.type = session_spec::ALL; + break; default: - ret = CMD_UNDEFINED; + command_ret = CMD_UNDEFINED; goto end; } } - arg_session_name = poptGetArg(pc); + session_spec.value = poptGetArg(pc); leftover = poptGetArg(pc); if (leftover) { ERR("Unknown argument: %s", leftover); - ret = CMD_ERROR; + command_ret = CMD_ERROR; goto end; } @@ -165,21 +235,19 @@ int cmd_start(int argc, const char **argv) if (lttng_opt_mi) { writer = mi_lttng_writer_create(fileno(stdout), lttng_opt_mi); if (!writer) { - ret = -LTTNG_ERR_NOMEM; + command_ret = CMD_ERROR; goto end; } /* Open command element */ - ret = mi_lttng_writer_command_open(writer, mi_lttng_element_command_start); - if (ret) { - ret = CMD_ERROR; + if (mi_lttng_writer_command_open(writer, mi_lttng_element_command_start)) { + command_ret = CMD_ERROR; goto end; } /* Open output element */ - ret = mi_lttng_writer_open_element(writer, mi_lttng_element_command_output); - if (ret) { - ret = CMD_ERROR; + if (mi_lttng_writer_open_element(writer, mi_lttng_element_command_output)) { + command_ret = CMD_ERROR; goto end; } @@ -187,39 +255,35 @@ int cmd_start(int argc, const char **argv) * Open sessions element * For validation purpose */ - ret = mi_lttng_writer_open_element(writer, config_element_sessions); - if (ret) { - ret = CMD_ERROR; + if (mi_lttng_writer_open_element(writer, config_element_sessions)) { + command_ret = CMD_ERROR; goto end; } } - command_ret = start_tracing(arg_session_name); - if (command_ret) { - success = 0; + command_ret = start_tracing(session_spec); + if (command_ret != CMD_SUCCESS) { + success = false; } /* Mi closing */ if (lttng_opt_mi) { /* Close sessions and output element */ - ret = mi_lttng_close_multi_element(writer, 2); - if (ret) { - ret = CMD_ERROR; + if (mi_lttng_close_multi_element(writer, 2)) { + command_ret = CMD_ERROR; goto end; } /* Success ? */ - ret = mi_lttng_writer_write_element_bool( - writer, mi_lttng_element_command_success, success); - if (ret) { - ret = CMD_ERROR; + if (mi_lttng_writer_write_element_bool( + writer, mi_lttng_element_command_success, success)) { + command_ret = CMD_ERROR; goto end; } /* Command element close */ - ret = mi_lttng_writer_command_close(writer); - if (ret) { - ret = CMD_ERROR; + if (mi_lttng_writer_command_close(writer)) { + command_ret = CMD_ERROR; goto end; } } @@ -227,12 +291,9 @@ int cmd_start(int argc, const char **argv) end: /* Mi clean-up */ if (writer && mi_lttng_writer_destroy(writer)) { - /* Preserve original error code */ - ret = ret ? ret : -LTTNG_ERR_MI_IO_FAIL; + command_ret = CMD_ERROR; } - /* Overwrite ret if an error occurred with start_tracing */ - ret = command_ret ? command_ret : ret; poptFreeContext(pc); - return ret; + return command_ret; }