X-Git-Url: https://git.liburcu.org/?a=blobdiff_plain;f=src%2Fbin%2Flttng%2Fcommands%2Fstart.cpp;h=79c9d89734efad73d1f753e3567bde632c11276f;hb=42a11b8f4c8d98b33fa1eadcdcda96253e651f0b;hp=556c1120dddc94b86ccba2b9dd7a18ff59f17bd9;hpb=eaa8ef76a52ba21e42d7d95355af72ff3a85a116;p=lttng-tools.git diff --git a/src/bin/lttng/commands/start.cpp b/src/bin/lttng/commands/start.cpp index 556c1120d..79c9d8973 100644 --- a/src/bin/lttng/commands/start.cpp +++ b/src/bin/lttng/commands/start.cpp @@ -21,14 +21,6 @@ #include #include -static struct mi_writer *writer; - -#ifdef LTTNG_EMBED_HELP -static const char help_msg[] = -#include - ; -#endif - enum { OPT_HELP = 1, OPT_LIST_OPTIONS, @@ -36,7 +28,16 @@ enum { OPT_ALL, }; -static struct poptOption long_options[] = { +namespace { +struct mi_writer *writer; + +#ifdef LTTNG_EMBED_HELP +const char help_msg[] = +#include + ; +#endif + +struct poptOption long_options[] = { /* longName, shortName, argInfo, argPtr, value, descrip, argDesc */ { "help", 'h', POPT_ARG_NONE, nullptr, OPT_HELP, nullptr, nullptr }, { "list-options", 0, POPT_ARG_NONE, nullptr, OPT_LIST_OPTIONS, nullptr, nullptr }, @@ -45,7 +46,7 @@ static struct poptOption long_options[] = { { nullptr, 0, 0, nullptr, 0, nullptr, nullptr } }; -static int mi_print_session(const char *session_name, int enabled) +int mi_print_session(const char *session_name, int enabled) { int ret; @@ -78,76 +79,103 @@ end: * * Start tracing for all trace of the session. */ -static int start_tracing(const char *session_name) +cmd_error_code start_tracing(const char *session_name) { - int ret; - if (session_name == nullptr) { - ret = CMD_ERROR; - goto error; + return CMD_ERROR; } - DBG("Starting tracing for session %s", session_name); + DBG("Starting tracing for session `%s`", session_name); - ret = lttng_start_tracing(session_name); + const int ret = lttng_start_tracing(session_name); if (ret < 0) { - switch (-ret) { - case LTTNG_ERR_TRACE_ALREADY_STARTED: - WARN("Tracing already started for session %s", session_name); - break; - default: - ERR("%s", lttng_strerror(ret)); - break; - } - goto error; + LTTNG_THROW_CTL(fmt::format("Failed to start session `{}`", session_name), + static_cast(-ret)); } - ret = CMD_SUCCESS; - - MSG("Tracing started for session %s", session_name); + MSG("Tracing started for session `%s`", session_name); if (lttng_opt_mi) { - ret = mi_print_session(session_name, 1); - if (ret) { - ret = CMD_ERROR; - goto error; + if (mi_print_session(session_name, 1)) { + return CMD_ERROR; } } -error: - return ret; + return CMD_SUCCESS; } -static int start_tracing(const struct session_spec& spec) +cmd_error_code start_tracing(const session_spec& spec) noexcept { - int ret = CMD_SUCCESS; bool had_warning = false; + bool had_error = false; + bool listing_failed = false; + + const auto sessions = [&listing_failed, &spec]() -> session_list { + try { + return list_sessions(spec); + } catch (const lttng::ctl::error& ctl_exception) { + ERR_FMT("Failed to list sessions ({})", + lttng_strerror(-ctl_exception.code())); + listing_failed = true; + return {}; + } + }(); + + if (!listing_failed && sessions.size() == 0 && spec.type_ == session_spec::type::NAME) { + ERR_FMT("Session `{}` not found", spec.value); + return CMD_ERROR; + } + + if (listing_failed) { + return CMD_FATAL; + } - try { - for (const auto& session : list_sessions(spec)) { - const auto sub_ret = start_tracing(session.name); + for (const auto& session : sessions) { + cmd_error_code sub_ret; - switch (sub_ret) { - case CMD_WARNING: - had_warning = true; - /* fall-through. */ - case CMD_SUCCESS: - continue; + try { + sub_ret = start_tracing(session.name); + } catch (const lttng::ctl::error& ctl_exception) { + switch (ctl_exception.code()) { + case LTTNG_ERR_TRACE_ALREADY_STARTED: + WARN_FMT("Tracing already started for session `{}`", session.name); + sub_ret = CMD_SUCCESS; + break; + case LTTNG_ERR_NO_SESSION: + if (spec.type_ != session_spec::type::NAME) { + /* Session destroyed during command, ignore and carry-on. */ + sub_ret = CMD_SUCCESS; + break; + } else { + sub_ret = CMD_ERROR; + break; + } + case LTTNG_ERR_NO_SESSIOND: + /* Don't keep going on a fatal error. */ + return CMD_FATAL; default: - ret = sub_ret; + /* Generic error. */ + sub_ret = CMD_ERROR; + ERR_FMT("Failed to start session `{}` ({})", + session.name, + lttng_strerror(-ctl_exception.code())); break; } } - } catch (const std::exception& e) { - ERR_FMT("{}", e.what()); - return CMD_FATAL; - } - if (ret == CMD_SUCCESS && had_warning) { - ret = CMD_WARNING; + /* Keep going, but report the most serious state. */ + had_warning |= sub_ret == CMD_WARNING; + had_error |= sub_ret == CMD_ERROR; } - return ret; + if (had_error) { + return CMD_ERROR; + } else if (had_warning) { + return CMD_WARNING; + } else { + return CMD_SUCCESS; + } } +} /* namespace */ /* * cmd_start @@ -156,13 +184,12 @@ static int start_tracing(const struct session_spec& spec) */ int cmd_start(int argc, const char **argv) { - int opt, ret = CMD_SUCCESS, command_ret = CMD_SUCCESS, success = 1; + int opt; + cmd_error_code command_ret = CMD_SUCCESS; + bool success = true; static poptContext pc; const char *leftover = nullptr; - struct session_spec session_spec = { - .type = session_spec::NAME, - .value = nullptr, - }; + session_spec session_spec(session_spec::type::NAME); pc = poptGetContext(nullptr, argc, argv, long_options, 0); poptReadDefaultConfig(pc, 0); @@ -170,19 +197,24 @@ int cmd_start(int argc, const char **argv) while ((opt = poptGetNextOpt(pc)) != -1) { switch (opt) { case OPT_HELP: + { + int ret; + SHOW_HELP(); + command_ret = static_cast(ret); goto end; + } case OPT_LIST_OPTIONS: list_cmd_options(stdout, long_options); goto end; case OPT_ENABLE_GLOB: - session_spec.type = session_spec::GLOB_PATTERN; + session_spec.type_ = session_spec::type::GLOB_PATTERN; break; case OPT_ALL: - session_spec.type = session_spec::ALL; + session_spec.type_ = session_spec::type::ALL; break; default: - ret = CMD_UNDEFINED; + command_ret = CMD_UNDEFINED; goto end; } } @@ -192,7 +224,7 @@ int cmd_start(int argc, const char **argv) leftover = poptGetArg(pc); if (leftover) { ERR("Unknown argument: %s", leftover); - ret = CMD_ERROR; + command_ret = CMD_ERROR; goto end; } @@ -200,21 +232,19 @@ int cmd_start(int argc, const char **argv) if (lttng_opt_mi) { writer = mi_lttng_writer_create(fileno(stdout), lttng_opt_mi); if (!writer) { - ret = -LTTNG_ERR_NOMEM; + command_ret = CMD_ERROR; goto end; } /* Open command element */ - ret = mi_lttng_writer_command_open(writer, mi_lttng_element_command_start); - if (ret) { - ret = CMD_ERROR; + if (mi_lttng_writer_command_open(writer, mi_lttng_element_command_start)) { + command_ret = CMD_ERROR; goto end; } /* Open output element */ - ret = mi_lttng_writer_open_element(writer, mi_lttng_element_command_output); - if (ret) { - ret = CMD_ERROR; + if (mi_lttng_writer_open_element(writer, mi_lttng_element_command_output)) { + command_ret = CMD_ERROR; goto end; } @@ -222,39 +252,35 @@ int cmd_start(int argc, const char **argv) * Open sessions element * For validation purpose */ - ret = mi_lttng_writer_open_element(writer, config_element_sessions); - if (ret) { - ret = CMD_ERROR; + if (mi_lttng_writer_open_element(writer, config_element_sessions)) { + command_ret = CMD_ERROR; goto end; } } command_ret = start_tracing(session_spec); - if (command_ret) { - success = 0; + if (command_ret != CMD_SUCCESS) { + success = false; } /* Mi closing */ if (lttng_opt_mi) { /* Close sessions and output element */ - ret = mi_lttng_close_multi_element(writer, 2); - if (ret) { - ret = CMD_ERROR; + if (mi_lttng_close_multi_element(writer, 2)) { + command_ret = CMD_ERROR; goto end; } /* Success ? */ - ret = mi_lttng_writer_write_element_bool( - writer, mi_lttng_element_command_success, success); - if (ret) { - ret = CMD_ERROR; + if (mi_lttng_writer_write_element_bool( + writer, mi_lttng_element_command_success, success)) { + command_ret = CMD_ERROR; goto end; } /* Command element close */ - ret = mi_lttng_writer_command_close(writer); - if (ret) { - ret = CMD_ERROR; + if (mi_lttng_writer_command_close(writer)) { + command_ret = CMD_ERROR; goto end; } } @@ -262,12 +288,9 @@ int cmd_start(int argc, const char **argv) end: /* Mi clean-up */ if (writer && mi_lttng_writer_destroy(writer)) { - /* Preserve original error code */ - ret = ret ? ret : -LTTNG_ERR_MI_IO_FAIL; + command_ret = CMD_ERROR; } - /* Overwrite ret if an error occurred with start_tracing */ - ret = command_ret ? command_ret : ret; poptFreeContext(pc); - return ret; + return command_ret; }