Fix: save: leak of configuration file fd

[lttng-tools.git] / src / common / config / session-config.h

diff --git a/src/common/config/session-config.h b/src/common/config/session-config.h
index 2fed612a1cfbd5783891ec16e99808dc386e3645..d77d174c840c058c89430a7bbdf85f1850afbf2a 100644 (file)
--- a/src/common/config/session-config.h
+++ b/src/common/config/session-config.h
@@ -57,7 +57,7 @@ typedef int (*config_entry_handler_cb)(const struct config_entry *, void *);
  * "", only the global entries are relayed.
  *
  * Returns 0 on success. Negative values are error codes. If the return value
- * is positive, it represents the line number on which a parsing error occured.
+ * is positive, it represents the line number on which a parsing error occurred.
  */
 LTTNG_HIDDEN
 int config_get_section_entries(const char *path, const char *section,
@@ -78,8 +78,8 @@ int config_parse_value(const char *value);
 /*
  * Create an instance of a configuration writer.
  *
- * fd_output File to which the XML content must be written. The file will be
- * closed once the config_writer has been destroyed.
+ * fd_output File to which the XML content must be written. fd_output is
+ * owned by the caller.
  *
  * indent If other than 0 the XML will be pretty printed
  * with indentation and newline.
@@ -108,13 +108,27 @@ int config_writer_destroy(struct config_writer *writer);
  *
  * element_name Element tag name.
  *
- * Returns zero if the XML document could be closed cleanly.
+ * Returns zero if the XML element could be opened.
  * Negative values indicate an error.
  */
 LTTNG_HIDDEN
 int config_writer_open_element(struct config_writer *writer,
                const char *element_name);
 
+/*
+ * Write an element tag attribute.
+ *
+ * writer An instance of a configuration writer.
+ *
+ * name Attribute name.
+ *
+ * Returns zero if the XML element's attribute could be written.
+ * Negative values indicate an error.
+ */
+LTTNG_HIDDEN
+int config_writer_write_attribute(struct config_writer *writer,
+               const char *name, const char *value);
+
 /*
  * Close the current element tag.
  *