Fix: wrong variable assignment on error

[lttng-tools.git] / src / bin / lttng / commands / track-untrack.c

diff --git a/src/bin/lttng/commands/track-untrack.c b/src/bin/lttng/commands/track-untrack.c
index 3771de5d94b5b7bfcaacf26b0663044cecaac98f..f5580544361f85d0f84d9669b228c677f89431a7 100644 (file)
--- a/src/bin/lttng/commands/track-untrack.c
+++ b/src/bin/lttng/commands/track-untrack.c
@@ -87,7 +87,7 @@ int parse_pid_string(const char *_pid_string,
                goto error;
        }
        if (all) {
-               pid_list = zmalloc(sizeof(*_pid_list));
+               pid_list = zmalloc(sizeof(*pid_list));
                if (!pid_list) {
                        ERR("Out of memory");
                        retval = CMD_ERROR;
@@ -149,7 +149,7 @@ int parse_pid_string(const char *_pid_string,
                goto error;
        }
 
-       /* Copy */
+       /* Reparse string and populate the pid list. */
        count = 0;
        one_pid_str = strtok_r(pid_string, ",", &iter);
        while (one_pid_str != NULL) {
@@ -357,7 +357,7 @@ int cmd_track_untrack(enum cmd_type cmd_type, const char *cmd_str,
 
        ret = print_missing_or_multiple_domains(opt_kernel + opt_userspace);
        if (ret) {
-               ret = CMD_ERROR;
+               command_ret = CMD_ERROR;
                goto end;
        }