Fix: lttng: poptGetArg doesn't provide string ownership
[lttng-tools.git] / src / bin / lttng / commands / destroy.c
index be0261d11b760b67561b52d324334c35f39162e7..d3e2ac59fd37db36417c1a8b96f49ecd8fd08eb2 100644 (file)
@@ -1,18 +1,8 @@
 /*
- * Copyright (C) 2011 - David Goulet <david.goulet@polymtl.ca>
+ * Copyright (C) 2011 EfficiOS Inc.
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License, version 2 only,
- * as published by the Free Software Foundation.
+ * SPDX-License-Identifier: GPL-2.0-only
  *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
 #define _LGPL_SOURCE
@@ -32,7 +22,6 @@
 #include <common/sessiond-comm/sessiond-comm.h>
 #include <common/utils.h>
 
-static char *opt_session_name;
 static int opt_destroy_all;
 static int opt_no_wait;
 
@@ -69,18 +58,20 @@ static int destroy_session(struct lttng_session *session)
 {
        int ret;
        char *session_name = NULL;
-       bool session_was_stopped;
+       bool session_was_already_stopped;
        enum lttng_error_code ret_code;
        struct lttng_destruction_handle *handle = NULL;
-        enum lttng_destruction_handle_status status;
-       bool printed_wait_msg = false;
+       enum lttng_destruction_handle_status status;
+       bool newline_needed = false, printed_destroy_msg = false;
        enum lttng_rotation_state rotation_state;
+       char *stats_str = NULL;
 
        ret = lttng_stop_tracing_no_wait(session->name);
        if (ret < 0 && ret != -LTTNG_ERR_TRACE_ALREADY_STOPPED) {
                ERR("%s", lttng_strerror(ret));
        }
-       session_was_stopped = ret == -LTTNG_ERR_TRACE_ALREADY_STOPPED;
+
+       session_was_already_stopped = ret == -LTTNG_ERR_TRACE_ALREADY_STOPPED;
        if (!opt_no_wait) {
                do {
                        ret = lttng_data_pending(session->name);
@@ -90,14 +81,16 @@ static int destroy_session(struct lttng_session *session)
                        }
 
                        /*
-                        * Data sleep time before retrying (in usec). Don't sleep if the call
-                        * returned value indicates availability.
+                        * Data sleep time before retrying (in usec). Don't
+                        * sleep if the call returned value indicates
+                        * availability.
                         */
                        if (ret) {
-                               if (!printed_wait_msg) {
-                                       _MSG("Waiting for destruction of session \"%s\"",
+                               if (!printed_destroy_msg) {
+                                       _MSG("Destroying session %s",
                                                        session->name);
-                                       printed_wait_msg = true;
+                                       newline_needed = true;
+                                       printed_destroy_msg = true;
                                        fflush(stdout);
                                }
 
@@ -107,12 +100,16 @@ static int destroy_session(struct lttng_session *session)
                        }
                } while (ret != 0);
        }
-       if (!session_was_stopped) {
+
+       if (!session_was_already_stopped) {
                /*
                 * Don't print the event and packet loss warnings since the user
                 * already saw them when stopping the trace.
                 */
-               print_session_stats(session->name);
+               ret = get_session_stats_str(session->name, &stats_str);
+               if (ret < 0) {
+                       goto error;
+               }
        }
 
        ret_code = lttng_destroy_session_ext(session->name, &handle);
@@ -126,14 +123,15 @@ static int destroy_session(struct lttng_session *session)
        }
 
        do {
-               status = lttng_destruction_handle_wait_for_completion(handle,
-                               DEFAULT_DATA_AVAILABILITY_WAIT_TIME_US / USEC_PER_MSEC);
+               status = lttng_destruction_handle_wait_for_completion(
+                               handle, DEFAULT_DATA_AVAILABILITY_WAIT_TIME_US /
+                                                       USEC_PER_MSEC);
                switch (status) {
                case LTTNG_DESTRUCTION_HANDLE_STATUS_TIMEOUT:
-                       if (!printed_wait_msg) {
-                               _MSG("Waiting for destruction of session \"%s\"",
-                                               session->name);
-                               printed_wait_msg = true;
+                       if (!printed_destroy_msg) {
+                               _MSG("Destroying session %s", session->name);
+                               newline_needed = true;
+                               printed_destroy_msg = true;
                        }
                        _MSG(".");
                        fflush(stdout);
@@ -141,8 +139,10 @@ static int destroy_session(struct lttng_session *session)
                case LTTNG_DESTRUCTION_HANDLE_STATUS_COMPLETED:
                        break;
                default:
-                       ERR("Failed to wait for the completion of the destruction of session \"%s\"",
+                       ERR("%sFailed to wait for the completion of the destruction of session \"%s\"",
+                                       newline_needed ? "\n" : "",
                                        session->name);
+                       newline_needed = false;
                        ret = -1;
                        goto error;
                }
@@ -150,8 +150,10 @@ static int destroy_session(struct lttng_session *session)
 
        status = lttng_destruction_handle_get_result(handle, &ret_code);
        if (status != LTTNG_DESTRUCTION_HANDLE_STATUS_OK) {
-               ERR("Failed to get the result of session destruction");
+               ERR("%sFailed to get the result of session destruction",
+                               newline_needed ? "\n" : "");
                ret = -1;
+               newline_needed = false;
                goto error;
        }
        if (ret_code != LTTNG_OK) {
@@ -159,44 +161,50 @@ static int destroy_session(struct lttng_session *session)
                goto error;
        }
 
-       status = lttng_destruction_handle_get_rotation_state(handle,
-                       &rotation_state);
+       status = lttng_destruction_handle_get_rotation_state(
+                       handle, &rotation_state);
        if (status != LTTNG_DESTRUCTION_HANDLE_STATUS_OK) {
-               ERR("Failed to get rotation state from destruction handle");
+               ERR("%sFailed to get rotation state from destruction handle",
+                               newline_needed ? "\n" : "");
+               newline_needed = false;
                goto skip_wait_rotation;
        }
+
        switch (rotation_state) {
        case LTTNG_ROTATION_STATE_NO_ROTATION:
                break;
-        case LTTNG_ROTATION_STATE_COMPLETED:
+       case LTTNG_ROTATION_STATE_COMPLETED:
        {
                const struct lttng_trace_archive_location *location;
 
-               status = lttng_destruction_handle_get_archive_location(handle,
-                               &location);
+               status = lttng_destruction_handle_get_archive_location(
+                               handle, &location);
                if (status == LTTNG_DESTRUCTION_HANDLE_STATUS_OK) {
-                       if (printed_wait_msg) {
-                               MSG("");
-                               printed_wait_msg = false;
-                       }
-                       ret = print_trace_archive_location(location,
-                                       session->name);
+                       ret = print_trace_archive_location(
+                                       location, session->name);
                        if (ret) {
-                               ERR("Failed to print the location of trace archive");
+                               ERR("%sFailed to print the location of trace archive",
+                                               newline_needed ? "\n" : "");
+                               newline_needed = false;
                                goto skip_wait_rotation;
                        }
                        break;
                }
                /* fall-through. */
-        }
-        default:
-               ERR("Failed to get the location of the rotation performed during the session's destruction");
+       }
+       default:
+               ERR("%sFailed to get the location of the rotation performed during the session's destruction",
+                               newline_needed ? "\n" : "");
+               newline_needed = false;
                goto skip_wait_rotation;
        }
 skip_wait_rotation:
-       MSG("%sSession \"%s\" destroyed", printed_wait_msg ? "\n" : "",
+       MSG("%sSession %s destroyed", newline_needed ? "\n" : "",
                        session->name);
-       printed_wait_msg = false;
+       newline_needed = false;
+       if (stats_str) {
+               MSG("%s", stats_str);
+       }
 
        session_name = get_session_name_quiet();
        if (session_name && !strncmp(session->name, session_name, NAME_MAX)) {
@@ -213,11 +221,12 @@ skip_wait_rotation:
 
        ret = CMD_SUCCESS;
 error:
-       if (printed_wait_msg) {
+       if (newline_needed) {
                MSG("");
        }
        lttng_destruction_handle_destroy(handle);
        free(session_name);
+       free(stats_str);
        return ret;
 }
 
@@ -260,9 +269,10 @@ int cmd_destroy(int argc, const char **argv)
        int ret = CMD_SUCCESS , i, command_ret = CMD_SUCCESS, success = 1;
        static poptContext pc;
        char *session_name = NULL;
+       const char *arg_session_name = NULL;
        const char *leftover = NULL;
 
-       struct lttng_session *sessions;
+       struct lttng_session *sessions = NULL;
        int count;
        int found;
 
@@ -332,18 +342,22 @@ int cmd_destroy(int argc, const char **argv)
                        success = 0;
                }
        } else {
-               opt_session_name = (char *) poptGetArg(pc);
+               arg_session_name = poptGetArg(pc);
 
-               if (!opt_session_name) {
+               if (!arg_session_name) {
                        /* No session name specified, lookup default */
                        session_name = get_session_name();
+               } else {
+                       session_name = strdup(arg_session_name);
                        if (session_name == NULL) {
-                               command_ret = CMD_ERROR;
-                               success = 0;
-                               goto mi_closing;
+                               PERROR("Failed to copy session name");
                        }
-               } else {
-                       session_name = opt_session_name;
+               }
+
+               if (session_name == NULL) {
+                       command_ret = CMD_ERROR;
+                       success = 0;
+                       goto mi_closing;
                }
 
                /* Find the corresponding lttng_session struct */
@@ -409,9 +423,8 @@ end:
                ret = ret ? ret : -LTTNG_ERR_MI_IO_FAIL;
        }
 
-       if (opt_session_name == NULL) {
-               free(session_name);
-       }
+       free(session_name);
+       free(sessions);
 
        /* Overwrite ret if an error occurred during destroy_session/all */
        ret = command_ret ? command_ret : ret;
This page took 0.05395 seconds and 4 git commands to generate.