projects
/
lttng-tools.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Fix: event: unchecked return value for lttng_strncpy
[lttng-tools.git]
/
src
/
common
/
event.c
diff --git
a/src/common/event.c
b/src/common/event.c
index fd44f6da2133da600197bb0e45353abf09a1cec6..56af0caaa063979148b85bd967be689ac7fd4871 100644
(file)
--- a/
src/common/event.c
+++ b/
src/common/event.c
@@
-1054,7
+1054,8
@@
static ssize_t lttng_event_context_perf_counter_populate_from_buffer(
const struct lttng_buffer_view *view,
struct lttng_event_context *event_ctx)
{
const struct lttng_buffer_view *view,
struct lttng_event_context *event_ctx)
{
- ssize_t ret, offset = 0;
+ int ret;
+ ssize_t consumed, offset = 0;
const struct lttng_event_context_perf_counter_comm *comm;
size_t name_len;
const struct lttng_buffer_view comm_view = lttng_buffer_view_from_view(
const struct lttng_event_context_perf_counter_comm *comm;
size_t name_len;
const struct lttng_buffer_view comm_view = lttng_buffer_view_from_view(
@@
-1066,7
+1067,7
@@
static ssize_t lttng_event_context_perf_counter_populate_from_buffer(
event_ctx->ctx == LTTNG_EVENT_CONTEXT_PERF_CPU_COUNTER);
if (!lttng_buffer_view_is_valid(&comm_view)) {
event_ctx->ctx == LTTNG_EVENT_CONTEXT_PERF_CPU_COUNTER);
if (!lttng_buffer_view_is_valid(&comm_view)) {
-
ret
= -1;
+
consumed
= -1;
goto end;
}
goto end;
}
@@
-1080,7
+1081,7
@@
static ssize_t lttng_event_context_perf_counter_populate_from_buffer(
lttng_buffer_view_from_view(
view, offset, name_len);
if (!lttng_buffer_view_is_valid(&provider_name_view)) {
lttng_buffer_view_from_view(
view, offset, name_len);
if (!lttng_buffer_view_is_valid(&provider_name_view)) {
-
ret
= -1;
+
consumed
= -1;
goto end;
}
goto end;
}
@@
-1088,21
+1089,25
@@
static ssize_t lttng_event_context_perf_counter_populate_from_buffer(
if (!lttng_buffer_view_contains_string(
&provider_name_view, name, name_len)) {
if (!lttng_buffer_view_contains_string(
&provider_name_view, name, name_len)) {
-
ret
= -1;
+
consumed
= -1;
goto end;
}
goto end;
}
- lttng_strncpy(event_ctx->u.perf_counter.name, name, name_len);
+ ret = lttng_strncpy(event_ctx->u.perf_counter.name, name, name_len);
+ if (ret) {
+ consumed = -1;
+ goto end;
+ }
offset += name_len;
}
event_ctx->u.perf_counter.config = comm->config;
event_ctx->u.perf_counter.type = comm->type;
offset += name_len;
}
event_ctx->u.perf_counter.config = comm->config;
event_ctx->u.perf_counter.type = comm->type;
-
ret
= offset;
+
consumed
= offset;
end:
end:
- return
ret
;
+ return
consumed
;
}
LTTNG_HIDDEN
}
LTTNG_HIDDEN
This page took
0.023235 seconds
and
4
git commands to generate.