From 8ab63dfb6a51460c9744828f7248d0fdca602ad3 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=A9mie=20Galarneau?= Date: Tue, 23 Apr 2024 15:13:16 -0400 Subject: [PATCH] Fix: syscall event rule: emission sites not compared in is_equal MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The emission sites are not compared when comparing two kernel-syscall event rules. This prevents users from subscribing to notifications of triggers that use event-rule-matches syscall conditions which differ only by their emission site (entry, exit, entry+exit). Signed-off-by: Jérémie Galarneau Change-Id: Id15eb682cd40f4966ca10911314ae7e8839712da --- src/common/event-rule/kernel-syscall.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/common/event-rule/kernel-syscall.cpp b/src/common/event-rule/kernel-syscall.cpp index 23a432aac..933c3543f 100644 --- a/src/common/event-rule/kernel-syscall.cpp +++ b/src/common/event-rule/kernel-syscall.cpp @@ -133,6 +133,10 @@ static bool lttng_event_rule_kernel_syscall_is_equal(const struct lttng_event_ru goto end; } + if (a->emission_site != b->emission_site) { + goto end; + } + is_equal = true; end: return is_equal; -- 2.34.1