From abfd272b984fd9881984e44d04979e3a093e8a39 Mon Sep 17 00:00:00 2001 From: Mathieu Desnoyers Date: Tue, 5 Apr 2016 09:26:51 -0400 Subject: [PATCH] Fix: Remove dead code from filter interpreter Detected by Coverity: ** CID 1353794: Control flow issues (DEADCODE) /lttng-filter-interpreter.c: 123 in stack_strcmp() Signed-off-by: Mathieu Desnoyers --- lttng-filter-interpreter.c | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/lttng-filter-interpreter.c b/lttng-filter-interpreter.c index 8323fbbb..c7e9f1f1 100644 --- a/lttng-filter-interpreter.c +++ b/lttng-filter-interpreter.c @@ -119,21 +119,16 @@ int stack_strcmp(struct estack *stack, int top, const char *cmp_type) } } if (unlikely(char_ax == '\0')) { - if (char_bx == '\0') { - diff = 0; - break; - } else { - if (estack_bx(stack, top)->u.s.literal) { - ret = parse_char(estack_bx(stack, top), - &char_bx, &offset_bx); - if (ret == -1) { - diff = 0; - break; - } + if (estack_bx(stack, top)->u.s.literal) { + ret = parse_char(estack_bx(stack, top), + &char_bx, &offset_bx); + if (ret == -1) { + diff = 0; + break; } - diff = 1; - break; } + diff = 1; + break; } if (estack_bx(stack, top)->u.s.literal) { ret = parse_char(estack_bx(stack, top), -- 2.34.1