From 7ba728fd07022b6a2f5fcd79af52bbb35e29e4e3 Mon Sep 17 00:00:00 2001
From: Kienan Stewart <kstewart@efficios.com>
Date: Thu, 18 May 2023 09:33:59 -0400
Subject: [PATCH] lava: Switch from vmdebootstrap to debootstrap

vmdebootstrap is [abandoned][3] by it's author, who recommends no longer
using it. The package is no longer available in recent distributions.

While there is a more or less direct sucessors, [vmdb2][1] and other
options including [debos][2], the needs for creating the rootfs appear
to be minimal so I adjusted the script so any further modifications
are done by commands chrooted in the new environment.

[1]: https://vmdb2-manual.liw.fi/
[2]: https://github.com/go-debos/debos
[3]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=907751 "Request
for removal from Debian"

Change-Id: I0a9e5fa312e62dbce88dc1908433d7059ec294f1

lava: Fix value in generated rootfs' hostname

Change-Id: I748170655a04cb95a07713e8487e427e3ae536a3
---
 lava/rootfs/vmdeboostrap/generate-root.py | 73 +++++++++++++++--------
 1 file changed, 47 insertions(+), 26 deletions(-)

diff --git a/lava/rootfs/vmdeboostrap/generate-root.py b/lava/rootfs/vmdeboostrap/generate-root.py
index 02e66d8..4023adb 100755
--- a/lava/rootfs/vmdeboostrap/generate-root.py
+++ b/lava/rootfs/vmdeboostrap/generate-root.py
@@ -19,15 +19,20 @@ import gzip
 import os
 import shutil
 import subprocess
+import sys
 
 from datetime import datetime
 
 
 def compress(filename):
-    with open(filename, 'rb') as f_in:
-        with gzip.open('{}.gz'.format(filename), 'wb') as f_out:
-            shutil.copyfileobj(f_in, f_out)
-    os.remove(filename)
+    command = [
+        'tar', '-c', '-z',
+        '-f', filename + ".tar.gz",
+        '-C', filename,
+        './'
+    ]
+    subprocess.run(command, check=True)
+    shutil.rmtree(filename)
 
 
 packages = [
@@ -35,7 +40,6 @@ packages = [
     'automake',
     'bash-completion',
     'bison',
-    'bsdtar',
     'build-essential',
     'chrpath',
     'clang',
@@ -47,6 +51,7 @@ packages = [
     'git',
     'htop',
     'jq',
+    'libarchive-tools',
     'libdw-dev',
     'libelf-dev',
     'libffi-dev',
@@ -62,7 +67,7 @@ packages = [
     'netcat-traditional',
     'openssh-server',
     'psmisc',
-    'python-virtualenv',
+    'python3-virtualenv',
     'python3',
     'python3-dev',
     'python3-numpy',
@@ -83,20 +88,13 @@ packages = [
 def main():
     parser = argparse.ArgumentParser(description='Generate lava lttng rootfs')
     parser.add_argument("--arch", default='amd64')
-    # We are using xenial instead of bionic ++ since some syscall test depends
-    # on cat and the libc to use the open syscall. In recent libc openat is
-    # used. See these commit in lttng-tools that helps with the problem:
-    # c8e51d1559c48a12f18053997bbcff0c162691c4
-    # 192bd8fb712659b9204549f29d9a54dc2c57a9e
-    # These are only part of 2.11 and were not backported since they do not
-    # represent a *problem* per se.
-    parser.add_argument("--distribution", default='xenial')
+    parser.add_argument("--distribution", default='jammy')
     parser.add_argument("--mirror", default='http://archive.ubuntu.com/ubuntu')
     parser.add_argument(
         "--component", default='universe,multiverse,main,restricted')
     args = parser.parse_args()
 
-    name = "rootfs_{}_{}_{}.tar".format(args.arch, args.distribution,
+    name = "rootfs_{}_{}_{}".format(args.arch, args.distribution,
                                         datetime.now().strftime("%Y-%m-%d"))
 
     hostname = "linaro-server"
@@ -104,25 +102,48 @@ def main():
     root_password = "root"
     print(name)
     command = [
-        "sudo",
-        "vmdebootstrap",
+        "debootstrap",
         "--arch={}".format(args.arch),
-        "--distribution={}".format(args.distribution),
-        "--mirror={}".format(args.mirror),
-        "--debootstrapopts=components={}".format(args.component),
-        "--tarball={}".format(name),
-        "--package={}".format(",".join(packages)),
-        "--hostname={}".format(hostname),
-        "--user={}".format(user),
-        "--root-password={}".format(root_password),
-        "--no-kernel",
+        "--components={}".format(args.component),
         "--verbose",
+        args.distribution,  # SUITE
+        name,  # TARGET (directory is created)
+        args.mirror,  # MIRROR
     ]
+    completed_command = subprocess.run(command, check=True)
 
+    # packages
+    command = [
+        'chroot', name,
+        'apt-get', 'install', '-y', ] + packages
     completed_command = subprocess.run(command, check=True)
 
+    # hostname
+    with open(os.path.join(name, 'etc', 'hostname'), 'w', encoding='utf-8') as f:
+        f.write(hostname + "\n")
+
+    # user
+    command = [
+        'chroot', name,
+        'adduser', '--gecos', '', '--disabled-password', 'linaro',
+    ]
+    completed_process = subprocess.run(command, check=True)
+
+    command = [
+        'chroot', name, 'chpasswd',
+        ]
+    process = subprocess.Popen(command, stdin=subprocess.PIPE, text=True)
+    process.communicate(input='linaro:linaro')
+
+    # root password
+    process = subprocess.Popen(command, stdin=subprocess.PIPE, text=True)
+    process.communicate(input="root:root")
+
     compress(name)
 
 
 if __name__ == "__main__":
+    if os.getuid() != 0:
+        print("This script should be run as root: this is required by deboostrap", file=sys.stderr)
+        sys.exit(1)
     main()
-- 
2.34.1