X-Git-Url: http://git.liburcu.org/?a=blobdiff_plain;f=scripts%2Fliburcu%2Fbuild.sh;h=b1dcb012e67db5043f27d81a60521d4e49da4180;hb=447eaf93d4d6fbb76c0dc5703929969e4a7fef59;hp=b4cc761e3eef10717d30e49b42c7f5e0f4fd8be0;hpb=4174b905424b75e342b3bd0c68789ef021b61778;p=lttng-ci.git diff --git a/scripts/liburcu/build.sh b/scripts/liburcu/build.sh index b4cc761..b1dcb01 100755 --- a/scripts/liburcu/build.sh +++ b/scripts/liburcu/build.sh @@ -1,20 +1,8 @@ #!/bin/bash # -# Copyright (C) 2015 Jonathan Rajotte-Julien -# Copyright (C) 2016-2020 Michael Jeanson -# -# This program is free software: you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published by -# the Free Software Foundation, either version 3 of the License, or -# (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program. If not, see . +# SPDX-FileCopyrightText: 2015 Jonathan Rajotte-Julien +# SPDX-FileCopyrightText: 2016-2023 Michael Jeanson +# SPDX-License-Identifier: GPL-2.0-or-later set -exu @@ -73,26 +61,52 @@ verne() { [ "$res" -ne "0" ] } +print_header() { + set +x + + local message=" $1 " + local message_len + local padding_len + + message_len="${#message}" + padding_len=$(( (80 - (message_len)) / 2 )) + + printf '\n'; printf -- '#%.0s' {1..80}; printf '\n' + printf -- '-%.0s' {1..80}; printf '\n' + printf -- '#%.0s' $(seq 1 $padding_len); printf '%s' "$message"; printf -- '#%.0s' $(seq 1 $padding_len); printf '\n' + printf -- '-%.0s' {1..80}; printf '\n' + printf -- '#%.0s' {1..80}; printf '\n\n' + + set -x +} + failed_configure() { # Assume we are in the configured build directory - echo "#################### BEGIN config.log ####################" + print_header "BEGIN config.log" cat config.log - echo "#################### END config.log ####################" + print_header "END config.log" # End the build with failure exit 1 } +print_header "Liburcu build script starting" + # Required variables WORKSPACE=${WORKSPACE:-} +# Axis platform=${platform:-} conf=${conf:-} build=${build:-} cc=${cc:-} -# Controls if the tests are run -USERSPACE_RCU_RUN_TESTS="${USERSPACE_RCU_RUN_TESTS:=yes}" +# Build steps that can be overriden by the environment +USERSPACE_RCU_MAKE_INSTALL="${USERSPACE_RCU_MAKE_INSTALL:-yes}" +USERSPACE_RCU_MAKE_CLEAN="${USERSPACE_RCU_MAKE_CLEAN:-yes}" +USERSPACE_RCU_GEN_COMPILE_COMMANDS="${USERSPACE_RCU_GEN_COMPILE_COMMANDS:-no}" +USERSPACE_RCU_RUN_TESTS="${USERSPACE_RCU_RUN_TESTS:-yes}" +USERSPACE_RCU_CLANG_TIDY="${USERSPACE_RCU_CLANG_TIDY:-no}" SRCDIR="$WORKSPACE/src/liburcu" TMPDIR="$WORKSPACE/tmp" @@ -102,19 +116,28 @@ LIBDIR_ARCH="$LIBDIR" # RHEL and SLES both use lib64 but don't bother shipping a default autoconf # site config that matches this. -if [[ ( -f /etc/redhat-release || -f /etc/SuSE-release || -f /etc/yocto-release ) ]]; then +if [[ ( -f /etc/redhat-release || -f /etc/products.d/SLES.prod || -f /etc/yocto-release ) ]]; then # Detect the userspace bitness in a distro agnostic way if file -L /bin/bash | grep '64-bit' >/dev/null 2>&1; then LIBDIR_ARCH="${LIBDIR}64" fi fi +exit_status=0 + +# Use bear to generate compile_commands.json when enabled +BEAR="" +if [ "$USERSPACE_RCU_GEN_COMPILE_COMMANDS" = "yes" ]; then + BEAR="bear" +fi + # Create tmp directory rm -rf "$TMPDIR" mkdir -p "$TMPDIR" export TMPDIR export CFLAGS="-g -O2" +export CXXFLAGS="-g -O2" # Set compiler variables case "$cc" in @@ -141,11 +164,6 @@ clang-*) ;; esac -if [ "x${CC:-}" != "x" ]; then - echo "Selected compiler:" - "$CC" -v -fi - # Set platform variables case "$platform" in macos*) @@ -179,6 +197,7 @@ freebsd*) esac # Print build env details +print_header "Build environment details" print_os || true print_tooling || true @@ -186,6 +205,7 @@ print_tooling || true cd "$SRCDIR" # Run bootstrap in the source directory prior to configure +print_header "Bootstrap autotools" ./bootstrap # Get source version from configure script @@ -194,21 +214,23 @@ PACKAGE_VERSION=${PACKAGE_VERSION//\-pre*/} # Set configure options and environment variables for each build # configuration. -CONF_OPTS=("--prefix=$PREFIX" "--libdir=$PREFIX/$LIBDIR_ARCH") +CONF_OPTS=("--prefix=$PREFIX" "--libdir=$PREFIX/$LIBDIR_ARCH" "--disable-maintainer-mode") case "$conf" in static) - echo "Static lib only configuration" + print_header "Conf: Static lib only" CONF_OPTS+=("--enable-static" "--disable-shared") ;; tls_fallback) - echo "Using pthread_getspecific() to emulate TLS" + print_header "Conf: Use pthread_getspecific() to emulate TLS" + CONF_OPTS+=("--disable-compiler-tls") ;; debug-rcu) - echo "Enable RCU sanity checks for debugging" + print_header "Conf: Enable RCU sanity checks for debugging" + if vergte "$PACKAGE_VERSION" "0.10"; then CONF_OPTS+=("--enable-rcu-debug") else @@ -222,7 +244,7 @@ debug-rcu) ;; *) - echo "Standard configuration" + print_header "Conf: Standard" ;; esac @@ -236,7 +258,7 @@ esac # before continuing. case "$build" in oot) - echo "Out of tree build" + print_header "Build: Out of tree" # Create and enter a temporary build directory builddir=$(mktemp -d) @@ -246,7 +268,7 @@ oot) ;; dist) - echo "Distribution in-tree build" + print_header "Build: Distribution In-tree" # Run configure and generate the tar file # in the source directory @@ -266,7 +288,7 @@ dist) ;; oot-dist) - echo "Distribution out of tree build" + print_header "Build: Distribution Out of tree" # Create and enter a temporary build directory builddir=$(mktemp -d) @@ -293,7 +315,8 @@ oot-dist) ;; *) - echo "Standard in-tree build" + print_header "Build: Standard In-tree" + ./configure "${CONF_OPTS[@]}" || failed_configure ;; esac @@ -301,18 +324,62 @@ esac # We are now inside a configured build directory # BUILD! -$MAKE -j "$($NPROC)" V=1 +print_header "BUILD!" +$BEAR ${BEAR:+--} $MAKE -j "$($NPROC)" V=1 + +# Install in the workspace if enabled +if [ "$USERSPACE_RCU_MAKE_INSTALL" = "yes" ]; then + print_header "Install" + + $MAKE install V=1 DESTDIR="$WORKSPACE" + + # Cleanup rpath in executables and shared libraries + #find "$WORKSPACE/$PREFIX/bin" -type f -perm -0500 -exec chrpath --delete {} \; + find "$WORKSPACE/$PREFIX/$LIBDIR_ARCH" -name "*.so" -exec chrpath --delete {} \; + + # Remove libtool .la files + find "$WORKSPACE/$PREFIX/$LIBDIR_ARCH" -name "*.la" -delete +fi + +# Run clang-tidy on the topmost commit +if [ "$USERSPACE_RCU_CLANG_TIDY" = "yes" ]; then + print_header "Run clang-tidy" -# Install in the workspace -$MAKE install DESTDIR="$WORKSPACE" + # This would be better by linting only the lines touched by a patch but it + # doesn't seem to work, the lines are always filtered and no error is + # reported. + #git diff -U0 HEAD^ | clang-tidy-diff -p1 -j "$($NPROC)" -timeout 60 -fix -# Run tests, don't fail now, we want to run the archiving steps -failed_tests=0 + # Instead, run clan-tidy on all the files touched by the patch. + while read -r filepath; do + if [[ "$filepath" =~ (\.cpp|\.hhp|\.c|\.h)$ ]]; then + clang-tidy --fix-errors "$(realpath "$filepath")" + fi + done < <(git diff-tree --no-commit-id --diff-filter=d --name-only -r HEAD) + + # If the tree has local changes, the formatting was incorrect + GIT_DIFF_OUTPUT=$(git diff) + if [ -n "$GIT_DIFF_OUTPUT" ]; then + echo "Saving clang-tidy proposed fixes in clang-tidy-fixes.diff" + git diff > "$WORKSPACE/clang-tidy-fixes.diff" + + # Restore the unfixed files so they can be viewed in the warnings web + # interface + git checkout . + exit_status=1 + fi +fi + +# Run tests if enabled if [ "$USERSPACE_RCU_RUN_TESTS" = "yes" ]; then - $MAKE --keep-going check || failed_tests=1 + print_header "Run test suite" + + # Run tests, don't fail now, we want to run the archiving steps + $MAKE --keep-going check || exit_status=1 + # Only run regtest for 0.9 and up if vergte "$PACKAGE_VERSION" "0.9"; then - $MAKE --keep-going regtest || failed_tests=1 + $MAKE --keep-going regtest || exit_status=1 fi # Copy tap logs for the jenkins tap parser before cleaning the build dir @@ -330,16 +397,15 @@ if [ "$USERSPACE_RCU_RUN_TESTS" = "yes" ]; then fi # Clean the build directory -$MAKE clean - -# Cleanup rpath in executables and shared libraries -#find "$WORKSPACE/$PREFIX/bin" -type f -perm -0500 -exec chrpath --delete {} \; -find "$WORKSPACE/$PREFIX/$LIBDIR_ARCH" -name "*.so" -exec chrpath --delete {} \; +if [ "$USERSPACE_RCU_MAKE_CLEAN" = "yes" ]; then + print_header "Clean" + $MAKE clean +fi -# Remove libtool .la files -find "$WORKSPACE/$PREFIX/$LIBDIR_ARCH" -name "*.la" -exec rm -f {} \; +print_header "Liburcu build script ended with: $(test $exit_status == 0 && echo SUCCESS || echo FAILURE)" # Exit with failure if any of the tests failed -exit $failed_tests +exit $exit_status # EOF +# vim: expandtab tabstop=4 shiftwidth=4