X-Git-Url: http://git.liburcu.org/?a=blobdiff_plain;f=liblttng-ust%2Flttng-ust-comm.c;h=5c4e4e76609b9d637ace3622505c27304f19d618;hb=e81a53afbf8fc88951cace52adc45bb02994fe55;hp=d35511b2f1afecc7bf16a10317955130c6cbc175;hpb=69400ac4a4e6575f749c6326df7c2a2c8ac3bdc5;p=lttng-ust.git

diff --git a/liblttng-ust/lttng-ust-comm.c b/liblttng-ust/lttng-ust-comm.c
index d35511b2..5c4e4e76 100644
--- a/liblttng-ust/lttng-ust-comm.c
+++ b/liblttng-ust/lttng-ust-comm.c
@@ -37,14 +37,14 @@
 #include <signal.h>
 #include <urcu/uatomic.h>
 #include <urcu/futex.h>
+#include <urcu/compiler.h>
 
-#include <lttng/ust-comm.h>
 #include <lttng/ust-events.h>
-#include <lttng/usterr-signal-safe.h>
 #include <lttng/ust-abi.h>
-#include <lttng/tracepoint.h>
-#include <lttng/tracepoint-internal.h>
 #include <lttng/ust.h>
+#include <ust-comm.h>
+#include <usterr-signal-safe.h>
+#include "tracepoint-internal.h"
 #include "ltt-tracer-core.h"
 
 /*
@@ -167,6 +167,7 @@ int register_app_to_sessiond(int socket)
 		pid_t ppid;
 		uid_t uid;
 		gid_t gid;
+		uint32_t bits_per_long;
 		char name[16];	/* process name */
 	} reg_msg;
 
@@ -176,6 +177,7 @@ int register_app_to_sessiond(int socket)
 	reg_msg.ppid = getppid();
 	reg_msg.uid = getuid();
 	reg_msg.gid = getgid();
+	reg_msg.bits_per_long = CAA_BITS_PER_LONG;
 	prctl_ret = prctl(PR_GET_NAME, (unsigned long) reg_msg.name, 0, 0, 0);
 	if (prctl_ret) {
 		ERR("Error executing prctl");
@@ -301,9 +303,12 @@ end:
 		shm_fd = lum->u.channel.shm_fd;
 		wait_fd = lum->u.channel.wait_fd;
 		break;
-	case LTTNG_UST_VERSION:
+	case LTTNG_UST_TRACER_VERSION:
 		lur.u.version = lum->u.version;
 		break;
+	case LTTNG_UST_TRACEPOINT_LIST_GET:
+		memcpy(&lur.u.tracepoint, &lum->u.tracepoint, sizeof(lur.u.tracepoint));
+		break;
 	}
 	ret = send_reply(sock, &lur);
 	if (ret < 0) {
@@ -556,14 +561,14 @@ void wait_for_sessiond(struct sock_info *sock_info)
 		if (ret < 0) {
 			if (errno == EFAULT) {
 				wait_poll_fallback = 1;
-				WARN(
+				DBG(
 "Linux kernels 2.6.33 to 3.0 (with the exception of stable versions) "
 "do not support FUTEX_WAKE on read-only memory mappings correctly. "
 "Please upgrade your kernel "
 "(fix is commit 9ea71503a8ed9184d2d0b8ccc4d269d05f7940ae in Linux kernel "
 "mainline). LTTng-UST will use polling mode fallback.");
+				PERROR("futex");
 			}
-			PERROR("futex");
 		}
 	}
 	return;
@@ -625,7 +630,7 @@ restart:
 	/* Register */
 	ret = ustcomm_connect_unix_sock(sock_info->sock_path);
 	if (ret < 0) {
-		ERR("Error connecting to %s apps socket", sock_info->name);
+		DBG("Info: sessiond not accepting connections to %s apps socket", sock_info->name);
 		prev_connect_failed = 1;
 		/*
 		 * If we cannot find the sessiond daemon, don't delay
@@ -676,6 +681,20 @@ restart:
 		switch (len) {
 		case 0:	/* orderly shutdown */
 			DBG("%s ltt-sessiond has performed an orderly shutdown\n", sock_info->name);
+			ust_lock();
+			/*
+			 * Either sessiond has shutdown or refused us by closing the socket.
+			 * In either case, we don't want to delay construction execution,
+			 * and we need to wait before retry.
+			 */
+			prev_connect_failed = 1;
+			/*
+			 * If we cannot register to the sessiond daemon, don't
+			 * delay constructor execution.
+			 */
+			ret = handle_register_done(sock_info);
+			assert(!ret);
+			ust_unlock();
 			goto end;
 		case sizeof(lum):
 			DBG("message received\n");
@@ -685,6 +704,7 @@ restart:
 			}
 			continue;
 		case -1:
+			DBG("Receive failed from lttng-sessiond with errno %d", errno);
 			if (errno == ECONNRESET) {
 				ERR("%s remote end closed connection\n", sock_info->name);
 				goto end;
@@ -871,7 +891,7 @@ void __attribute__((destructor)) lttng_ust_exit(void)
  * in the middle of an tracepoint or ust tracing state modification.
  * Holding this mutex protects these structures across fork and clone.
  */
-void ust_before_fork(ust_fork_info_t *fork_info)
+void ust_before_fork(sigset_t *save_sigset)
 {
 	/*
 	 * Disable signals. This is to avoid that the child intervenes
@@ -884,7 +904,7 @@ void ust_before_fork(ust_fork_info_t *fork_info)
 
 	/* Disable signals */
 	sigfillset(&all_sigs);
-	ret = sigprocmask(SIG_BLOCK, &all_sigs, &fork_info->orig_sigs);
+	ret = sigprocmask(SIG_BLOCK, &all_sigs, save_sigset);
 	if (ret == -1) {
 		PERROR("sigprocmask");
 	}
@@ -892,25 +912,25 @@ void ust_before_fork(ust_fork_info_t *fork_info)
 	rcu_bp_before_fork();
 }
 
-static void ust_after_fork_common(ust_fork_info_t *fork_info)
+static void ust_after_fork_common(sigset_t *restore_sigset)
 {
 	int ret;
 
 	DBG("process %d", getpid());
 	ust_unlock();
 	/* Restore signals */
-	ret = sigprocmask(SIG_SETMASK, &fork_info->orig_sigs, NULL);
+	ret = sigprocmask(SIG_SETMASK, restore_sigset, NULL);
 	if (ret == -1) {
 		PERROR("sigprocmask");
 	}
 }
 
-void ust_after_fork_parent(ust_fork_info_t *fork_info)
+void ust_after_fork_parent(sigset_t *restore_sigset)
 {
 	DBG("process %d", getpid());
 	rcu_bp_after_fork_parent();
 	/* Release mutexes and reenable signals */
-	ust_after_fork_common(fork_info);
+	ust_after_fork_common(restore_sigset);
 }
 
 /*
@@ -922,7 +942,7 @@ void ust_after_fork_parent(ust_fork_info_t *fork_info)
  * This is meant for forks() that have tracing in the child between the
  * fork and following exec call (if there is any).
  */
-void ust_after_fork_child(ust_fork_info_t *fork_info)
+void ust_after_fork_child(sigset_t *restore_sigset)
 {
 	DBG("process %d", getpid());
 	/* Release urcu mutexes */
@@ -930,6 +950,6 @@ void ust_after_fork_child(ust_fork_info_t *fork_info)
 	lttng_ust_cleanup(0);
 	lttng_context_vtid_reset();
 	/* Release mutexes and reenable signals */
-	ust_after_fork_common(fork_info);
+	ust_after_fork_common(restore_sigset);
 	lttng_ust_init();
 }