DBG("Destroying session %s", session->name);
del_session_list(session);
pthread_mutex_destroy(&session->lock);
+
+ rcu_read_lock();
+ consumer_destroy_output(session->consumer);
+ rcu_read_unlock();
free(session);
return LTTCOMM_OK;
ret = LTTCOMM_FATAL;
goto error_asprintf;
}
+ new_session->start_consumer = 1;
} else {
- ERR("No session path given");
- ret = LTTCOMM_FATAL;
- goto error;
+ /* No path indicates that there is no use for a consumer. */
+ new_session->start_consumer = 0;
+ new_session->path[0] = '\0';
}
/* Init kernel session */
new_session->uid = uid;
new_session->gid = gid;
- /* Mkdir if we have a valid path length */
+ /* Mkdir if we have a valid path and length */
if (strlen(new_session->path) > 0) {
ret = run_as_mkdir_recursive(new_session->path, S_IRWXU | S_IRWXG,
new_session->uid, new_session->gid);
new_session->id = add_session_list(new_session);
session_unlock_list();
- DBG("Tracing session %s created in %s with ID %u by UID %d GID %d",
- name, path, new_session->id,
- new_session->uid, new_session->gid);
+ /*
+ * Consumer is let to NULL since the create_session_uri command will set it
+ * up and, if valid, assign it to the session.
+ */
+
+ DBG("Tracing session %s created in %s with ID %u by UID %d GID %d", name,
+ path, new_session->id, new_session->uid, new_session->gid);
return LTTCOMM_OK;
error_malloc:
return ret;
}
+
+/*
+ * Check if the UID or GID match the session. Root user has access to all
+ * sessions.
+ */
+int session_access_ok(struct ltt_session *session, uid_t uid, gid_t gid)
+{
+ assert(session);
+
+ if (uid != session->uid && gid != session->gid && uid != 0) {
+ return 0;
+ } else {
+ return 1;
+ }
+}