Fix: error out on leftover arguments

[lttng-tools.git] / src / bin / lttng / commands / save.c

diff --git a/src/bin/lttng/commands/save.c b/src/bin/lttng/commands/save.c
index 958d1afc5b819e2ab5b155ba970facd411a4f510..808216bf99d10ea203a4ce234c0a2c0aa22de6cc 100644 (file)
--- a/src/bin/lttng/commands/save.c
+++ b/src/bin/lttng/commands/save.c
@@ -29,8 +29,8 @@
 #include <lttng/save.h>
 
 static char *opt_output_path;
-static int opt_force;
-static int opt_save_all;
+static bool opt_force;
+static bool opt_save_all;
 static struct mi_writer *writer;
 
 enum {
@@ -121,7 +121,7 @@ int cmd_save(int argc, const char **argv)
 {
        int ret = CMD_SUCCESS, command_ret = CMD_SUCCESS, success;
        int opt;
-       const char *session_name = NULL;
+       const char *session_name = NULL, *leftover = NULL;
        poptContext pc;
        struct lttng_save_session_attr *attr;
 
@@ -134,10 +134,10 @@ int cmd_save(int argc, const char **argv)
                        SHOW_HELP();
                        goto end;
                case OPT_ALL:
-                       opt_save_all = 1;
+                       opt_save_all = true;
                        break;
                case OPT_FORCE:
-                       opt_force = 1;
+                       opt_force = true;
                        break;
                case OPT_LIST_OPTIONS:
                        list_cmd_options(stdout, save_opts);
@@ -154,10 +154,17 @@ int cmd_save(int argc, const char **argv)
                        DBG2("Session name: %s", session_name);
                } else {
                        /* default to opt_save_all */
-                       opt_save_all = 1;
+                       opt_save_all = true;
                }
        }
 
+       leftover = poptGetArg(pc);
+       if (leftover) {
+               ERR("Unknown argument: %s", leftover);
+               ret = CMD_ERROR;
+               goto end;
+       }
+
        attr = lttng_save_session_attr_create();
        if (!attr) {
                ret = CMD_FATAL;