state hooks bug fixed
[lttv.git] / ltt / branches / poly / lttv / lttv / tracecontext.c
index 2a813151d653cfae8cc7700eaeab96e650a79a07..970da06454407f05b1bea32c6f0b9c5ffc3c5084 100644 (file)
@@ -39,7 +39,7 @@ gint compare_tracefile(gconstpointer a, gconstpointer b)
   const LttvTracefileContext *trace_b = (const LttvTracefileContext *)b;
 
   if(likely(trace_a != trace_b)) {
-    comparison = ltt_time_compare(trace_a->timestamp, trace_b->timestamp);
+    comparison = ltt_time_compare(trace_b->timestamp, trace_a->timestamp);
     if(unlikely(comparison == 0)) {
       if(trace_a->index < trace_b->index) comparison = -1;
       else if(trace_a->index > trace_b->index) comparison = 1;
@@ -165,7 +165,7 @@ static void init_tracefile_context(LttTracefile *tracefile,
 static void
 init(LttvTracesetContext *self, LttvTraceset *ts)
 {
-  guint i, j, nb_trace, nb_control, nb_per_cpu, nb_tracefile;
+  guint i, j, nb_trace;
 
   LttvTraceContext *tc;
 
@@ -192,13 +192,14 @@ init(LttvTracesetContext *self, LttvTraceset *ts)
                         sizeof(LttvTracefileContext*), 10);
 
     tracefiles_groups = ltt_trace_get_tracefiles_groups(tc->t);
+    if(tracefiles_groups != NULL) {
+      args.func = (ForEachTraceFileFunc)init_tracefile_context;
+      args.func_args = tc;
 
-    args.func = (ForEachTraceFileFunc)init_tracefile_context;
-    args.func_args = tc;
-
-    g_datalist_foreach(tracefiles_groups, 
-                          (GDataForeachFunc)compute_tracefile_group,
-                          &args);
+      g_datalist_foreach(tracefiles_groups, 
+                            (GDataForeachFunc)compute_tracefile_group,
+                            &args);
+    }
       
 #if 0
     nb_control = ltt_trace_control_tracefile_number(tc->t);
@@ -242,12 +243,10 @@ void fini(LttvTracesetContext *self)
 
   LttvTraceContext *tc;
 
-  LttvTracefileContext *tfc;
+  LttvTracefileContext **tfc;
 
   LttvTraceset *ts = self->ts;
 
-  //FIXME : segfault
-
   g_tree_destroy(self->pqueue);
   g_object_unref(self->a);
 
@@ -261,11 +260,11 @@ void fini(LttvTracesetContext *self)
     nb_tracefile = tc->tracefiles->len;
 
     for(j = 0 ; j < nb_tracefile ; j++) {
-      tfc = g_array_index(tc->tracefiles, LttvTracefileContext*, j);
-      lttv_hooks_destroy(tfc->event);
-      lttv_hooks_by_id_destroy(tfc->event_by_id);
-      g_object_unref(tfc->a);
-      g_object_unref(tfc);
+      tfc = &g_array_index(tc->tracefiles, LttvTracefileContext*, j);
+      lttv_hooks_destroy((*tfc)->event);
+      lttv_hooks_by_id_destroy((*tfc)->event_by_id);
+      g_object_unref((*tfc)->a);
+      g_object_unref(*tfc);
     }
     g_array_free(tc->tracefiles, TRUE);
     g_object_unref(tc);
@@ -340,15 +339,15 @@ void lttv_trace_context_add_hooks(LttvTraceContext *self,
 {
   guint i, nb_tracefile;
 
-  LttvTracefileContext *tfc;
+  LttvTracefileContext **tfc;
 
   lttv_hooks_call(before_trace, self);
 
   nb_tracefile = self->tracefiles->len;
 
   for(i = 0 ; i < nb_tracefile ; i++) {
-    tfc = g_array_index(self->tracefiles, LttvTracefileContext*, i);
-    lttv_tracefile_context_add_hooks(tfc,
+    tfc = &g_array_index(self->tracefiles, LttvTracefileContext*, i);
+    lttv_tracefile_context_add_hooks(*tfc,
                                      before_tracefile,
                                      event,
                                      event_by_id);
@@ -365,13 +364,13 @@ void lttv_trace_context_remove_hooks(LttvTraceContext *self,
 {
   guint i, nb_tracefile;
 
-  LttvTracefileContext *tfc;
+  LttvTracefileContext **tfc;
 
   nb_tracefile = self->tracefiles->len;
 
   for(i = 0 ; i < nb_tracefile ; i++) {
-    tfc = g_array_index(self->tracefiles, LttvTracefileContext*, i);
-    lttv_tracefile_context_remove_hooks(tfc,
+    tfc = &g_array_index(self->tracefiles, LttvTracefileContext*, i);
+    lttv_tracefile_context_remove_hooks(*tfc,
                                         after_tracefile,
                                         event,
                                         event_by_id);
@@ -614,10 +613,30 @@ lttv_tracefile_context_get_type(void)
 
 
 static gboolean get_first(gpointer key, gpointer value, gpointer user_data) {
+  g_assert(key == value);
   *((LttvTracefileContext **)user_data) = (LttvTracefileContext *)value;
   return TRUE;
 }
 
+static gboolean test_tree(gpointer key, gpointer value, gpointer user_data) {
+
+  LttvTracefileContext *tfc = (LttvTracefileContext *)key;
+
+  g_debug("Tracefile name %s, time %lu.%lu, tfi %u, ti %u",
+      g_quark_to_string(ltt_tracefile_name(tfc->tf)),
+      tfc->timestamp.tv_sec, tfc->timestamp.tv_nsec,
+      tfc->index, tfc->t_context->index);
+
+  if(((LttvTracefileContext *)user_data) == (LttvTracefileContext *)value) {
+    g_assert(compare_tracefile(user_data, value) == 0);
+  } else
+    g_assert(compare_tracefile(user_data, value) != 0);
+  
+  //g_assert(((LttvTracefileContext *)user_data) != (LttvTracefileContext *)value);
+  return FALSE;
+}
+
+
 
 void lttv_process_traceset_begin(LttvTracesetContext *self,
                                  LttvHooks       *before_traceset,
@@ -646,7 +665,7 @@ guint lttv_process_traceset_middle(LttvTracesetContext *self,
 {
   GTree *pqueue = self->pqueue;
 
-  guint id;
+  guint fac_id, ev_id, id;
 
   LttvTracefileContext *tfc;
 
@@ -654,6 +673,8 @@ guint lttv_process_traceset_middle(LttvTracesetContext *self,
   
   unsigned count = 0;
 
+  guint read_ret = FALSE;
+
   gboolean last_ret = FALSE; /* return value of the last hook list called */
 
   /* Get the next event from the pqueue, call its hooks, 
@@ -690,18 +711,41 @@ guint lttv_process_traceset_middle(LttvTracesetContext *self,
     /* Get the tracefile with an event for the smallest time found. If two
        or more tracefiles have events for the same time, hope that lookup
        and remove are consistent. */
-
+#ifdef DEBUG
+    g_debug("test tree before remove");
+    g_tree_foreach(pqueue, test_tree, tfc);
+#endif //DEBUG
     g_tree_remove(pqueue, tfc);
+
+#ifdef DEBUG
+    g_debug("test tree after remove");
+    g_tree_foreach(pqueue, test_tree, tfc);
+#endif //DEBUG
+
     count++;
     
     e = ltt_tracefile_get_event(tfc->tf);
-    id = ltt_event_eventtype_id(e);
+    fac_id = ltt_event_facility_id(e);
+    ev_id = ltt_event_eventtype_id(e);
+    id = GET_HOOK_ID(fac_id, ev_id);
     last_ret = lttv_hooks_call_merge(tfc->event, tfc,
                         lttv_hooks_by_id_get(tfc->event_by_id, id), tfc);
 
-    if(likely(!ltt_tracefile_read(tfc->tf))) {
+    read_ret = ltt_tracefile_read(tfc->tf);
+
+    if(likely(!read_ret)) {
+      g_debug("An event is ready");
       tfc->timestamp = ltt_event_time(e);
+      
            g_tree_insert(pqueue, tfc, tfc);
+    } else {
+      tfc->timestamp = ltt_time_infinite;
+
+      if(read_ret == ERANGE)
+        g_debug("End of trace");
+      else
+        g_error("Error happened in lttv_process_traceset_middle");
     }
   }
 }
@@ -733,21 +777,25 @@ void lttv_process_trace_seek_time(LttvTraceContext *self, LttTime start)
 
   gint ret;
   
-  LttvTracefileContext *tfc;
+  LttvTracefileContext **tfc;
 
   GTree *pqueue = self->ts_context->pqueue;
 
   nb_tracefile = self->tracefiles->len;
 
   for(i = 0 ; i < nb_tracefile ; i++) {
-    tfc = g_array_index(self->tracefiles, LttvTracefileContext*, i);
-    ret = ltt_tracefile_seek_time(tfc->tf, start);
+    tfc = &g_array_index(self->tracefiles, LttvTracefileContext*, i);
+
+    g_tree_remove(pqueue, *tfc);
+    
+    ret = ltt_tracefile_seek_time((*tfc)->tf, start);
     if(ret == EPERM) g_error("error in lttv_process_trace_seek_time seek");
-    g_tree_remove(pqueue, tfc);
 
     if(ret == 0) { /* not ERANGE especially */
-      tfc->timestamp = ltt_event_time(ltt_tracefile_get_event(tfc->tf));
-      g_tree_insert(pqueue, tfc, tfc);
+      (*tfc)->timestamp = ltt_event_time(ltt_tracefile_get_event((*tfc)->tf));
+      g_tree_insert(pqueue, (*tfc), (*tfc));
+    } else {
+      (*tfc)->timestamp = ltt_time_infinite;
     }
   }
 }
@@ -778,12 +826,16 @@ gboolean lttv_process_traceset_seek_position(LttvTracesetContext *self,
   self->pqueue = g_tree_new(compare_tracefile);
   
   for(i=0;i<pos->ep->len; i++) {
-    LttEventPosition *ep = g_array_index(pos->ep, LttEventPosition*, i);
-    LttvTracefileContext *tfc = 
-      g_array_index(pos->tfc, LttvTracefileContext*, i);
-    g_assert(ltt_tracefile_seek_position(tfc->tf, ep) == 0);
-    tfc->timestamp = ltt_event_time(ltt_tracefile_get_event(tfc->tf));
-    g_tree_insert(self->pqueue, tfc, tfc);
+    LttEventPosition **ep = &g_array_index(pos->ep, LttEventPosition*, i);
+    LttvTracefileContext **tfc = 
+      &g_array_index(pos->tfc, LttvTracefileContext*, i);
+    if(*ep != NULL) {
+      g_assert(ltt_tracefile_seek_position((*tfc)->tf, *ep) == 0);
+      (*tfc)->timestamp = ltt_event_time(ltt_tracefile_get_event((*tfc)->tf));
+      g_tree_insert(self->pqueue, (*tfc), (*tfc));
+    } else {
+      (*tfc)->timestamp = ltt_time_infinite;
+    }
   }
   return TRUE;
 }
@@ -849,7 +901,7 @@ lttv_trace_find_hook(LttTrace *t, GQuark facility, GQuark event,
   LttvTraceHookByFacility *thf, *first_thf;
 
   facilities = ltt_trace_facility_get_by_name(t, facility);
-  
+
   if(unlikely(facilities == NULL)) goto facility_error;
 
   th->fac_index = g_array_sized_new(FALSE, TRUE,
@@ -869,8 +921,7 @@ lttv_trace_find_hook(LttTrace *t, GQuark facility, GQuark event,
   if(unlikely(et == NULL)) goto event_error;
   
   thf = &g_array_index(th->fac_index, LttvTraceHookByFacility, fac_id);
-  g_array_index(th->fac_list, LttvTraceHookByFacility*, 0)
-        = thf;
+  g_array_index(th->fac_list, LttvTraceHookByFacility*, 0) = thf;
 
   ev_id = ltt_eventtype_id(et);
   
@@ -891,8 +942,7 @@ lttv_trace_find_hook(LttTrace *t, GQuark facility, GQuark event,
     if(unlikely(et == NULL)) goto event_error;
     
     thf = &g_array_index(th->fac_index, LttvTraceHookByFacility, fac_id);
-    g_array_index(th->fac_list, LttvTraceHookByFacility*, i)
-          = thf;
+    g_array_index(th->fac_list, LttvTraceHookByFacility*, i) = thf;
     ev_id = ltt_eventtype_id(et);
     thf->h = h;
     thf->id = GET_HOOK_ID(fac_id, ev_id);
@@ -949,38 +999,51 @@ LttvTracesetContextPosition *lttv_traceset_context_position_new()
   return pos;
 }
 
-gboolean traverse_get_tfc(gpointer key, gpointer value, gpointer data)
-{
-  LttvTracefileContext *tfc = (LttvTracefileContext *)value;
-  LttvTracesetContextPosition *pos = (LttvTracesetContextPosition *)data;
-
-  LttEvent *event = ltt_tracefile_get_event(tfc->tf);
-  LttEventPosition *ep = ltt_event_position_new();
-  
-  ltt_event_position(event, ep);
-
-  g_array_append_val(pos->ep, ep);
-  g_array_append_val(pos->tfc, tfc);
-
-  if(ltt_time_compare(tfc->timestamp, pos->timestamp) < 0)
-    pos->timestamp = tfc->timestamp;
-  
-  return 0;
-}
-
-/* Subtile modification :
- * only save the tracefiles that are loaded in the pqueue */
+/* Save all positions, the ones not in the pqueue will have NULL
+ * ep. */
 void lttv_traceset_context_position_save(const LttvTracesetContext *self,
                                     LttvTracesetContextPosition *pos)
 {
-  g_tree_foreach(self->pqueue, traverse_get_tfc, pos);
+  guint i;
+  guint num_traces = lttv_traceset_number(self->ts);
+
+  for(i=0; i<num_traces;i++) {
+    GArray * tracefiles = self->traces[i]->tracefiles;
+    guint j;
+    guint num_tracefiles = tracefiles->len;
+
+    for(j=0;j<num_tracefiles;j++) {
+      LttvTracefileContext **tfc = &g_array_index(tracefiles,
+          LttvTracefileContext*, j);
+
+      LttEvent *event = ltt_tracefile_get_event((*tfc)->tf);
+      LttEventPosition *ep;
+
+      if(ltt_time_compare((*tfc)->timestamp, ltt_time_infinite) != 0) {
+        ep = ltt_event_position_new();
+        ltt_event_position(event, ep);
+        if(ltt_time_compare((*tfc)->timestamp, pos->timestamp) < 0)
+          pos->timestamp = (*tfc)->timestamp;
+      } else {
+        ep = NULL;
+      }
+      g_array_append_val(pos->tfc, *tfc);
+      g_array_append_val(pos->ep, ep);
+    }
+
+  }
 }
 
 void lttv_traceset_context_position_destroy(LttvTracesetContextPosition *pos)
 {
   int i;
-  for(i=0;i<pos->ep->len;i++)
-    g_free(g_array_index(pos->ep, LttEventPosition*, i));
+  LttEventPosition **ep;
+  
+  for(i=0;i<pos->ep->len;i++) {
+    ep = &g_array_index(pos->ep, LttEventPosition*, i);
+    if(*ep != NULL)
+      g_free(*ep);
+  }
   g_array_free(pos->ep, TRUE);
   g_array_free(pos->tfc, TRUE);
   g_free(pos);
@@ -990,15 +1053,21 @@ void lttv_traceset_context_position_copy(LttvTracesetContextPosition *dest,
                                    const LttvTracesetContextPosition *src)
 {
   int i;
+  LttEventPosition **src_ep, **dest_ep;
   
   g_array_set_size(dest->ep, src->ep->len);
   g_array_set_size(dest->tfc, src->tfc->len);
   
   for(i=0;i<src->ep->len;i++) {
-    g_array_index(dest->ep, LttEventPosition*, i) = ltt_event_position_new();
-    ltt_event_position_copy(
-        g_array_index(dest->ep, LttEventPosition*, i),
-        g_array_index(src->ep, LttEventPosition*, i));
+    src_ep = &g_array_index(src->ep, LttEventPosition*, i);
+    dest_ep = &g_array_index(dest->ep, LttEventPosition*, i);
+    if(*src_ep != NULL) {
+      *dest_ep = ltt_event_position_new();
+      ltt_event_position_copy(
+          *dest_ep,
+          *src_ep);
+    } else
+      *dest_ep = NULL;
   }
   for(i=0;i<src->tfc->len;i++) {
     g_array_index(dest->tfc, LttvTracefileContext*, i) =
@@ -1017,11 +1086,21 @@ gint lttv_traceset_context_ctx_pos_compare(const LttvTracesetContext *self,
     LttEventPosition *ep = g_array_index(pos->ep, LttEventPosition*, i);
     LttvTracefileContext *tfc = 
       g_array_index(pos->tfc, LttvTracefileContext*, i);
-
-    LttEvent *event = ltt_tracefile_get_event(tfc->tf);
-
-    ret = ltt_event_position_compare((LttEventPosition*)event, 
-                                      ep);
+    
+    if(ep == NULL) {
+      if(ltt_time_compare(tfc->timestamp, ltt_time_infinite) != 0) {
+        ret = -1;
+      }
+    } else {
+      if(ltt_time_compare(tfc->timestamp, ltt_time_infinite) == 0) {
+        ret = 1;
+      } else {
+        LttEvent *event = ltt_tracefile_get_event(tfc->tf);
+
+        ret = ltt_event_position_compare((LttEventPosition*)event, 
+                                          ep);
+      }
+    }
     if(ret != 0) return ret;
 
   }
@@ -1038,20 +1117,35 @@ gint lttv_traceset_context_pos_pos_compare(
   
   for(i=0;i<pos1->ep->len;i++) {
     LttEventPosition *ep1 = g_array_index(pos1->ep, LttEventPosition*, i);
-    LttTracefile *tf1 = ltt_event_position_tracefile(ep1);
+    LttvTracefileContext *tfc1 = g_array_index(pos1->tfc,
+                                      LttvTracefileContext*, i);
     
-    for(j=0;j<pos2->ep->len;j++) {
-      LttEventPosition *ep2 = g_array_index(pos2->ep, LttEventPosition*, j);
-      LttTracefile *tf2 = ltt_event_position_tracefile(ep2);
-
-      if(tf1 == tf2) {
-        ret = ltt_event_position_compare(ep1, ep2);
-        if(ret != 0) return ret;
+    if(ep1 != NULL) {
+      for(j=0;j<pos2->ep->len;j++) {
+        LttEventPosition *ep2 = g_array_index(pos2->ep, LttEventPosition*, j);
+        LttvTracefileContext *tfc2 = g_array_index(pos2->tfc,
+                                           LttvTracefileContext*, j);
+        if(tfc1 == tfc2) {
+          if(ep2 != NULL)
+            ret = ltt_event_position_compare(ep1, ep2);
+          else
+            ret = -1;
+
+          if(ret != 0) return ret;
+        }
+      }
+    } else {
+      for(j=0;j<pos2->ep->len;j++) {
+        LttEventPosition *ep2 = g_array_index(pos2->ep, LttEventPosition*, j);
+        LttvTracefileContext *tfc2 = g_array_index(pos2->tfc,
+                                           LttvTracefileContext*, j);
+        if(tfc1 == tfc2) {
+          if(ep2 != NULL) ret = 1;
+        }
       }
     }
   }
   return 0;
-
 }
 
 
This page took 0.029405 seconds and 4 git commands to generate.