projects
/
lttng-ust.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Fix: power of 2 size check should apply to size_t type, not uint32_t
[lttng-ust.git]
/
libringbuffer
/
ring_buffer_backend.c
diff --git
a/libringbuffer/ring_buffer_backend.c
b/libringbuffer/ring_buffer_backend.c
index 769e24bffa0c35475aee4ddcec62b60b4b618d93..e949a5e292d2048f306760f329f64d668a0c30cd 100644
(file)
--- a/
libringbuffer/ring_buffer_backend.c
+++ b/
libringbuffer/ring_buffer_backend.c
@@
-218,11
+218,12
@@
int channel_backend_init(struct channel_backend *chanb,
return -EINVAL;
/*
return -EINVAL;
/*
- * Make sure the number of subbuffers and subbuffer size are power of 2.
+ * Make sure the number of subbuffers and subbuffer size are
+ * power of 2, and nonzero.
*/
*/
- if (
hweight32(subbuf_size) != 1
)
+ if (
!subbuf_size || (subbuf_size & (subbuf_size - 1))
)
return -EINVAL;
return -EINVAL;
- if (
hweight32(num_subbuf) != 1
)
+ if (
!num_subbuf || (num_subbuf & (num_subbuf - 1))
)
return -EINVAL;
ret = subbuffer_id_check_index(config, num_subbuf);
return -EINVAL;
ret = subbuffer_id_check_index(config, num_subbuf);
This page took
0.023003 seconds
and
4
git commands to generate.