Remove spurious read-side infinite loops.

[urcu.git] / formal-model / urcu.spin

diff --git a/formal-model/urcu.spin b/formal-model/urcu.spin
index e5bfff32464c0e4d6d0985df50cb8fa6db2555b0..eea18e8a27323f50dea0fa23fd668086b5ea46be 100644 (file)
--- a/formal-model/urcu.spin
+++ b/formal-model/urcu.spin
@@ -27,6 +27,10 @@ bit free = 0;     /* Has RCU reclamation happened, e.g., kfree()? */
 bit need_mb = 0;  /* =1 says need reader mb, =0 for reader response. */
 byte reader_progress[4];
                  /* Count of read-side statement executions. */
+bit reader_done = 0;
+                 /* =0 says reader still running, =1 says done. */
+bit updater_done = 0;
+                 /* =0 says updater still running, =1 says done. */
 
 /* urcu definitions and variables, taken straight from the algorithm. */
 
@@ -50,7 +54,7 @@ proctype urcu_reader()
        do
        :: need_mb == 1 ->
                need_mb = 0;
-       :: 1 -> skip;
+       :: !updater_done -> skip;
        :: 1 -> break;
        od;
 
@@ -92,7 +96,7 @@ proctype urcu_reader()
                                    reader_progress[2] +
                                    reader_progress[3] == 0) && need_mb == 1 ->
                                        need_mb = 0;
-                               :: 1 -> skip;
+                               :: !updater_done -> skip;
                                :: 1 -> break;
                                od;
                                urcu_active_readers = tmp;
@@ -124,9 +128,13 @@ proctype urcu_reader()
                                break;
                        :: tmp < 4 && reader_progress[tmp] != 0 ->
                                tmp = tmp + 1;
-                       :: tmp >= 4 ->
+                       :: tmp >= 4 &&
+                          reader_progress[0] == reader_progress[3] ->
                                done = 1;
                                break;
+                       :: tmp >= 4 &&
+                          reader_progress[0] != reader_progress[3] ->
+                               break;
                        od;
                        do
                        :: tmp < 4 && reader_progress[tmp] == 0 ->
@@ -146,7 +154,7 @@ proctype urcu_reader()
                        do
                        :: need_mb == 1 ->
                                need_mb = 0;
-                       :: 1 -> skip;
+                       :: !updater_done -> skip;
                        :: 1 -> break;
                        od;
                :: else -> skip;
@@ -163,11 +171,14 @@ proctype urcu_reader()
        od;
        assert((tmp_free == 0) || (tmp_removed == 1));
 
+       /* Reader has completed. */
+       reader_done = 1;
+
        /* Process any late-arriving memory-barrier requests. */
        do
        :: need_mb == 1 ->
                need_mb = 0;
-       :: 1 -> skip;
+       :: !updater_done -> skip;
        :: 1 -> break;
        od;
 }
@@ -244,6 +255,12 @@ proctype urcu_updater()
 
        /* free-up step, e.g., kfree(). */
        free = 1;
+
+       /*
+        * Signal updater done, ending any otherwise-infinite loops
+        * in the reading process.
+        */
+       updater_done = 1;
 }
 
 /*