From aeef352f476cf7b0f8a4ca032f7d94164be0292f Mon Sep 17 00:00:00 2001 From: Mathieu Desnoyers Date: Mon, 18 Nov 2013 21:16:06 -0500 Subject: [PATCH] Fix: move va_end to outermost label Coverity: ** CID 1021237: Missing varargs init or cleanup (VARARGS) /snprintf/vfprintf.c: 955 in ust_safe_vfprintf() Signed-off-by: Mathieu Desnoyers --- snprintf/vfprintf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/snprintf/vfprintf.c b/snprintf/vfprintf.c index cedd4fb7..896a8840 100644 --- a/snprintf/vfprintf.c +++ b/snprintf/vfprintf.c @@ -934,7 +934,6 @@ number: if ((dprec = prec) >= 0) done: FLUSH(); error: - va_end(orgap); if (__sferror(fp)) ret = -1; goto finish; @@ -944,6 +943,7 @@ overflow: ret = -1; finish: + va_end(orgap); #ifdef FLOATING_POINT if (dtoaresult) __freedtoa(dtoaresult); -- 2.34.1