lttng-ust.git
11 years agoFilter: add missing specialized op names
Mathieu Desnoyers [Tue, 17 Jul 2012 19:10:51 +0000 (15:10 -0400)] 
Filter: add missing specialized op names

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFilter: specialize double-s64 binary comparators
Mathieu Desnoyers [Tue, 17 Jul 2012 19:07:43 +0000 (15:07 -0400)] 
Filter: specialize double-s64 binary comparators

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix filter: fix stack leak on taken branch
Mathieu Desnoyers [Tue, 17 Jul 2012 18:22:49 +0000 (14:22 -0400)] 
Fix filter: fix stack leak on taken branch

Also fix return op stack check in validation.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFilter: Implement stack-based interpreter
Mathieu Desnoyers [Mon, 16 Jul 2012 21:56:31 +0000 (17:56 -0400)] 
Filter: Implement stack-based interpreter

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFilter: double comparator produces s64
Mathieu Desnoyers [Mon, 16 Jul 2012 19:57:38 +0000 (15:57 -0400)] 
Filter: double comparator produces s64

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFilter: use hash table to check merge points
Mathieu Desnoyers [Mon, 16 Jul 2012 19:46:57 +0000 (15:46 -0400)] 
Filter: use hash table to check merge points

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFilter: split passes into separate components
Mathieu Desnoyers [Mon, 16 Jul 2012 16:31:44 +0000 (12:31 -0400)] 
Filter: split passes into separate components

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFilter: cleanup macros
Mathieu Desnoyers [Mon, 16 Jul 2012 15:18:14 +0000 (11:18 -0400)] 
Filter: cleanup macros

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFilter: validate range overflow with end of insn
Mathieu Desnoyers [Mon, 16 Jul 2012 15:15:02 +0000 (11:15 -0400)] 
Filter: validate range overflow with end of insn

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFilter: validate that field ref strings are non-NULL
Mathieu Desnoyers [Mon, 16 Jul 2012 14:39:19 +0000 (10:39 -0400)] 
Filter: validate that field ref strings are non-NULL

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFilter: ensure logical operator merge is always s64
Mathieu Desnoyers [Sat, 14 Jul 2012 03:25:20 +0000 (23:25 -0400)] 
Filter: ensure logical operator merge is always s64

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFilter: we don't care if double/s64 are literals
Mathieu Desnoyers [Fri, 13 Jul 2012 23:05:09 +0000 (19:05 -0400)] 
Filter: we don't care if double/s64 are literals

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFilter: specialize 'and' and 'or' ops.
Mathieu Desnoyers [Fri, 13 Jul 2012 23:00:15 +0000 (19:00 -0400)] 
Filter: specialize 'and' and 'or' ops.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoImplement dispatch-table based interpretor
Mathieu Desnoyers [Fri, 13 Jul 2012 22:10:34 +0000 (18:10 -0400)] 
Implement dispatch-table based interpretor

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFilter: Specialize unary operators
Mathieu Desnoyers [Fri, 13 Jul 2012 21:58:59 +0000 (17:58 -0400)] 
Filter: Specialize unary operators

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoDefine switch use as macro in interpreter
Mathieu Desnoyers [Fri, 13 Jul 2012 21:53:22 +0000 (17:53 -0400)] 
Define switch use as macro in interpreter

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFilter interpreter: mark float test as unlikely
Mathieu Desnoyers [Fri, 13 Jul 2012 21:29:45 +0000 (17:29 -0400)] 
Filter interpreter: mark float test as unlikely

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFilter: fix bytecode validation typo
Mathieu Desnoyers [Fri, 13 Jul 2012 21:28:16 +0000 (17:28 -0400)] 
Filter: fix bytecode validation typo

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFilter: specialize comparators
Mathieu Desnoyers [Fri, 13 Jul 2012 21:15:44 +0000 (17:15 -0400)] 
Filter: specialize comparators

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoSpecialize load and unary ops
Mathieu Desnoyers [Fri, 13 Jul 2012 20:45:27 +0000 (16:45 -0400)] 
Specialize load and unary ops

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoValidate registers, no need to initialize to 0
Mathieu Desnoyers [Fri, 13 Jul 2012 20:21:34 +0000 (16:21 -0400)] 
Validate registers, no need to initialize to 0

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFilter: opcode for ref loads
Mathieu Desnoyers [Fri, 13 Jul 2012 20:05:38 +0000 (16:05 -0400)] 
Filter: opcode for ref loads

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoRemove redundant validation from interpreter
Mathieu Desnoyers [Fri, 13 Jul 2012 19:25:22 +0000 (15:25 -0400)] 
Remove redundant validation from interpreter

With the new validation pass, we can remove redundant validation from
the interpreter.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agofilter: Add bytecode validation pass
Mathieu Desnoyers [Fri, 13 Jul 2012 19:07:19 +0000 (15:07 -0400)] 
filter: Add bytecode validation pass

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoTRACEPOINT_EVENT: add *_nowrite fields for filter
Mathieu Desnoyers [Fri, 13 Jul 2012 18:06:12 +0000 (14:06 -0400)] 
TRACEPOINT_EVENT: add *_nowrite fields for filter

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoOnly print filter errors if LTTNG_UST_DEBUG is set
Mathieu Desnoyers [Fri, 13 Jul 2012 17:26:15 +0000 (13:26 -0400)] 
Only print filter errors if LTTNG_UST_DEBUG is set

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoCleanup: remove debug define
Mathieu Desnoyers [Fri, 13 Jul 2012 17:07:36 +0000 (13:07 -0400)] 
Cleanup: remove debug define

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFilter: add floating point support
Mathieu Desnoyers [Fri, 13 Jul 2012 17:05:35 +0000 (13:05 -0400)] 
Filter: add floating point support

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoRemove filter test printouts
Mathieu Desnoyers [Thu, 12 Jul 2012 17:27:19 +0000 (13:27 -0400)] 
Remove filter test printouts

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoImplement filter bytecode interpreter and linker
Mathieu Desnoyers [Thu, 12 Jul 2012 16:59:06 +0000 (12:59 -0400)] 
Implement filter bytecode interpreter and linker

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFilter: receive, attach and link empty filter
Mathieu Desnoyers [Tue, 10 Jul 2012 18:49:43 +0000 (14:49 -0400)] 
Filter: receive, attach and link empty filter

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFilter: prepare filter stack data
Mathieu Desnoyers [Sun, 8 Jul 2012 17:35:48 +0000 (13:35 -0400)] 
Filter: prepare filter stack data

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoWrap dynamic len array into stackvar union
Mathieu Desnoyers [Sun, 8 Jul 2012 15:53:30 +0000 (11:53 -0400)] 
Wrap dynamic len array into stackvar union

In preparation for filter array.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoliblttng-ust-comm/lttng-ust-com.c: remove unnecessary goto in ustcomm_accept_unix_sock()
Henrik Hautakoski [Tue, 26 Jun 2012 05:59:36 +0000 (07:59 +0200)] 
liblttng-ust-comm/lttng-ust-com.c: remove unnecessary goto in ustcomm_accept_unix_sock()

Signed-off-by: Henrik Hautakoski <henrik@fiktivkod.org>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoliblttng-ust/lttng-ust-comm.c: fixing typo.
Henrik Hautakoski [Tue, 26 Jun 2012 05:55:59 +0000 (07:55 +0200)] 
liblttng-ust/lttng-ust-comm.c: fixing typo.

Signed-off-by: Henrik Hautakoski <henrik@fiktivkod.org>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: remove unused texinfo dep from configure.ac
Mathieu Desnoyers [Wed, 20 Jun 2012 20:00:34 +0000 (16:00 -0400)] 
Fix: remove unused texinfo dep from configure.ac

Fixes #274

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix C99 strict compatibility: don't use void * for function pointers
Mathieu Desnoyers [Tue, 19 Jun 2012 17:45:05 +0000 (13:45 -0400)] 
Fix C99 strict compatibility: don't use void * for function pointers

compiling public headers with --std=x99 -pedantic shows:

warning: ISO C forbids conversion of object pointer to function pointer type

Use "void (*func)(void)" to represent a generic function pointer rather
than "void *".

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix c99 compatibility: tp_rcu_dereference_bp() should not use braced-groups within...
Mathieu Desnoyers [Mon, 18 Jun 2012 14:22:12 +0000 (10:22 -0400)] 
Fix c99 compatibility: tp_rcu_dereference_bp() should not use braced-groups within expressions

Allow tp_rcu_dereference_bp() to be used within programs compiled with
--std=c99 -pedantic -Werror. Fixes the following:

In file included from hello.c:34:0:
ust_tests_hello.h: In function ‘__tracepoint_cb_ust_tests_hello___tptest’:
ust_tests_hello.h:28:1: warning: ISO C forbids braced-groups within expressions [-pedantic]
ust_tests_hello.h:28:1: warning: ISO C forbids conversion of object pointer to function pointer type [-pedantic]

We can easily fix this one since tp_rcu_dereference_bp() really
evaluates only a single expression.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoRevert "Fix c99 compatibility: tp_rcu_dereference_bp() should not use braced-groups...
Mathieu Desnoyers [Mon, 18 Jun 2012 14:21:44 +0000 (10:21 -0400)] 
Revert "Fix c99 compatibility: tp_rcu_dereference_bp() should not use braced-groups within expressions"

This reverts commit a4eaf8eabe829be8f7d7432ffaf83291a068b0ed.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix c99 compatibility: tp_rcu_dereference_bp() should not use braced-groups within...
Mathieu Desnoyers [Mon, 18 Jun 2012 14:10:36 +0000 (10:10 -0400)] 
Fix c99 compatibility: tp_rcu_dereference_bp() should not use braced-groups within expressions

Allow tp_rcu_dereference_bp() to be used within programs compiled with
--std=c99 -pedantic -Werror. Fixes the following:

In file included from hello.c:34:0:
ust_tests_hello.h: In function ‘__tracepoint_cb_ust_tests_hello___tptest’:
ust_tests_hello.h:28:1: warning: ISO C forbids braced-groups within expressions [-pedantic]
ust_tests_hello.h:28:1: warning: ISO C forbids conversion of object pointer to function pointer type [-pedantic]

We can easily fix this one since tp_rcu_dereference_bp() really
evaluates only a single expression.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: perform TLS fixup of nest count outside of UST mutex
Mathieu Desnoyers [Wed, 13 Jun 2012 08:46:44 +0000 (04:46 -0400)] 
Fix: perform TLS fixup of nest count outside of UST mutex

Could otherwise lead to a deadlock between the dynamic linker, TLS
fixup, and the UST mutex due to reversed lock acquisition order.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: liblttng-ust-fork deadlock
Mathieu Desnoyers [Wed, 13 Jun 2012 08:26:34 +0000 (04:26 -0400)] 
Fix: liblttng-ust-fork deadlock

* Mathieu Desnoyers (mathieu.desnoyers@efficios.com) wrote:
> * Burton, Michael (mburton@ciena.com) wrote:
> > Mathieu,
> >
> > I think there is a deadlock scenario in UST, which has been causing my problem.
>
> Good catch !
>
> >
> > sessiond is started as root:
> >     - creates global sockets ONLY
> >     - DOES NOT CREATE shm in $HOME/lttng-ust-wait-<uid>
> >
> > application linked against ust is run as root:
> >   - in lttng_ust_init constructor
> >   - ust_listener_thread  (local_apps)
> >     - fails to connect to local_apps in $HOME/.lttng (as expected)
> >     - prev_connect_failed=1
> >     - ust_unlock()
> >     - restart
> >     - wait_for_sessiond()
> >  -->  - ust_lock()
> >  |      - get_map_shm()
> >  |        - get_wait_shm()
> > DEADLOCK    - shm_open() FAILS (not created by sessiond when run by root)
> >  |            - fork() (trying to create shared memory itself)
> >  |              - ust_before_fork()
> >  ------------>    - ust_lock()
> >
> >
> > You should be able to create this with an empty main, with no
> > tracepoints.  As long as sessiond is started as root so
> > $HOME/lttng-ust-wait-<uid> is not created.  You can also make the
> > lttng-ust constructor (lttng_ust_init) wait forever and then you'll be
> > able to see the deadlock in gdb without even leaving the
> > lttng_ust_init constructor.
>
> Ah, I see. This deadlock is caused by the interaction between
> [ liblttng-ust-fork ] and liblttng-ust (the fork override is
> performed by [ liblttng-ust-fork ]).

This can be reproduced easily with the in-tree tests: by removing the
lttng-ust-apps-wait* files belonging to the user in /dev/shm, running
the "tests/fork" test (with ./run) hangs. If we run "hello" first, and
then the fork test, it works fine.

Fixing this by keeping a nesting counter around the fork() call, so we
return immediately from the pre/post fork handlers if they are
overridden by liblttng-ust-fork.

Reported-by: Michael Burton <mburton@ciena.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: handle pthread errors
Mathieu Desnoyers [Wed, 13 Jun 2012 00:12:23 +0000 (20:12 -0400)] 
Fix: handle pthread errors

Show a descriptive error message if pthread calls fail.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: local apps allowed should disable local (not global) tracing
Mathieu Desnoyers [Wed, 13 Jun 2012 00:03:53 +0000 (20:03 -0400)] 
Fix: local apps allowed should disable local (not global) tracing

Reported-by: Michael Burton <mburton@ciena.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix strict ISO-C compatibility for ust-tracepoint-event.h public header
Mathieu Desnoyers [Tue, 12 Jun 2012 15:51:31 +0000 (11:51 -0400)] 
Fix strict ISO-C compatibility for ust-tracepoint-event.h public header

../../include/lttng/ust-tracepoint-event.h:328:23: warning: ISO C does not permit named variadic macros [-Wvariadic-macros]

Use ... and __VA_ARGS__ instead of args... and args.

This enables ISO-C compability for the tracepoint headers for program
instrumentation. Note that the probes need to be built _without_ strict
C99 flags (they require gnu extensions).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: support -std=c99 in tracepoint macros
Mathieu Desnoyers [Tue, 12 Jun 2012 15:22:46 +0000 (11:22 -0400)] 
Fix: support -std=c99 in tracepoint macros

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix c99 compatibility: use __typeof__ instead of typeof in public headers
Mathieu Desnoyers [Mon, 11 Jun 2012 14:15:25 +0000 (10:15 -0400)] 
Fix c99 compatibility: use __typeof__ instead of typeof in public headers

Reported-by: John Steele Scott <toojays@toojays.net>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agohello test: fail on old style definition
Mathieu Desnoyers [Mon, 11 Jun 2012 13:52:41 +0000 (09:52 -0400)] 
hello test: fail on old style definition

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: tracepoint.h should not generate old-style definitions
Mathieu Desnoyers [Mon, 11 Jun 2012 13:53:07 +0000 (09:53 -0400)] 
Fix: tracepoint.h should not generate old-style definitions

I've defined a tracepoint without arguments:

   TRACEPOINT_EVENT(

        qemu_tb_hash,

        flushall,

        TP_ARGS(void),

        TP_FIELDS()

   )

When I build (with -Werror=old-style-definition), I get this error:

   In file included from /home/hollisb/work/qemu.git/exec.c:59:0:

   /home/hollisb/work/qemu.git/tracepoints.h:24:2: error: function declaration isn’t a prototype [-Werror=strict-prototypes]

   /home/hollisb/work/qemu.git/tracepoints.h: In function ‘__tracepoint_cb_qemu_tb_hash___flushall’:

   /home/hollisb/work/qemu.git/tracepoints.h:24:2: error: old-style function definition [-Werror=old-style-definition]

   cc1: all warnings being treated as errors

The preprocessed code looks like so:

   extern struct

   # 129 "/usr/local/include/lttng/tracepoint.h" 3

                  tracepoint

   # 24 "/home/hollisb/work/qemu.git/tracepoints.h"

     __tracepoint_qemu_tb_hash___flushall

   # 19 "/home/hollisb/work/qemu.git/tracepoints.h"

     ; static __attribute__ (( always_inline )) __inline__ void

     __tracepoint_cb_qemu_tb_hash___flushall

   # 19 "/home/hollisb/work/qemu.git/tracepoints.h"

     () { struct tracepoint_probe *__tp_probe; if (!tracepoint_dlopen.rcu_read_lock_sym_bp) return; tracepoint_dlopen.rcu_read_lock_sym_bp(); __tp_probe = ({ typeof(__tracepoint_qemu_tb_hash___flushall.probes) _________p1 = ((typeof(__tracepoint_qemu_tb_hash___flushall.probes)) (tracepoint_dlopen.rcu_dereference_sym_bp(((void *) (__tracepoint_qemu_tb_hash___flushall.probes))))); (_________p1); }); if (__builtin_expect(!!(!__tp_probe), 0)) goto end; do { void *__tp_cb = __tp_probe->func; void *__tp_data = __tp_probe->data; ((void (*)(void *__tp_data)) (__tp_cb)) (__tp_data); } while ((++__tp_probe)->func); end: tracepoint_dlopen.rcu_read_unlock_sym_bp(); } static __attribute__ (( always_inline )) __inline__ void

I believe the problem comes from -Werror=old-style-definition not liking
that empty "()", i.e. tracepoint_cb_qemu_tb_hash___flushall() { ... }.

Reported-by: Hollis Blanchard <hollis_blanchard@mentor.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: don't define variables in headers
Mathieu Desnoyers [Fri, 8 Jun 2012 17:17:05 +0000 (13:17 -0400)] 
Fix: don't define variables in headers

From Hollis Blanchard <hollis_blanchard@mentor.com>:
> Hi, I was adding an LTTng UST 2.0 tracepoint to an application that uses
> -warn-common (see http://www.math.utah.edu/docs/info/ld_2.html). I created
> a simple tracepoint, had lttng-gen-tp produce tracepoints.o, then linked
> that to the application, along with -llttng-ust. This results in some
> warnings:
>
> tracepoints.o: warning: common of `handle' overridden by definition
> /usr/local/lib/liblttng-ust.so: warning: defined here
> tracepoints.o: warning: common of `lttng_client_callbacks_overwrite' overridden
> +by definition
> /usr/local/lib/liblttng-ust.so: warning: defined here
> tracepoints.o: warning: common of `lttng_client_callbacks_discard' overridden by
> +definition
> /usr/local/lib/liblttng-ust.so: warning: defined here
> tracepoints.o: warning: common of `lttng_client_callbacks_metadata' overridden
> +by definition
> /usr/local/lib/liblttng-ust.so: warning: defined here
> /usr/local/lib/liblttng-ust-tracepoint.so.0: warning: multiple common of
> +`handle'
> tracepoints.o: warning: previous common is here
>
> This seems to be a valid warning. The LTTng UST headers contain
> definitions like this in include/lttng/ringbuffer-config.h:
> struct lttng_ust_shm_handle *handle;
>
> If two objects use that header, each will get a copy of "handle", right?

handle: This was meant to be a forward declaration of

  struct lttng_ust_shm_handle

so just removing the "*handle" part. This can be considered as a
cleanup (or a fix without actual runtime effect).

lttng_client_callbacks_*: if the cb values would have been used in the
consumer daemon, this would have caused an issue: these would be set to
NULL instead of the actual callback pointers. So in a way this is a fix,
but it does not have any runtime impact at this point.

Reported-by: Hollis Blanchard <hollis_blanchard@mentor.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agotest "hello": add boolean test
Mathieu Desnoyers [Tue, 5 Jun 2012 17:15:52 +0000 (13:15 -0400)] 
test "hello": add boolean test

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: perform macro expansion on tracepoint signatures
Mathieu Desnoyers [Tue, 5 Jun 2012 17:08:54 +0000 (13:08 -0400)] 
Fix: perform macro expansion on tracepoint signatures

The problem can be seen by patching the demo test from lttng-ust as
follows:

--- a/tests/demo/ust_tests_demo3.h
+++ b/tests/demo/ust_tests_demo3.h
@@ -22,12 +22,14 @@ extern "C" {
  * all copies or substantial portions of the Software.
  */

+#include <stdbool.h>
+
 #include <lttng/tracepoint.h>

 TRACEPOINT_EVENT(ust_tests_demo3, done,
-       TP_ARGS(int, value),
+       TP_ARGS(bool, value),
        TP_FIELDS(
-               ctf_integer(int, value, value)
+               ctf_integer(bool, value, value)
        )
 )

Then when the demo is run with LTTNG_UST_DEBUG=1, a warning is shown,
like:

liblttng_ust_tracepoint[3315/3315]: Warning: Tracepoint signature mismatch, not
enabling one or more tracepoints. Ensure that the tracepoint probes prototypes
match the application. (in set_tracepoint() at tracepoint.c:310)
liblttng_ust_tracepoint[3315/3315]: Warning: Tracepoint "ust_tests_demo3:done"
signatures: call: "_Bool, value" vs probe: "bool, value". (in set_tracepoint()
at tracepoint.c:312)

It seems that TP_ARGS does not perform preprocessor expansion on the
"bool" type spec, while something underneath TP_FIELDS does. And since
(at least on this Centos 6.2 box) stdbool.h uses a #define rather than a
typedef to make bool equivalent to _Bool, liblttng detects a mismatch.

Reported-by: John Steele Scott <toojays@toojays.net>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoUST check pointer/de-reference order
Fredrik Oestman [Tue, 5 Jun 2012 15:21:36 +0000 (11:21 -0400)] 
UST check pointer/de-reference order

I stumbled across some code where pointers are de-referenced and then
checked for NULL.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix list field: handle error
Mathieu Desnoyers [Thu, 31 May 2012 20:13:08 +0000 (16:13 -0400)] 
Fix list field: handle error

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoImplement event fields listing
Mathieu Desnoyers [Wed, 30 May 2012 20:27:10 +0000 (16:27 -0400)] 
Implement event fields listing

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoImplement field listing command
Mathieu Desnoyers [Tue, 8 May 2012 12:13:02 +0000 (08:13 -0400)] 
Implement field listing command

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: Block all signals in listener thread
Wolfgang Puffitsch [Fri, 1 Jun 2012 16:04:37 +0000 (12:04 -0400)] 
Fix: Block all signals in listener thread

The listener thread does not block signals and receives signals that are
intended for the application. As this can cause applications to fail,
the listener thread should block all signals. The attached patch is
derived from an old commit and fixes the issue.

Fixes #241

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoAdd CodingStyle document to tarball
Mathieu Desnoyers [Wed, 30 May 2012 13:54:49 +0000 (09:54 -0400)] 
Add CodingStyle document to tarball

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoAdd coding style document
Mathieu Desnoyers [Wed, 30 May 2012 13:05:37 +0000 (09:05 -0400)] 
Add coding style document

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoendian.h: support cygwin
Mathieu Desnoyers [Thu, 24 May 2012 14:22:56 +0000 (10:22 -0400)] 
endian.h: support cygwin

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoalign.h: support cygwin page size
Mathieu Desnoyers [Thu, 24 May 2012 14:19:46 +0000 (10:19 -0400)] 
align.h: support cygwin page size

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoAdd cygwin support to libringbuffer getcpu.h
Mathieu Desnoyers [Thu, 24 May 2012 14:12:21 +0000 (10:12 -0400)] 
Add cygwin support to libringbuffer getcpu.h

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoAdd "2x int" and "2x long" types to the Java interface
Alexandre Montplaisir [Tue, 22 May 2012 16:38:17 +0000 (12:38 -0400)] 
Add "2x int" and "2x long" types to the Java interface

Since we have to statically define all the available event types,
offer types for two integers and two longs, which are relatively
common use cases.

Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir@polymtl.ca>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoAdd Integer and Long tracepoint types to the Java interface
Alexandre Montplaisir [Tue, 22 May 2012 16:37:49 +0000 (12:37 -0400)] 
Add Integer and Long tracepoint types to the Java interface

Also added Javadoc comments to the .java file.

Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir@polymtl.ca>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix: don't SIGBUS when filesystem is full
Mathieu Desnoyers [Fri, 18 May 2012 21:07:06 +0000 (17:07 -0400)] 
Fix: don't SIGBUS when filesystem is full

Write zeroes into the buffer after its allocation to ensure that writes
to the shm will not trigger SIGBUS upon full filesystem situations.

This scenario can occur if /dev/shm is filled, e.g. by specifying too
large buffers with --enable-channel.

When the write() fails, the buffer creation for this channel fails.

Fixes #230

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agotracepoint: include stdio.h for NULL definition
Mathieu Desnoyers [Tue, 15 May 2012 17:31:07 +0000 (13:31 -0400)] 
tracepoint: include stdio.h for NULL definition

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agomanpage update: document that probes need gcc
Mathieu Desnoyers [Tue, 15 May 2012 12:51:07 +0000 (08:51 -0400)] 
manpage update: document that probes need gcc

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix: remove # in front on extern "C" {
Mathieu Desnoyers [Tue, 15 May 2012 12:40:04 +0000 (08:40 -0400)] 
Fix: remove # in front on extern "C" {

Fails to compile with g++.

Reported-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoCleanup: don't use GNU old-style field designator extension
Mathieu Desnoyers [Thu, 10 May 2012 18:33:38 +0000 (14:33 -0400)] 
Cleanup: don't use GNU old-style field designator extension

ustfork.c:112:38: warning: use of GNU old-style field designator extension
      [-Wgnu-designator]
                struct ustfork_clone_info info = { fn: fn, arg: arg };
                                                   ^~~
                                                   .fn =
ustfork.c:112:46: warning: use of GNU old-style field designator extension
      [-Wgnu-designator]
                struct ustfork_clone_info info = { fn: fn, arg: arg };
                                                           ^~~~
                                                           .arg =

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix: remove padding field after variable sized array
Mathieu Desnoyers [Thu, 10 May 2012 18:31:28 +0000 (14:31 -0400)] 
Fix: remove padding field after variable sized array

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoUse unsigned long type for events discarded counter
Mathieu Desnoyers [Wed, 2 May 2012 15:43:04 +0000 (11:43 -0400)] 
Use unsigned long type for events discarded counter

Overflows at 64-bit on 64-bit systems.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix: getcpu build with modern uClibc versions
Peter Korsgaard [Thu, 26 Apr 2012 21:07:47 +0000 (17:07 -0400)] 
Fix: getcpu build with modern uClibc versions

uClibc has sched_getcpu since 0.9.33, so the compat workaround should
only be used for older uClibc versions.

Fixes #225

Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix: lttng-ust.pc needs to specify -ldl
Mathieu Desnoyers [Wed, 25 Apr 2012 20:27:09 +0000 (16:27 -0400)] 
Fix: lttng-ust.pc needs to specify -ldl

Fixes #224

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix: examples Makefiles should pass $(LIBS) at last
Mathieu Desnoyers [Wed, 18 Apr 2012 20:17:56 +0000 (16:17 -0400)] 
Fix: examples Makefiles should pass $(LIBS) at last

Fixes #210

Description

Since Ubuntu 11.10, the "--as-needed" option is given by default to ld
(linker). This option breaks the makefiles given with the userspace
tracing examples. Therefore the libraries against which the program
should be linked should be passed at last:
$(CC) -o $@ $^ $(LIBS)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoBuild a jar for the Java side of the JNI interface
Alexandre Montplaisir [Thu, 12 Apr 2012 13:39:55 +0000 (09:39 -0400)] 
Build a jar for the Java side of the JNI interface

Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir@polymtl.ca>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix: ustctl need to send the second fd upon error of 1st fd
Mathieu Desnoyers [Mon, 9 Apr 2012 15:02:42 +0000 (11:02 -0400)] 
Fix: ustctl need to send the second fd upon error of 1st fd

Otherwise cause protocol discrepancy between ust and sessiond upon send
error. The sessiond will wait for an fd that never arrives.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix: Add missing fork test program dependency library
Mathieu Desnoyers [Fri, 6 Apr 2012 00:56:38 +0000 (20:56 -0400)] 
Fix: Add missing fork test program dependency library

Only seem to affect some setups (e.g. older gcc ?) with the BSD
compatibility.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix: Make the JNI interface actually work
Alexandre Montplaisir [Thu, 5 Apr 2012 21:15:57 +0000 (17:15 -0400)] 
Fix: Make the JNI interface actually work

Now a user can import LTTngUst.java (which is now in a proper
package) and then define tracepoints in his application with:

LTTngUst.tracepointString(name, args);

We could eventually ship it in a .jar when the JNI interface is
enabled. It's still very basic, only string payloads are
implemented, and there is no mechanism to enable/disable trace
points call sites at runtime (they are always enabled). The event under
which these events appear is "lttng_ust_java:string".

Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir@polymtl.ca>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoMerge branch 'dev'
Mathieu Desnoyers [Thu, 5 Apr 2012 17:21:08 +0000 (13:21 -0400)] 
Merge branch 'dev'

12 years agoFix: stringify version description
Mathieu Desnoyers [Thu, 5 Apr 2012 17:20:25 +0000 (13:20 -0400)] 
Fix: stringify version description

Note: config.h is unused in lttng 2.0, so no need to backport this fix.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoUpdate version to 2.0.1 v2.0.1
Mathieu Desnoyers [Thu, 29 Mar 2012 04:48:12 +0000 (00:48 -0400)] 
Update version to 2.0.1

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoUse bsd-compatible fcntl for close-on-exec on socket
Mathieu Desnoyers [Tue, 21 Feb 2012 03:01:52 +0000 (22:01 -0500)] 
Use bsd-compatible fcntl for close-on-exec on socket

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix multi-session wildcard support
Mathieu Desnoyers [Tue, 27 Mar 2012 20:15:20 +0000 (16:15 -0400)] 
Fix multi-session wildcard support

Incorrectly unset loglevel information upon creation of wildcard_entry
was causing a second session with wildcard enabled to not record its
events.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix event lost count when buffer is full
Mathieu Desnoyers [Tue, 27 Mar 2012 19:41:42 +0000 (15:41 -0400)] 
Fix event lost count when buffer is full

The tracing channels should count lost events due to buffer full, and
the metadata channel should not (see comment), but not the opposite.
This was a mixup between the two.

Reported-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoRemove inappropriate \n from easy-ust sample
Mathieu Desnoyers [Sun, 25 Mar 2012 23:52:07 +0000 (19:52 -0400)] 
Remove inappropriate \n from easy-ust sample

Although \n is permitted in strings, it adds newlines in the trace
pretty-printer output, which is not that nice.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoUpdate version to 2.0.0 stable v2.0.0
Mathieu Desnoyers [Tue, 20 Mar 2012 22:33:26 +0000 (18:33 -0400)] 
Update version to 2.0.0 stable

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agomake dist: Generate bzip2 instead of gzip
Mathieu Desnoyers [Tue, 20 Mar 2012 21:34:28 +0000 (17:34 -0400)] 
make dist: Generate bzip2 instead of gzip

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoUpdate version to 2.0.0-rc4 v2.0.0-rc4
Mathieu Desnoyers [Tue, 20 Mar 2012 21:05:09 +0000 (17:05 -0400)] 
Update version to 2.0.0-rc4

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix out-of-bound write in ltt-events.c
Mathieu Desnoyers [Tue, 20 Mar 2012 18:24:36 +0000 (14:24 -0400)] 
Fix out-of-bound write in ltt-events.c

Valgrind complains that the size allocated is too small for the memcpy,
rightly so (off by one).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoDocument LTTNG_UST_DEBUG_VALGRIND compilation flag
Mathieu Desnoyers [Tue, 20 Mar 2012 18:13:54 +0000 (14:13 -0400)] 
Document LTTNG_UST_DEBUG_VALGRIND compilation flag

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoUpdate COPYING
Mathieu Desnoyers [Mon, 19 Mar 2012 18:28:04 +0000 (14:28 -0400)] 
Update COPYING

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoAdd exception handling to lttng-gen-tp io operations
Yannick Brosseau [Mon, 19 Mar 2012 17:22:48 +0000 (13:22 -0400)] 
Add exception handling to lttng-gen-tp io operations

(closes: 54)

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoUpdate version to 2.0.0-rc3 v2.0.0-rc3
Mathieu Desnoyers [Fri, 16 Mar 2012 19:34:03 +0000 (15:34 -0400)] 
Update version to 2.0.0-rc3

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix: sendmsg should retry on EINTR, and use MSG_NOSIGNAL
Mathieu Desnoyers [Wed, 14 Mar 2012 18:55:35 +0000 (14:55 -0400)] 
Fix: sendmsg should retry on EINTR, and use MSG_NOSIGNAL

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agofix: ustcomm_close_unix_sock should close, not shutdown
Mathieu Desnoyers [Wed, 14 Mar 2012 18:49:21 +0000 (14:49 -0400)] 
fix: ustcomm_close_unix_sock should close, not shutdown

.. and ensure that we actually use the API rather than doing the close()
directly in the caller.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix: do not print EPIPE perror, as it is an expected error
Mathieu Desnoyers [Wed, 14 Mar 2012 18:43:32 +0000 (14:43 -0400)] 
Fix: do not print EPIPE perror, as it is an expected error

It is perfectly valid for the other end to close its socket, so do not
report broken pipe errors as perror.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoEnsure that multiplication of clock offset is done on 64-bit
Mathieu Desnoyers [Tue, 13 Mar 2012 20:09:52 +0000 (16:09 -0400)] 
Ensure that multiplication of clock offset is done on 64-bit

This is not a bug in UST per se, because we happen to force
multiplication by a ULL number, but force cast to uint64_t anyway to
ensure we don't trigger this overflow if the constant ever happen to
change.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoAdd 2 missing licenses in deprecated tests
Mathieu Desnoyers [Thu, 8 Mar 2012 19:11:22 +0000 (14:11 -0500)] 
Add 2 missing licenses in deprecated tests

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoRemove unbuild and unused (deprecated) make_shared_lib test
Mathieu Desnoyers [Thu, 8 Mar 2012 19:06:49 +0000 (14:06 -0500)] 
Remove unbuild and unused (deprecated) make_shared_lib test

Was for UST 0.x.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoLicense text standardization, add missing licenses
Mathieu Desnoyers [Thu, 8 Mar 2012 19:04:09 +0000 (14:04 -0500)] 
License text standardization, add missing licenses

- Use MIT/X11 text for BSD-style license.
- Fix FSF address.
- Use appropriate LTTNG_ prefix for ifndef (rather than LINUX).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
This page took 0.045525 seconds and 4 git commands to generate.